master
Just use the default CDIAGFLAGS rather than defining our own.
remove redundant variable declarations in Makefiles, since those are the default.
Import of Less 458
Merge in less 444 plus local changes
$OpenBSD$
Merge upstream bug fixes
Delete support for the LESSOPEN and LESSCLOSE environment variables aka the "Input Preprocessor": it's been a source for multiple security bugs in the past as everything has to deal with handling arbitrary filenames and generally resulted in multiple TOCTOU issues. The base system never included a default LESSOPEN setting like some Linux distributions did, but it's a suds-filled sink full of knives to try to use safely.
Delete what remains of the support for combining characters into ligatures: it was incomplete (only for the Arabic script and only for the single ligature LAM WITH ALEF) and it was implemented in a way that is unsustainable (with a static table inside less).
trivial replacement of the home-grown IS_ASCII_OCTET() with the standard isascii(3)
Remove support for ! to run a shell command, we have ^Z around these parts. ok ratchov jung millert
Remove wpath from secure mode pledge.
remove superfluous macro
remove unused functions; ok tb@
remove externs for removed vars
little bit more KNF
less uses a correct raceless signal method of indicating signal events in a volatile sig_atomic_t variable, and then processing events in the mainloop. But only one variable was used for 3 signals, with |= bit operations which are signal interruptable! Rewrite the code to use 3 independent variables and cleanup how the mainloop observes indications. ok schwarze
"!command" notation was zapped 8 years ago - remove corresponding entry from the help file; from piotr durlej
imrove the description of lesskey; based on a diff from richard ulmer ok deraadt schwarze
Garrett D'Amore has agreed to moving his copyright line up above the terms with the existing copyright, so it is clear it applies the same terms.
Fix possible use after free with long lines
adjust a variable name in a comment after the reorg in signal.c rev. 1.18
- more no longer accepts random less commands - history trim - sundry
zap double full stop; ok schwarze
When performing an inverted search in less, make sure to invalidate the match bounds prior calling regexec(). In this inverted scenario a match is found when regexec() returns false causing the bounds to not be updated. This is problematic since the bounds will then refer to a previous match and future pointer arithmetic will eventually be off which is manifested in a SIGSEGV.
spelling fixes; from paul tagliamonte amendments to his diff are noted on tech