master
Move ibuf API from imsg_init.3 to ibuf_add.3
More imsg function additions:
.Lb libutil ; OK tedu@
spelling fixes; from paul tagliamonte any changes not taken noted on tech, but chiefly here i did not take the cancelation - cancellation changes;
Give ober_printf_elements() a ber_element array, similar to ober_scanf_elements(). This allows us to move down and back up multiple levels in with nested sequences and sets.
Bump BER_MAX_OID_LEN to 128
For open/openat, if the flags parameter does not contain O_CREAT, the 3rd (variadic) mode_t parameter is irrelevant. Many developers in the past have passed mode_t (0, 044, 0644, or such), which might lead future people to copy this broken idiom, and perhaps even believe this parameter has some meaning or implication or application. Delete them all. This comes out of a conversation where tb@ noticed that a strange (but intentional) pledge behaviour is to always knock-out high-bits from mode_t on a number of system calls as a safety factor, and his bewilderment that this appeared to be happening against valid modes (at least visually), but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef. ok millert
ANSIfy forkpty, add missing $OpenBSD$ in duid.c, style (no arg names) in util.h.
The mdoc(7) .Ft macro does not need quoting of its arguments, but about 10% of our manual pages using this macro employed useless quoting anyway. Remove these quotes such that they do not incite fear, uncertainty, and doubt in developers who happen to look at these pages. jmc@ and tb@ agree with the direction.
Christos Zoulas agreed to rescind clause 3 and 4 in NetBSD fsck.8 rev 1.35 fsutil.h rev 1.14 pathnames.h rev 1.2 netgroup_mkdb.8 rev 1.9 netgroup_mkdb.c rev 1.18 str.c rev 1.7 str.h rev 1.4 rdate.8 rev 1.11 rdate.c rev 1.19 extern.h rev 1.14 getnetgrent.c rev 1.41 netgroup.h rev 1.10 fparseln.3 rev 1.4 fparseln.c rev 1.10
make fixed-sized fixed-value mib[] arrays be const ok guenther tb millert
Preserve errno in ibuf_free() so we don't have to do it in the callers. OK tb@
Set the initial imsg header len to 0 in imsg_create().
Add back #include <sys/types.h> for pid_t
Switch login(3) from lseek+read/write to pread/pwrite and only do the pread() if the data is needed. Use O_CLOEXEC on the internal fd as MT paranoia. Fix cast in offset calculation; delete register keyword; prefer memset() over bzero()
sys/types.h rather than sys/param.h, where applicable. avoid overreach.
When system calls indicate an error they return -1, not some arbitrary value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.
merge ohash into 1 source file, then we can revisit next roadmap items. ok espie
Backout "Only return file descriptors to block or character devices"
Actually, the C standard only guarantees that atexit(3) returns non-zero on error, so tweak previous to test "atexit(...) != 0" for portability. "OK ok ok sorry backwards" deraadt@
remove unneeded semicolons; checked by millert@
Make the termp and winp arguments for openpty, et al. const. This matches the prototypes in glibc and musl libc. From Matthew Martin. OK tb@
Bump minor version because of symbol additions.
Mark pw_error as __dead in prototype to match the function definition. From Matthew Martin.
snprintf/vsnprintf return < 0 on error, rather than -1.