git

1
ifndef COMPILER_FEATURES
2
COMPILER_FEATURES := $(shell ./detect-compiler $(CC))
3
endif
4

5
ifeq ($(filter no-error,$(DEVOPTS)),)
6
DEVELOPER_CFLAGS += -Werror
7
SPARSE_FLAGS += -Wsparse-error
8
endif
9

10
DEVELOPER_CFLAGS += -Wall
11
ifeq ($(filter no-pedantic,$(DEVOPTS)),)
12
DEVELOPER_CFLAGS += -pedantic
13
ifneq ($(or $(filter gcc5,$(COMPILER_FEATURES)),$(filter clang4,$(COMPILER_FEATURES))),)
14
DEVELOPER_CFLAGS += -Wpedantic
15
ifneq ($(filter gcc10,$(COMPILER_FEATURES)),)
16
ifeq ($(uname_S),MINGW)
17
DEVELOPER_CFLAGS += -Wno-pedantic-ms-format
18
endif
19
endif
20
endif
21
endif
22

23
ifneq ($(uname_S),FreeBSD)
24
ifneq ($(or $(filter gcc6,$(COMPILER_FEATURES)),$(filter clang7,$(COMPILER_FEATURES))),)
25
DEVELOPER_CFLAGS += -std=gnu99
26
endif
27
else
28
# FreeBSD cannot limit to C99 because its system headers unconditionally
29
# rely on C11 features.
30
endif
31

32
DEVELOPER_CFLAGS += -Wdeclaration-after-statement
33
DEVELOPER_CFLAGS += -Wformat-security
34
DEVELOPER_CFLAGS += -Wold-style-definition
35
DEVELOPER_CFLAGS += -Woverflow
36
DEVELOPER_CFLAGS += -Wpointer-arith
37
DEVELOPER_CFLAGS += -Wstrict-prototypes
38
DEVELOPER_CFLAGS += -Wunused
39
DEVELOPER_CFLAGS += -Wvla
40
DEVELOPER_CFLAGS += -Wwrite-strings
41
DEVELOPER_CFLAGS += -fno-common
42

43
ifneq ($(filter clang4,$(COMPILER_FEATURES)),)
44
DEVELOPER_CFLAGS += -Wtautological-constant-out-of-range-compare
45
endif
46

47
ifneq ($(or $(filter gcc6,$(COMPILER_FEATURES)),$(filter clang4,$(COMPILER_FEATURES))),)
48
DEVELOPER_CFLAGS += -Wextra
49
# if a function is public, there should be a prototype and the right
50
# header file should be included. If not, it should be static.
51
DEVELOPER_CFLAGS += -Wmissing-prototypes
52
ifeq ($(filter extra-all,$(DEVOPTS)),)
53
# These are disabled because we have these all over the place.
54
DEVELOPER_CFLAGS += -Wno-empty-body
55
DEVELOPER_CFLAGS += -Wno-missing-field-initializers
56
DEVELOPER_CFLAGS += -Wno-sign-compare
57
DEVELOPER_CFLAGS += -Wno-unused-parameter
58
endif
59
endif
60

61
# uninitialized warnings on gcc 4.9.2 in xdiff/xdiffi.c and config.c
62
# not worth fixing since newer compilers correctly stop complaining
63
#
64
# Likewise, gcc older than 4.9 complains about initializing a
65
# struct-within-a-struct using just "{ 0 }"
66
ifneq ($(filter gcc4,$(COMPILER_FEATURES)),)
67
ifeq ($(filter gcc5,$(COMPILER_FEATURES)),)
68
DEVELOPER_CFLAGS += -Wno-uninitialized
69
DEVELOPER_CFLAGS += -Wno-missing-braces
70
endif
71
endif
72

73
# Old versions of clang complain about initializaing a
74
# struct-within-a-struct using just "{0}" rather than "{{0}}".  This
75
# error is considered a false-positive and not worth fixing, because
76
# new clang versions do not, so just disable it.
77
#
78
# The "bug" was fixed in upstream clang 9.
79
#
80
# Complicating this is that versions of clang released by Apple have
81
# their own version numbers (associated with the corresponding version
82
# of XCode) unrelated to the official clang version numbers.
83
#
84
# The bug was fixed in Apple clang 12.
85
#
86
ifneq ($(filter clang1,$(COMPILER_FEATURES)),)     # if we are using clang
87
ifeq ($(uname_S),Darwin)                           # if we are on darwin
88
ifeq ($(filter clang12,$(COMPILER_FEATURES)),)     # if version < 12
89
DEVELOPER_CFLAGS += -Wno-missing-braces
90
endif
91
else                                               # not darwin
92
ifeq ($(filter clang9,$(COMPILER_FEATURES)),)      # if version < 9
93
DEVELOPER_CFLAGS += -Wno-missing-braces
94
endif
95
endif
96
endif
97

98
# https://bugzilla.redhat.com/show_bug.cgi?id=2075786
99
ifneq ($(filter gcc12,$(COMPILER_FEATURES)),)
100
DEVELOPER_CFLAGS += -Wno-error=stringop-overread
101
endif
102

103
GIT_TEST_PERL_FATAL_WARNINGS = YesPlease
104