drivers/net/dpaa/dpaa_ethdev.c - main - phprus/github_dpdk

drivers/net/dpaa/dpaa_ethdev.c
2 702 строки70 KB
Gagandeep Singh
net/dpaa: fix device remove
14 июл 2026, 13:18
14 июл 2026, 13:18c468b43
/* SPDX-License-Identifier: BSD-3-Clause
 *
 *   Copyright 2016 Freescale Semiconductor, Inc. All rights reserved.
 *   Copyright 2017-2020,2022-2025 NXP
 *
 */
/* System headers */
#include <stdio.h>
#include <inttypes.h>
#include <unistd.h>
#include <limits.h>
#include <sched.h>
#include <signal.h>
#include <pthread.h>
#include <sys/types.h>
#include <sys/syscall.h>
#include <sys/ioctl.h>

#include <eal_export.h>
#include <rte_string_fns.h>
#include <rte_byteorder.h>
#include <rte_common.h>
#include <rte_interrupts.h>
#include <rte_log.h>
#include <rte_debug.h>
#include <rte_pci.h>
#include <rte_atomic.h>
#include <rte_branch_prediction.h>
#include <rte_memory.h>
#include <rte_tailq.h>
#include <rte_eal.h>
#include <rte_alarm.h>
#include <rte_ether.h>
#include <rte_kvargs.h>
#include <ethdev_driver.h>
#include <rte_malloc.h>
#include <rte_ring.h>

#include <bus_dpaa_driver.h>
#include <rte_dpaa_logs.h>
#include <dpaa_mempool.h>

#include <dpaa_ethdev.h>
#include <dpaa_rxtx.h>
#include <dpaa_flow.h>
#include <rte_pmd_dpaa.h>

#include <fsl_usd.h>
#include <fsl_qman.h>
#include <fsl_bman.h>
#include <fsl_fman.h>
#include <process.h>
#include <fmlib/fm_ext.h>

#define CHECK_INTERVAL          100  /* 100ms */
#define MAX_REPEAT_TIME         90   /* 9s (90 * 100ms) in total */
#define DRIVER_RECV_ERR_PKTS      "recv_err_pkts"
#define RTE_PRIORITY_103 103

/* Supported Rx offloads */
static uint64_t dev_rx_offloads_sup =
		RTE_ETH_RX_OFFLOAD_SCATTER;

/* Rx offloads which cannot be disabled */
static uint64_t dev_rx_offloads_nodis =
		RTE_ETH_RX_OFFLOAD_IPV4_CKSUM |
		RTE_ETH_RX_OFFLOAD_UDP_CKSUM |
		RTE_ETH_RX_OFFLOAD_TCP_CKSUM |
		RTE_ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM |
		RTE_ETH_RX_OFFLOAD_RSS_HASH;

/* Supported Tx offloads */
static uint64_t dev_tx_offloads_sup =
		RTE_ETH_TX_OFFLOAD_MT_LOCKFREE |
		RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE;

/* Tx offloads which cannot be disabled */
static uint64_t dev_tx_offloads_nodis =
		RTE_ETH_TX_OFFLOAD_IPV4_CKSUM |
		RTE_ETH_TX_OFFLOAD_UDP_CKSUM |
		RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
		RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
		RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM |
		RTE_ETH_TX_OFFLOAD_MULTI_SEGS;

/* Keep track of whether QMAN and BMAN have been globally initialized */
static int is_global_init;
static int fmc_q = 1;	/* Indicates the use of static fmc for distribution */
static int default_q;	/* use default queue - FMC is not executed*/
bool dpaa_enable_recv_err_pkts; /* Enable main queue to receive error packets */

/* Per RX FQ Taildrop in frame count */
static unsigned int td_threshold = CGR_RX_PERFQ_THRESH;

/* Per TX FQ Taildrop in frame count, disabled by default */
static unsigned int td_tx_threshold;

struct rte_dpaa_xstats_name_off {
	char name[RTE_ETH_XSTATS_NAME_SIZE];
	uint32_t offset;
};

static const struct rte_dpaa_xstats_name_off dpaa_xstats_strings[] = {
	{"rx_align_err",
		offsetof(struct dpaa_if_stats, raln)},
	{"rx_valid_pause",
		offsetof(struct dpaa_if_stats, rxpf)},
	{"rx_fcs_err",
		offsetof(struct dpaa_if_stats, rfcs)},
	{"rx_vlan_frame",
		offsetof(struct dpaa_if_stats, rvlan)},
	{"rx_frame_err",
		offsetof(struct dpaa_if_stats, rerr)},
	{"rx_drop_err",
		offsetof(struct dpaa_if_stats, rdrp)},
	{"rx_undersized",
		offsetof(struct dpaa_if_stats, rund)},
	{"rx_oversize_err",
		offsetof(struct dpaa_if_stats, rovr)},
	{"rx_fragment_pkt",
		offsetof(struct dpaa_if_stats, rfrg)},
	{"tx_valid_pause",
		offsetof(struct dpaa_if_stats, txpf)},
	{"tx_fcs_err",
		offsetof(struct dpaa_if_stats, terr)},
	{"tx_vlan_frame",
		offsetof(struct dpaa_if_stats, tvlan)},
	{"tx_undersized",
		offsetof(struct dpaa_if_stats, tund)},
	{"rx_frame_counter",
		offsetof(struct dpaa_if_rx_bmi_stats, fmbm_rfrc)},
	{"rx_bad_frames_count",
		offsetof(struct dpaa_if_rx_bmi_stats, fmbm_rfbc)},
	{"rx_large_frames_count",
		offsetof(struct dpaa_if_rx_bmi_stats, fmbm_rlfc)},
	{"rx_filter_frames_count",
		offsetof(struct dpaa_if_rx_bmi_stats, fmbm_rffc)},
	{"rx_frame_discard_count",
		offsetof(struct dpaa_if_rx_bmi_stats, fmbm_rfdc)},
	{"rx_frame_list_dma_err_count",
		offsetof(struct dpaa_if_rx_bmi_stats, fmbm_rfldec)},
	{"rx_out_of_buffer_discard",
		offsetof(struct dpaa_if_rx_bmi_stats, fmbm_rodc)},
	{"rx_buf_deallocate",
		offsetof(struct dpaa_if_rx_bmi_stats, fmbm_rbdc)},
};

static struct rte_dpaa_driver rte_dpaa_pmd;
int dpaa_valid_dev;
struct rte_mempool *dpaa_tx_sg_pool;

static int
dpaa_eth_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info);

static int dpaa_eth_link_update(struct rte_eth_dev *dev,
				int wait_to_complete __rte_unused);

static void dpaa_interrupt_handler(void *param);

static inline void
dpaa_poll_queue_default_config(struct qm_mcc_initfq *opts)
{
	memset(opts, 0, sizeof(struct qm_mcc_initfq));
	opts->we_mask = QM_INITFQ_WE_FQCTRL | QM_INITFQ_WE_CONTEXTA;
	opts->fqd.fq_ctrl = QM_FQCTRL_AVOIDBLOCK | QM_FQCTRL_CTXASTASHING |
			   QM_FQCTRL_PREFERINCACHE;
	opts->fqd.context_a.stashing.exclusive = 0;
	if (dpaa_soc_ver() != SVR_LS1046A_FAMILY)
		opts->fqd.context_a.stashing.annotation_cl =
						DPAA_IF_RX_ANNOTATION_STASH;
	opts->fqd.context_a.stashing.data_cl = DPAA_IF_RX_DATA_STASH;
	opts->fqd.context_a.stashing.context_cl = DPAA_IF_RX_CONTEXT_STASH;
}

static int
dpaa_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
{
	uint32_t frame_size = mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN
				+ VLAN_TAG_SIZE;
	uint32_t buffsz = dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM;
	struct fman_if *fif = dev->process_private;

	PMD_INIT_FUNC_TRACE();

	if (fif->is_shared_mac) {
		DPAA_PMD_ERR("Cannot configure mtu from DPDK in VSP mode.");
		return -ENOTSUP;
	}

	/*
	 * Refuse mtu that requires the support of scattered packets
	 * when this feature has not been enabled before.
	 */
	if (dev->data->min_rx_buf_size &&
		!dev->data->scattered_rx && frame_size > buffsz) {
		DPAA_PMD_ERR("SG not enabled, will not fit in one buffer");
		return -EINVAL;
	}

	/* check <seg size> * <max_seg>  >= max_frame */
	if (dev->data->min_rx_buf_size && dev->data->scattered_rx &&
		(frame_size > buffsz * DPAA_SGT_MAX_ENTRIES)) {
		DPAA_PMD_ERR("Too big to fit for Max SG list %d",
				buffsz * DPAA_SGT_MAX_ENTRIES);
		return -EINVAL;
	}

	fman_if_set_maxfrm(dev->process_private, frame_size);

	return 0;
}

static int
dpaa_eth_dev_configure(struct rte_eth_dev *dev)
{
	struct rte_eth_conf *eth_conf = &dev->data->dev_conf;
	uint64_t rx_offloads = eth_conf->rxmode.offloads;
	uint64_t tx_offloads = eth_conf->txmode.offloads;
	struct dpaa_if *dpaa_intf = dev->data->dev_private;
	struct rte_eth_link *link = &dev->data->dev_link;
	struct rte_dpaa_device *dpaa_dev;
	struct fman_if *fif = dev->process_private;
	struct __fman_if *__fif;
	struct rte_intr_handle *intr_handle;
	uint32_t max_rx_pktlen;
	int speed, duplex;
	int ret, rx_status, socket_fd;
	struct ifreq ifr;

	PMD_INIT_FUNC_TRACE();

	dpaa_dev = RTE_CLASS_TO_BUS_DEVICE(dev, *dpaa_dev);
	intr_handle = dpaa_dev->intr_handle;
	__fif = container_of(fif, struct __fman_if, __if);

	/* Check if interface is enabled in case of shared MAC */
	if (fif->is_shared_mac) {
		rx_status = fman_if_get_rx_status(fif);
		if (!rx_status) {
			DPAA_PMD_ERR("%s Interface not enabled in kernel!",
				     dpaa_intf->name);
			return -EHOSTDOWN;
		}

		socket_fd = socket(AF_INET, SOCK_DGRAM, IPPROTO_IP);
		if (socket_fd == -1) {
			DPAA_PMD_ERR("Cannot open IF socket");
			return -errno;
		}
		strncpy(ifr.ifr_name, dpaa_intf->name, IFNAMSIZ - 1);

		if (ioctl(socket_fd, SIOCGIFMTU, &ifr) < 0) {
			DPAA_PMD_ERR("Cannot get interface mtu");
			close(socket_fd);
			return -errno;
		}

		close(socket_fd);
		DPAA_PMD_INFO("Using kernel configured mtu size(%u)",
			     ifr.ifr_mtu);

		eth_conf->rxmode.mtu = ifr.ifr_mtu;
	}

	/* Rx offloads which are enabled by default */
	if (dev_rx_offloads_nodis & ~rx_offloads) {
		DPAA_PMD_INFO(
		"Some of rx offloads enabled by default - requested 0x%" PRIx64
		" fixed are 0x%" PRIx64,
		rx_offloads, dev_rx_offloads_nodis);
	}

	/* Tx offloads which are enabled by default */
	if (dev_tx_offloads_nodis & ~tx_offloads) {
		DPAA_PMD_INFO(
		"Some of tx offloads enabled by default - requested 0x%" PRIx64
		" fixed are 0x%" PRIx64,
		tx_offloads, dev_tx_offloads_nodis);
	}

	max_rx_pktlen = eth_conf->rxmode.mtu + RTE_ETHER_HDR_LEN +
			RTE_ETHER_CRC_LEN + VLAN_TAG_SIZE;
	if (max_rx_pktlen > DPAA_MAX_RX_PKT_LEN) {
		DPAA_PMD_INFO("enabling jumbo override conf max len=%d "
			"supported is %d",
			max_rx_pktlen, DPAA_MAX_RX_PKT_LEN);
		max_rx_pktlen = DPAA_MAX_RX_PKT_LEN;
	}

	if (!fif->is_shared_mac && fif->mac_type != fman_offline_internal &&
	    fif->mac_type != fman_onic)
		fman_if_set_maxfrm(dev->process_private, max_rx_pktlen);

	if (rx_offloads & RTE_ETH_RX_OFFLOAD_SCATTER) {
		DPAA_PMD_DEBUG("enabling scatter mode");
		fman_if_set_sg(dev->process_private, 1);
		dev->data->scattered_rx = 1;
	}

	if (!(default_q || fmc_q)) {
		ret = dpaa_fm_config(dev,
			eth_conf->rx_adv_conf.rss_conf.rss_hf);
		if (ret) {
			dpaa_write_fm_config_to_file();
			DPAA_PMD_ERR("FM port configuration: Failed(%d)", ret);
			return ret;
		}
		dpaa_write_fm_config_to_file();
	}

	/* Disable interrupt support on offline port*/
	if (fif->mac_type == fman_offline_internal ||
	    fif->mac_type == fman_onic)
		return 0;

	/* if the interrupts were configured on this devices*/
	if (intr_handle && rte_intr_fd_get(intr_handle)) {
		if (dev->data->dev_conf.intr_conf.lsc != 0)
			rte_intr_callback_register(intr_handle,
					   dpaa_interrupt_handler,
					   (void *)dev);

		ret = dpaa_intr_enable(__fif->node_name,
				       rte_intr_fd_get(intr_handle));
		if (ret) {
			if (dev->data->dev_conf.intr_conf.lsc != 0) {
				rte_intr_callback_unregister(intr_handle,
					dpaa_interrupt_handler,
					(void *)dev);
				if (ret == EINVAL)
					DPAA_PMD_ERR("Failed to enable interrupt: Not Supported");
				else
					DPAA_PMD_ERR("Failed to enable interrupt");
			}
			dev->data->dev_conf.intr_conf.lsc = 0;
			dev->data->dev_flags &= ~RTE_ETH_DEV_INTR_LSC;
		}
	}

	/* Wait for link status to get updated */
	if (!link->link_status)
		sleep(1);

	/* Configure link only if link is UP*/
	if (link->link_status) {
		if (eth_conf->link_speeds == RTE_ETH_LINK_SPEED_AUTONEG) {
			/* Start autoneg only if link is not in autoneg mode */
			if (!link->link_autoneg)
				dpaa_restart_link_autoneg(__fif->node_name);
		} else if (eth_conf->link_speeds & RTE_ETH_LINK_SPEED_FIXED) {
			switch (eth_conf->link_speeds &  RTE_ETH_LINK_SPEED_FIXED) {
			case RTE_ETH_LINK_SPEED_10M_HD:
				speed = RTE_ETH_SPEED_NUM_10M;
				duplex = RTE_ETH_LINK_HALF_DUPLEX;
				break;
			case RTE_ETH_LINK_SPEED_10M:
				speed = RTE_ETH_SPEED_NUM_10M;
				duplex = RTE_ETH_LINK_FULL_DUPLEX;
				break;
			case RTE_ETH_LINK_SPEED_100M_HD:
				speed = RTE_ETH_SPEED_NUM_100M;
				duplex = RTE_ETH_LINK_HALF_DUPLEX;
				break;
			case RTE_ETH_LINK_SPEED_100M:
				speed = RTE_ETH_SPEED_NUM_100M;
				duplex = RTE_ETH_LINK_FULL_DUPLEX;
				break;
			case RTE_ETH_LINK_SPEED_1G:
				speed = RTE_ETH_SPEED_NUM_1G;
				duplex = RTE_ETH_LINK_FULL_DUPLEX;
				break;
			case RTE_ETH_LINK_SPEED_2_5G:
				speed = RTE_ETH_SPEED_NUM_2_5G;
				duplex = RTE_ETH_LINK_FULL_DUPLEX;
				break;
			case RTE_ETH_LINK_SPEED_10G:
				speed = RTE_ETH_SPEED_NUM_10G;
				duplex = RTE_ETH_LINK_FULL_DUPLEX;
				break;
			default:
				speed = RTE_ETH_SPEED_NUM_NONE;
				duplex = RTE_ETH_LINK_FULL_DUPLEX;
				break;
			}
			/* Set link speed */
			dpaa_update_link_speed(__fif->node_name, speed, duplex);
		} else {
			/* Manual autoneg - custom advertisement speed. */
			DPAA_PMD_ERR("Custom Advertisement speeds not supported");
		}
	}

	return 0;
}

static const uint32_t *
dpaa_supported_ptypes_get(struct rte_eth_dev *dev, size_t *no_of_elements)
{
	static const uint32_t ptypes[] = {
		RTE_PTYPE_L2_ETHER,
		RTE_PTYPE_L2_ETHER_VLAN,
		RTE_PTYPE_L2_ETHER_ARP,
		RTE_PTYPE_L3_IPV4_EXT_UNKNOWN,
		RTE_PTYPE_L3_IPV6_EXT_UNKNOWN,
		RTE_PTYPE_L4_ICMP,
		RTE_PTYPE_L4_TCP,
		RTE_PTYPE_L4_UDP,
		RTE_PTYPE_L4_FRAG,
		RTE_PTYPE_L4_SCTP,
		RTE_PTYPE_TUNNEL_ESP,
		RTE_PTYPE_TUNNEL_GRE,
	};

	PMD_INIT_FUNC_TRACE();

	if (dev->rx_pkt_burst == dpaa_eth_queue_rx) {
		*no_of_elements = RTE_DIM(ptypes);
		return ptypes;
	}
	return NULL;
}

static void dpaa_interrupt_handler(void *param)
{
	struct rte_eth_dev *dev = param;
	struct rte_dpaa_device *dpaa_dev;
	struct rte_intr_handle *intr_handle;
	uint64_t buf;
	int bytes_read;

	dpaa_dev = RTE_CLASS_TO_BUS_DEVICE(dev, *dpaa_dev);
	intr_handle = dpaa_dev->intr_handle;

	if (rte_intr_fd_get(intr_handle) < 0)
		return;

	bytes_read = read(rte_intr_fd_get(intr_handle), &buf,
			  sizeof(uint64_t));
	if (bytes_read < 0)
		DPAA_PMD_ERR("Error reading eventfd");
	dpaa_eth_link_update(dev, 0);
	rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL);
}

static int dpaa_eth_dev_start(struct rte_eth_dev *dev)
{
	struct dpaa_if *dpaa_intf = dev->data->dev_private;
	struct fman_if *fif = dev->process_private;
	uint16_t i;

	PMD_INIT_FUNC_TRACE();

	if (!(default_q || fmc_q))
		dpaa_write_fm_config_to_file();

	/* Change tx callback to the real one */
	if (dpaa_intf->cgr_tx)
		dev->tx_pkt_burst = dpaa_eth_queue_tx_slow;
	else
		dev->tx_pkt_burst = dpaa_eth_queue_tx;

	if (fif->mac_type != fman_onic) {
		fman_if_bmi_stats_enable(fif);
		fman_if_bmi_stats_reset(fif);
		fman_if_enable_rx(fif);
	}
	for (i = 0; i < dev->data->nb_rx_queues; i++)
		dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;
	for (i = 0; i < dev->data->nb_tx_queues; i++)
		dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;

	return 0;
}

static int dpaa_eth_dev_stop(struct rte_eth_dev *dev)
{
	struct fman_if *fif = dev->process_private;
	uint16_t i;

	PMD_INIT_FUNC_TRACE();
	dev->data->dev_started = 0;

	if (!fif->is_shared_mac) {
		fman_if_bmi_stats_disable(fif);
		fman_if_disable_rx(fif);
	}
	dev->tx_pkt_burst = dpaa_eth_tx_drop_all;

	for (i = 0; i < dev->data->nb_rx_queues; i++)
		dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;
	for (i = 0; i < dev->data->nb_tx_queues; i++)
		dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;

	return 0;
}

static int dpaa_eth_dev_close(struct rte_eth_dev *dev)
{
	struct fman_if *fif = dev->process_private;
	struct __fman_if *__fif;
	struct rte_dpaa_device *dpaa_dev;
	struct rte_intr_handle *intr_handle;
	struct rte_eth_link *link = &dev->data->dev_link;
	struct dpaa_if *dpaa_intf = dev->data->dev_private;
	struct qman_fq *fq;
	int loop;
	int ret;

	PMD_INIT_FUNC_TRACE();

	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
		return 0;

	if (!dpaa_intf) {
		DPAA_PMD_DEBUG("Already closed or not started");
		return -ENOENT;
	}

	/* DPAA FM deconfig */
	if (!(default_q || fmc_q)) {
		ret = dpaa_fm_deconfig(dpaa_intf, dev->process_private);
		if (ret) {
			DPAA_PMD_WARN("%s: FM deconfig failed(%d)",
				dev->data->name, ret);
		}
	}

	dpaa_dev = RTE_CLASS_TO_BUS_DEVICE(dev, *dpaa_dev);
	intr_handle = dpaa_dev->intr_handle;
	__fif = container_of(fif, struct __fman_if, __if);

	ret = dpaa_eth_dev_stop(dev);
	if (ret) {
		DPAA_PMD_WARN("%s: stop device failed(%d)",
			dev->data->name, ret);
	}

	if (fif->mac_type == fman_offline_internal ||
	    fif->mac_type == fman_onic)
		return 0;

	/* Reset link to autoneg */
	if (link->link_status && !link->link_autoneg) {
		ret = dpaa_restart_link_autoneg(__fif->node_name);
		if (ret) {
			DPAA_PMD_WARN("%s: restart link failed(%d)",
				dev->data->name, ret);
		}
	}

	if (intr_handle && rte_intr_fd_get(intr_handle) &&
	    dev->data->dev_conf.intr_conf.lsc != 0) {
		ret = dpaa_intr_disable(__fif->node_name);
		if (ret) {
			DPAA_PMD_WARN("%s: disable interrupt failed(%d)",
				dev->data->name, ret);
		}
		ret = rte_intr_callback_unregister(intr_handle,
			dpaa_interrupt_handler, (void *)dev);
		if (ret < 0) {
			DPAA_PMD_WARN("%s: unregister interrupt failed(%d)",
				dev->data->name, ret);
		}
	}

	/* release configuration memory */
	rte_free(dpaa_intf->fc_conf);

	/* Release RX congestion Groups */
	if (dpaa_intf->cgr_rx) {
		for (loop = 0; loop < dpaa_intf->nb_rx_queues; loop++) {
			ret = qman_delete_cgr(&dpaa_intf->cgr_rx[loop]);
			if (ret) {
				DPAA_PMD_WARN("%s: delete rxq%d's cgr err(%d)",
					dev->data->name, loop, ret);
			}
		}
		rte_free(dpaa_intf->cgr_rx);
		dpaa_intf->cgr_rx = NULL;
	}

	/* Release TX congestion Groups */
	if (dpaa_intf->cgr_tx) {
		for (loop = 0; loop < MAX_DPAA_CORES; loop++) {
			ret = qman_delete_cgr(&dpaa_intf->cgr_tx[loop]);
			if (ret) {
				DPAA_PMD_WARN("%s: delete txq%d's cgr err(%d)",
					dev->data->name, loop, ret);
			}
		}
		rte_free(dpaa_intf->cgr_tx);
		dpaa_intf->cgr_tx = NULL;
	}

	/* Freeing queue specific portals */
	for (loop = 0; loop < dpaa_intf->nb_rx_queues; loop++) {
		if (!dpaa_intf->rx_queues)
			break;

		fq = &dpaa_intf->rx_queues[loop];
		if (fq->qp_initialized) {
			rte_dpaa_portal_fq_close(fq);
			fq->qp_initialized = 0;
		}
	}

	rte_free(dpaa_intf->rx_queues);
	dpaa_intf->rx_queues = NULL;

	rte_free(dpaa_intf->tx_queues);
	dpaa_intf->tx_queues = NULL;
	if (dpaa_intf->port_handle) {
		ret = dpaa_fm_deconfig(dpaa_intf, fif);
		if (ret) {
			DPAA_PMD_WARN("%s: FM deconfig failed(%d)",
				dev->data->name, ret);
		}
	}
	if (fif->num_profiles) {
		ret = dpaa_port_vsp_cleanup(dpaa_intf, fif);
		if (ret) {
			DPAA_PMD_WARN("%s: cleanup VSP failed(%d)",
				dev->data->name, ret);
		}
	}

	return ret;
}

static int
dpaa_fw_version_get(struct rte_eth_dev *dev,
	char *fw_version, size_t fw_size)
{
	struct fman_if *fif = dev->process_private;
	int ret;

	PMD_INIT_FUNC_TRACE();

	ret = snprintf(fw_version, fw_size, "SVR:%x-fman-v%x",
			dpaa_soc_ver(), fif->fman->ip_rev);
	if (ret < 0)
		return -EINVAL;

	ret += 1; /* add the size of '\0' */
	if (fw_size < (size_t)ret)
		return ret;
	else
		return 0;
}

static int dpaa_eth_dev_info(struct rte_eth_dev *dev,
			     struct rte_eth_dev_info *dev_info)
{
	struct dpaa_if *dpaa_intf = dev->data->dev_private;
	struct fman_if *fif = dev->process_private;

	DPAA_PMD_DEBUG(": %s", dpaa_intf->name);

	dev_info->max_rx_queues = dpaa_intf->nb_rx_queues;
	dev_info->max_tx_queues = dpaa_intf->nb_tx_queues;
	dev_info->max_rx_pktlen = DPAA_MAX_RX_PKT_LEN;
	dev_info->max_mac_addrs = DPAA_MAX_MAC_FILTER;
	dev_info->max_hash_mac_addrs = 0;
	dev_info->max_vfs = 0;
	dev_info->max_vmdq_pools = RTE_ETH_16_POOLS;
	dev_info->flow_type_rss_offloads = DPAA_RSS_OFFLOAD_ALL;

	if (fif->mac_type == fman_mac_1g) {
		dev_info->speed_capa = RTE_ETH_LINK_SPEED_10M_HD
					| RTE_ETH_LINK_SPEED_10M
					| RTE_ETH_LINK_SPEED_100M_HD
					| RTE_ETH_LINK_SPEED_100M
					| RTE_ETH_LINK_SPEED_1G;
	} else if (fif->mac_type == fman_mac_2_5g) {
		dev_info->speed_capa = RTE_ETH_LINK_SPEED_10M_HD
					| RTE_ETH_LINK_SPEED_10M
					| RTE_ETH_LINK_SPEED_100M_HD
					| RTE_ETH_LINK_SPEED_100M
					| RTE_ETH_LINK_SPEED_1G
					| RTE_ETH_LINK_SPEED_2_5G;
	} else if (fif->mac_type == fman_mac_10g) {
		dev_info->speed_capa = RTE_ETH_LINK_SPEED_10M_HD
					| RTE_ETH_LINK_SPEED_10M
					| RTE_ETH_LINK_SPEED_100M_HD
					| RTE_ETH_LINK_SPEED_100M
					| RTE_ETH_LINK_SPEED_1G
					| RTE_ETH_LINK_SPEED_2_5G
					| RTE_ETH_LINK_SPEED_10G;
	} else if (fif->mac_type == fman_offline_internal ||
		   fif->mac_type == fman_onic) {
		dev_info->speed_capa = RTE_ETH_LINK_SPEED_10M_HD
					| RTE_ETH_LINK_SPEED_10M
					| RTE_ETH_LINK_SPEED_100M_HD
					| RTE_ETH_LINK_SPEED_100M
					| RTE_ETH_LINK_SPEED_1G
					| RTE_ETH_LINK_SPEED_2_5G;
	} else {
		DPAA_PMD_ERR("invalid link_speed: %s, %d",
			     dpaa_intf->name, fif->mac_type);
		return -EINVAL;
	}

	dev_info->rx_offload_capa = dev_rx_offloads_sup |
					dev_rx_offloads_nodis;
	dev_info->tx_offload_capa = dev_tx_offloads_sup |
					dev_tx_offloads_nodis;
	dev_info->default_rxportconf.burst_size = DPAA_DEF_RX_BURST_SIZE;
	dev_info->default_txportconf.burst_size = DPAA_DEF_TX_BURST_SIZE;
	dev_info->default_rxportconf.nb_queues = 1;
	dev_info->default_txportconf.nb_queues = 1;
	dev_info->default_txportconf.ring_size = CGR_TX_CGR_THRESH;
	dev_info->default_rxportconf.ring_size = CGR_RX_PERFQ_THRESH;

	return 0;
}

static int
dpaa_dev_rx_burst_mode_get(struct rte_eth_dev *dev,
			__rte_unused uint16_t queue_id,
			struct rte_eth_burst_mode *mode)
{
	struct rte_eth_conf *eth_conf = &dev->data->dev_conf;
	int ret = -EINVAL;
	unsigned int i;
	const struct burst_info {
		uint64_t flags;
		const char *output;
	} rx_offload_map[] = {
			{RTE_ETH_RX_OFFLOAD_SCATTER, " Scattered,"},
			{RTE_ETH_RX_OFFLOAD_IPV4_CKSUM, " IPV4 csum,"},
			{RTE_ETH_RX_OFFLOAD_UDP_CKSUM, " UDP csum,"},
			{RTE_ETH_RX_OFFLOAD_TCP_CKSUM, " TCP csum,"},
			{RTE_ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM, " Outer IPV4 csum,"},
			{RTE_ETH_RX_OFFLOAD_RSS_HASH, " RSS,"}
	};

	/* Update Rx offload info */
	for (i = 0; i < RTE_DIM(rx_offload_map); i++) {
		if (eth_conf->rxmode.offloads & rx_offload_map[i].flags) {
			snprintf(mode->info, sizeof(mode->info), "%s",
				rx_offload_map[i].output);
			ret = 0;
			break;
		}
	}
	return ret;
}

static int
dpaa_dev_tx_burst_mode_get(struct rte_eth_dev *dev,
			__rte_unused uint16_t queue_id,
			struct rte_eth_burst_mode *mode)
{
	struct rte_eth_conf *eth_conf = &dev->data->dev_conf;
	int ret = -EINVAL;
	unsigned int i;
	const struct burst_info {
		uint64_t flags;
		const char *output;
	} tx_offload_map[] = {
			{RTE_ETH_TX_OFFLOAD_MT_LOCKFREE, " MT lockfree,"},
			{RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE, " MBUF free disable,"},
			{RTE_ETH_TX_OFFLOAD_IPV4_CKSUM, " IPV4 csum,"},
			{RTE_ETH_TX_OFFLOAD_UDP_CKSUM, " UDP csum,"},
			{RTE_ETH_TX_OFFLOAD_TCP_CKSUM, " TCP csum,"},
			{RTE_ETH_TX_OFFLOAD_SCTP_CKSUM, " SCTP csum,"},
			{RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM, " Outer IPV4 csum,"},
			{RTE_ETH_TX_OFFLOAD_MULTI_SEGS, " Scattered,"}
	};

	/* Update Tx offload info */
	for (i = 0; i < RTE_DIM(tx_offload_map); i++) {
		if (eth_conf->txmode.offloads & tx_offload_map[i].flags) {
			snprintf(mode->info, sizeof(mode->info), "%s",
				tx_offload_map[i].output);
			ret = 0;
			break;
		}
	}
	return ret;
}

static int dpaa_eth_link_update(struct rte_eth_dev *dev,
				int wait_to_complete)
{
	struct dpaa_if *dpaa_intf = dev->data->dev_private;
	struct rte_eth_link *link = &dev->data->dev_link;
	struct fman_if *fif = dev->process_private;
	struct __fman_if *__fif = container_of(fif, struct __fman_if, __if);
	int ret, ioctl_version;
	uint8_t count;

	PMD_INIT_FUNC_TRACE();

	ioctl_version = dpaa_get_ioctl_version_number();

	if (dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC &&
	    fif->mac_type != fman_offline_internal &&
	    fif->mac_type != fman_onic) {
		for (count = 0; count <= MAX_REPEAT_TIME; count++) {
			ret = dpaa_get_link_status(__fif->node_name, link);
			if (ret)
				return ret;
			if (link->link_status == RTE_ETH_LINK_DOWN &&
			    wait_to_complete)
				rte_delay_ms(CHECK_INTERVAL);
			else
				break;
		}
	} else {
		link->link_status = dpaa_intf->valid;
		if (fif->mac_type == fman_offline_internal ||
		    fif->mac_type == fman_onic) {
			/*Max supported rate for O/H port is 3.75Mpps*/
			link->link_speed = RTE_ETH_SPEED_NUM_2_5G;
			link->link_duplex = RTE_ETH_LINK_FULL_DUPLEX;
		}
	}

	if (ioctl_version < 2) {
		link->link_duplex = RTE_ETH_LINK_FULL_DUPLEX;
		link->link_autoneg = RTE_ETH_LINK_AUTONEG;

		if (fif->mac_type == fman_mac_1g)
			link->link_speed = RTE_ETH_SPEED_NUM_1G;
		else if (fif->mac_type == fman_mac_2_5g)
			link->link_speed = RTE_ETH_SPEED_NUM_2_5G;
		else if (fif->mac_type == fman_mac_10g)
			link->link_speed = RTE_ETH_SPEED_NUM_10G;
		else
			DPAA_PMD_ERR("invalid link_speed: %s, %d",
				     dpaa_intf->name, fif->mac_type);
	}

	DPAA_PMD_INFO("Port %d Link is %s", dev->data->port_id,
		      link->link_status ? "Up" : "Down");
	return 0;
}

static int dpaa_eth_stats_get(struct rte_eth_dev *dev,
			       struct rte_eth_stats *stats,
			       struct eth_queue_stats *qstats __rte_unused)
{
	PMD_INIT_FUNC_TRACE();

	fman_if_stats_get(dev->process_private, stats);
	return 0;
}

static int dpaa_eth_stats_reset(struct rte_eth_dev *dev)
{
	PMD_INIT_FUNC_TRACE();

	fman_if_stats_reset(dev->process_private);
	fman_if_bmi_stats_reset(dev->process_private);

	return 0;
}

static int
dpaa_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,
		    unsigned int n)
{
	unsigned int i = 0, j, num = RTE_DIM(dpaa_xstats_strings);
	uint64_t values[sizeof(struct dpaa_if_stats) / 8];
	unsigned int bmi_count = sizeof(struct dpaa_if_rx_bmi_stats) / 4;

	if (n < num)
		return num;

	if (xstats == NULL)
		return 0;

	fman_if_stats_get_all(dev->process_private, values,
			      sizeof(struct dpaa_if_stats) / 8);

	for (i = 0; i < num - (bmi_count - 1); i++) {
		xstats[i].id = i;
		xstats[i].value = values[dpaa_xstats_strings[i].offset / 8];
	}
	fman_if_bmi_stats_get_all(dev->process_private, values);
	for (j = 0; i < num; i++, j++) {
		xstats[i].id = i;
		xstats[i].value = values[j];
	}

	return i;
}

static int
dpaa_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
		      struct rte_eth_xstat_name *xstats_names,
		      unsigned int limit)
{
	unsigned int i, stat_cnt = RTE_DIM(dpaa_xstats_strings);

	if (limit < stat_cnt)
		return stat_cnt;

	if (xstats_names != NULL)
		for (i = 0; i < stat_cnt; i++)
			strlcpy(xstats_names[i].name,
				dpaa_xstats_strings[i].name,
				sizeof(xstats_names[i].name));

	return stat_cnt;
}

static int
dpaa_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids,
		      uint64_t *values, unsigned int n)
{
	unsigned int i, j, stat_cnt = RTE_DIM(dpaa_xstats_strings);
	uint64_t values_copy[sizeof(struct dpaa_if_stats) / 8];
	unsigned int bmi_count = sizeof(struct dpaa_if_rx_bmi_stats) / 4;

	if (!ids) {
		if (n < stat_cnt)
			return stat_cnt;

		if (!values)
			return 0;

		fman_if_stats_get_all(dev->process_private, values_copy,
				      sizeof(struct dpaa_if_stats) / 8);

		for (i = 0; i < stat_cnt - (bmi_count - 1); i++)
			values[i] =
				values_copy[dpaa_xstats_strings[i].offset / 8];

		/* i continues from previous loop; BMI stats fill values[i..stat_cnt-1] */
		fman_if_bmi_stats_get_all(dev->process_private, values_copy);
		for (j = 0; i < stat_cnt; i++, j++)
			values[i] = values_copy[j];

		return stat_cnt;
	}

	dpaa_xstats_get_by_id(dev, NULL, values_copy, stat_cnt);

	for (i = 0; i < n; i++) {
		if (ids[i] >= stat_cnt) {
			DPAA_PMD_ERR("id value isn't valid");
			return -1;
		}
		values[i] = values_copy[ids[i]];
	}
	return n;
}

static int
dpaa_xstats_get_names_by_id(
	struct rte_eth_dev *dev,
	const uint64_t *ids,
	struct rte_eth_xstat_name *xstats_names,
	unsigned int limit)
{
	unsigned int i, stat_cnt = RTE_DIM(dpaa_xstats_strings);
	struct rte_eth_xstat_name xstats_names_copy[stat_cnt];

	if (!ids)
		return dpaa_xstats_get_names(dev, xstats_names, limit);

	dpaa_xstats_get_names(dev, xstats_names_copy, limit);

	for (i = 0; i < limit; i++) {
		if (ids[i] >= stat_cnt) {
			DPAA_PMD_ERR("id value isn't valid");
			return -1;
		}
		strcpy(xstats_names[i].name, xstats_names_copy[ids[i]].name);
	}
	return limit;
}

static int dpaa_eth_promiscuous_enable(struct rte_eth_dev *dev)
{
	struct fman_if *fif = dev->process_private;

	PMD_INIT_FUNC_TRACE();

	if (fif->mac_type == fman_onic) {
		DPAA_PMD_INFO("Enable promiscuous mode not supported on ONIC "
			      "port");
		return 0;
	}

	fman_if_promiscuous_enable(dev->process_private);

	return 0;
}

static int dpaa_eth_promiscuous_disable(struct rte_eth_dev *dev)
{
	struct fman_if *fif = dev->process_private;

	PMD_INIT_FUNC_TRACE();

	if (fif->mac_type == fman_onic) {
		DPAA_PMD_INFO("Disable promiscuous mode not supported on ONIC "
			      "port");
		return 0;
	}

	fman_if_promiscuous_disable(dev->process_private);

	return 0;
}

static int dpaa_eth_multicast_enable(struct rte_eth_dev *dev)
{
	struct fman_if *fif = dev->process_private;

	PMD_INIT_FUNC_TRACE();

	if (fif->mac_type == fman_onic) {
		DPAA_PMD_INFO("Enable Multicast not supported on ONIC port");
		return 0;
	}

	fman_if_set_mcast_filter_table(dev->process_private);

	return 0;
}

static int dpaa_eth_multicast_disable(struct rte_eth_dev *dev)
{
	struct fman_if *fif = dev->process_private;

	PMD_INIT_FUNC_TRACE();

	if (fif->mac_type == fman_onic) {
		DPAA_PMD_INFO("Disable Multicast not supported on ONIC port");
		return 0;
	}

	fman_if_reset_mcast_filter_table(dev->process_private);

	return 0;
}

static void dpaa_fman_if_pool_setup(struct rte_eth_dev *dev)
{
	struct dpaa_if *dpaa_intf = dev->data->dev_private;
	struct fman_if_ic_params icp;
	uint32_t fd_offset;
	uint32_t bp_size;

	memset(&icp, 0, sizeof(icp));
	/* set ICEOF for to the default value , which is 0*/
	icp.iciof = DEFAULT_ICIOF;
	icp.iceof = DEFAULT_RX_ICEOF;
	icp.icsz = DEFAULT_ICSZ;
	fman_if_set_ic_params(dev->process_private, &icp);

	fd_offset = RTE_PKTMBUF_HEADROOM + DPAA_HW_BUF_RESERVE;
	fman_if_set_fdoff(dev->process_private, fd_offset);

	/* Buffer pool size should be equal to Dataroom Size*/
	bp_size = rte_pktmbuf_data_room_size(dpaa_intf->bp_info->mp);

	fman_if_set_bp(dev->process_private,
		       dpaa_intf->bp_info->mp->size,
		       dpaa_intf->bp_info->bpid, bp_size);
}

static inline int dpaa_eth_rx_queue_bp_check(struct rte_eth_dev *dev,
					     int8_t vsp_id, uint32_t bpid)
{
	struct dpaa_if *dpaa_intf = dev->data->dev_private;
	struct fman_if *fif = dev->process_private;

	if (fif->num_profiles) {
		if (vsp_id < 0)
			vsp_id = fif->base_profile_id;
	} else {
		if (vsp_id < 0)
			vsp_id = 0;
	}

	if (dpaa_intf->vsp_bpid[vsp_id] &&
		bpid != dpaa_intf->vsp_bpid[vsp_id]) {
		DPAA_PMD_ERR("Various MPs are assigned to RXQs with same VSP");

		return -1;
	}

	return 0;
}

static
int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,
			    uint16_t nb_desc,
			    unsigned int socket_id __rte_unused,
			    const struct rte_eth_rxconf *rx_conf,
			    struct rte_mempool *mp)
{
	struct dpaa_if *dpaa_intf = dev->data->dev_private;
	struct fman_if *fif = dev->process_private;
	struct qman_fq *rxq = &dpaa_intf->rx_queues[queue_idx];
	struct qm_mcc_initfq opts = {0};
	u32 ch_id, flags = 0;
	int ret, set_push_rxq = false;
	u32 buffsz = rte_pktmbuf_data_room_size(mp) - RTE_PKTMBUF_HEADROOM;
	uint32_t max_rx_pktlen;

	PMD_INIT_FUNC_TRACE();

	if (queue_idx >= dev->data->nb_rx_queues) {
		rte_errno = EOVERFLOW;
		DPAA_PMD_ERR("%p: queue index out of range (%u >= %u)",
		      (void *)dev, queue_idx, dev->data->nb_rx_queues);
		return -rte_errno;
	}

	rxq->nb_desc = UINT16_MAX;
	rxq->offloads = rx_conf->offloads;

	DPAA_PMD_INFO("Rx queue setup for queue index: %d fq_id (0x%x)",
			queue_idx, rxq->fqid);

	/* Shutdown FQ before configure */
	qman_shutdown_fq(rxq->fqid);

	if (!fif->num_profiles) {
		if (dpaa_intf->bp_info && dpaa_intf->bp_info->bp &&
			dpaa_intf->bp_info->mp != mp) {
			DPAA_PMD_WARN("Multiple pools on same interface not"
				      " supported");
			return -EINVAL;
		}
	} else {
		if (dpaa_eth_rx_queue_bp_check(dev, rxq->vsp_id,
			DPAA_MEMPOOL_TO_POOL_INFO(mp)->bpid)) {
			return -EINVAL;
		}
	}

	if (dpaa_intf->bp_info && dpaa_intf->bp_info->bp &&
	    dpaa_intf->bp_info->mp != mp) {
		DPAA_PMD_WARN("Multiple pools on same interface not supported");
		return -EINVAL;
	}

	max_rx_pktlen = dev->data->mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN +
		VLAN_TAG_SIZE;
	/* Max packet can fit in single buffer */
	if (max_rx_pktlen <= buffsz) {
		;
	} else if (dev->data->dev_conf.rxmode.offloads &
			RTE_ETH_RX_OFFLOAD_SCATTER) {
		if (max_rx_pktlen > buffsz * DPAA_SGT_MAX_ENTRIES) {
			DPAA_PMD_ERR("Maximum Rx packet size %d too big to fit "
				"MaxSGlist %d",
				max_rx_pktlen, buffsz * DPAA_SGT_MAX_ENTRIES);
			rte_errno = EOVERFLOW;
			return -rte_errno;
		}
	} else {
		DPAA_PMD_WARN("The requested maximum Rx packet size (%u) is"
		     " larger than a single mbuf (%u) and scattered"
		     " mode has not been requested", max_rx_pktlen, buffsz);
	}

	dpaa_intf->bp_info = DPAA_MEMPOOL_TO_POOL_INFO(mp);

	/* For shared interface, it's done in kernel, skip.*/
	if (!fif->is_shared_mac && fif->mac_type != fman_offline_internal &&
	    fif->mac_type != fman_onic)
		dpaa_fman_if_pool_setup(dev);

	if (fif->num_profiles) {
		int8_t vsp_id = rxq->vsp_id;

		if (vsp_id >= 0) {
			ret = dpaa_port_vsp_update(dpaa_intf, fmc_q, vsp_id,
					DPAA_MEMPOOL_TO_POOL_INFO(mp)->bpid,
					fif, buffsz + RTE_PKTMBUF_HEADROOM);
			if (ret) {
				DPAA_PMD_ERR("dpaa_port_vsp_update failed");
				return ret;
			}
		} else {
			DPAA_PMD_INFO("Base profile is associated to"
				" RXQ fqid:%d", rxq->fqid);
			if (fif->is_shared_mac) {
				DPAA_PMD_ERR("Fatal: Base profile is associated"
					     " to shared interface on DPDK.");
				return -EINVAL;
			}
			dpaa_intf->vsp_bpid[fif->base_profile_id] =
				DPAA_MEMPOOL_TO_POOL_INFO(mp)->bpid;
		}
	} else {
		dpaa_intf->vsp_bpid[0] =
			DPAA_MEMPOOL_TO_POOL_INFO(mp)->bpid;
	}

	dpaa_intf->valid = 1;
	if (fif->mac_type != fman_onic)
		DPAA_PMD_DEBUG("if:%s sg_on = %d, max_frm =%d", dpaa_intf->name,
			       fman_if_get_sg_enable(fif), max_rx_pktlen);
	/* checking if push mode only, no error check for now */
	if (!rxq->is_static)
		set_push_rxq = dpaa_push_queue_num_update();
	if (set_push_rxq) {
		struct qman_portal *qp;
		int q_fd;

		opts.we_mask = QM_INITFQ_WE_FQCTRL | QM_INITFQ_WE_CONTEXTA;
		opts.fqd.fq_ctrl = QM_FQCTRL_AVOIDBLOCK |
				   QM_FQCTRL_CTXASTASHING |
				   QM_FQCTRL_PREFERINCACHE;
		opts.fqd.context_a.stashing.exclusive = 0;
		/* In multicore scenario stashing becomes a bottleneck on LS1046.
		 * So do not enable stashing in this case
		 */
		if (dpaa_soc_ver() != SVR_LS1046A_FAMILY)
			opts.fqd.context_a.stashing.annotation_cl =
						DPAA_IF_RX_ANNOTATION_STASH;
		opts.fqd.context_a.stashing.data_cl = DPAA_IF_RX_DATA_STASH;
		opts.fqd.context_a.stashing.context_cl =
						DPAA_IF_RX_CONTEXT_STASH;

		/*Create a channel and associate given queue with the channel*/
		qman_alloc_pool_range(&ch_id, 1, 1, 0);
		rxq->ch_id = (u16)ch_id;

		opts.we_mask = opts.we_mask | QM_INITFQ_WE_DESTWQ;
		opts.fqd.dest.channel = rxq->ch_id;
		opts.fqd.dest.wq = DPAA_IF_RX_PRIORITY;
		flags = QMAN_INITFQ_FLAG_SCHED;

		/* Configure tail drop */
		if (dpaa_intf->cgr_rx) {
			opts.we_mask |= QM_INITFQ_WE_CGID;
			opts.fqd.cgid = dpaa_intf->cgr_rx[queue_idx].cgrid;
			opts.fqd.fq_ctrl |= QM_FQCTRL_CGE;
		}
		ret = qman_init_fq(rxq, flags, &opts);
		if (ret) {
			DPAA_PMD_ERR("Channel/Q association failed. fqid 0x%x "
				"ret:%d(%s)", rxq->fqid, ret, strerror(ret));
			return ret;
		}
		if (dpaa_soc_ver() == SVR_LS1043A_FAMILY) {
			rxq->cb.dqrr_dpdk_pull_cb = dpaa_rx_cb_no_prefetch;
		} else {
			rxq->cb.dqrr_dpdk_pull_cb = dpaa_rx_cb;
			rxq->cb.dqrr_prepare = dpaa_rx_cb_prepare;
		}

		rxq->is_static = true;

		/* Allocate qman specific portals */
		qp = fsl_qman_fq_portal_create(&q_fd);
		if (!qp) {
			DPAA_PMD_ERR("Unable to alloc fq portal");
			return -EIO;
		}
		rxq->qp = qp;

		/* Set up the device interrupt handler */
		if (dev->intr_handle == NULL) {
			struct rte_dpaa_device *dpaa_dev;

			dpaa_dev = RTE_CLASS_TO_BUS_DEVICE(dev, *dpaa_dev);
			dev->intr_handle = dpaa_dev->intr_handle;
			if (rte_intr_vec_list_alloc(dev->intr_handle,
					NULL, dpaa_push_queue_max_num())) {
				DPAA_PMD_ERR("intr_vec alloc failed");
				return -ENOMEM;
			}
			if (rte_intr_nb_efd_set(dev->intr_handle,
					dpaa_push_queue_max_num()))
				return -rte_errno;

			if (rte_intr_max_intr_set(dev->intr_handle,
					dpaa_push_queue_max_num()))
				return -rte_errno;
		}

		if (rte_intr_type_set(dev->intr_handle, RTE_INTR_HANDLE_EXT))
			return -rte_errno;

		if (rte_intr_vec_list_index_set(dev->intr_handle,
						queue_idx, queue_idx + 1))
			return -rte_errno;

		if (rte_intr_efds_index_set(dev->intr_handle, queue_idx,
						   q_fd))
			return -rte_errno;

		rxq->q_fd = q_fd;
	}
	rxq->bp_array = rte_dpaa_bpid_info;
	dev->data->rx_queues[queue_idx] = rxq;

	/* configure the CGR size as per the desc size */
	if (dpaa_intf->cgr_rx) {
		struct qm_mcc_initcgr cgr_opts = {0};

		rxq->nb_desc = nb_desc;
		/* Enable tail drop with cgr on this queue */
		qm_cgr_cs_thres_set64(&cgr_opts.cgr.cs_thres, nb_desc, 0);
		ret = qman_modify_cgr(&dpaa_intf->cgr_rx[queue_idx], 0, &cgr_opts);
		if (ret) {
			DPAA_PMD_WARN(
				"rx taildrop modify fail on fqid %d (ret=%d)",
				rxq->fqid, ret);
		}
	}

	/* Enable main queue to receive error packets */
	if (fif->mac_type != fman_offline_internal &&
			fif->mac_type != fman_onic &&
			dpaa_enable_recv_err_pkts && !fif->is_shared_mac) {
		fman_if_set_err_fqid(fif, rxq->fqid);
	}

	return 0;
}

RTE_EXPORT_INTERNAL_SYMBOL(dpaa_eth_eventq_attach)
int
dpaa_eth_eventq_attach(const struct rte_eth_dev *dev,
	int eth_rx_queue_id, u16 ch_id,
	const struct rte_event_eth_rx_adapter_queue_conf *queue_conf)
{
	int ret;
	u32 flags = 0;
	struct dpaa_if *dpaa_intf = dev->data->dev_private;
	struct qman_fq *rxq = &dpaa_intf->rx_queues[eth_rx_queue_id];
	struct qm_mcc_initfq opts = {0};

	if (dpaa_push_queue_max_num() > 0) {
		DPAA_PMD_WARN("PUSH mode q and EVENTDEV are not compatible");
		DPAA_PMD_WARN("PUSH mode already enabled for first %d queues.",
			dpaa_push_queue_max_num());
		DPAA_PMD_WARN("To disable set DPAA_PUSH_QUEUES_NUMBER to 0");
	}

	dpaa_poll_queue_default_config(&opts);

	switch (queue_conf->ev.sched_type) {
	case RTE_SCHED_TYPE_ATOMIC:
		opts.fqd.fq_ctrl |= QM_FQCTRL_HOLDACTIVE;
		/* Reset FQCTRL_AVOIDBLOCK bit as it is unnecessary
		 * configuration with HOLD_ACTIVE setting
		 */
		opts.fqd.fq_ctrl &= (~QM_FQCTRL_AVOIDBLOCK);
		rxq->cb.dqrr_dpdk_cb = dpaa_rx_cb_atomic;
		break;
	case RTE_SCHED_TYPE_ORDERED:
		DPAA_PMD_ERR("Ordered queue schedule type is not supported");
		return -1;
	default:
		opts.fqd.fq_ctrl |= QM_FQCTRL_AVOIDBLOCK;
		rxq->cb.dqrr_dpdk_cb = dpaa_rx_cb_parallel;
		break;
	}

	opts.we_mask = opts.we_mask | QM_INITFQ_WE_DESTWQ;
	opts.fqd.dest.channel = ch_id;
	opts.fqd.dest.wq = queue_conf->ev.priority;

	if (dpaa_intf->cgr_rx) {
		opts.we_mask |= QM_INITFQ_WE_CGID;
		opts.fqd.cgid = dpaa_intf->cgr_rx[eth_rx_queue_id].cgrid;
		opts.fqd.fq_ctrl |= QM_FQCTRL_CGE;
	}

	flags = QMAN_INITFQ_FLAG_SCHED;

	ret = qman_init_fq(rxq, flags, &opts);
	if (ret) {
		DPAA_PMD_ERR("Ev-Channel/Q association failed. fqid 0x%x "
				"ret:%d(%s)", rxq->fqid, ret, strerror(ret));
		return ret;
	}

	/* copy configuration which needs to be filled during dequeue */
	memcpy(&rxq->ev, &queue_conf->ev, sizeof(struct rte_event));
	dev->data->rx_queues[eth_rx_queue_id] = rxq;

	return ret;
}

RTE_EXPORT_INTERNAL_SYMBOL(dpaa_eth_eventq_detach)
int
dpaa_eth_eventq_detach(const struct rte_eth_dev *dev,
		int eth_rx_queue_id)
{
	struct qm_mcc_initfq opts = {0};
	int ret;
	u32 flags = 0;
	struct dpaa_if *dpaa_intf = dev->data->dev_private;
	struct qman_fq *rxq = &dpaa_intf->rx_queues[eth_rx_queue_id];

	qman_retire_fq(rxq, NULL);
	qman_oos_fq(rxq);
	ret = qman_init_fq(rxq, flags, &opts);
	if (ret) {
		DPAA_PMD_ERR("detach rx fqid %d failed with ret: %d",
			     rxq->fqid, ret);
	}

	rxq->cb.dqrr_dpdk_cb = NULL;
	dev->data->rx_queues[eth_rx_queue_id] = NULL;

	return 0;
}

static
int dpaa_eth_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,
			    uint16_t nb_desc __rte_unused,
		unsigned int socket_id __rte_unused,
		const struct rte_eth_txconf *tx_conf)
{
	struct dpaa_if *dpaa_intf = dev->data->dev_private;
	struct qman_fq *txq = &dpaa_intf->tx_queues[queue_idx];

	PMD_INIT_FUNC_TRACE();

	txq->nb_desc = UINT16_MAX;
	txq->offloads = tx_conf->offloads;

	if (queue_idx >= dev->data->nb_tx_queues) {
		rte_errno = EOVERFLOW;
		DPAA_PMD_ERR("%p: queue index out of range (%u >= %u)",
		      (void *)dev, queue_idx, dev->data->nb_tx_queues);
		return -rte_errno;
	}

	DPAA_PMD_INFO("Tx queue setup for queue index: %d fq_id (0x%x)",
			queue_idx, txq->fqid);
	dev->data->tx_queues[queue_idx] = txq;

	return 0;
}

static int
dpaa_dev_rx_queue_count(void *rx_queue)
{
	struct qman_fq *rxq = rx_queue;
	u32 frm_cnt = 0;

	PMD_INIT_FUNC_TRACE();

	if (qman_query_fq_frm_cnt(rxq, &frm_cnt) == 0) {
		DPAA_PMD_DEBUG("RX frame count for q(%p) is %u",
			       rx_queue, frm_cnt);
	}
	return frm_cnt;
}

static int dpaa_link_down(struct rte_eth_dev *dev)
{
	struct fman_if *fif = dev->process_private;
	struct __fman_if *__fif;

	PMD_INIT_FUNC_TRACE();

	__fif = container_of(fif, struct __fman_if, __if);

	if (dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC &&
	    fif->mac_type != fman_offline_internal &&
	    fif->mac_type != fman_onic)
		dpaa_update_link_status(__fif->node_name, RTE_ETH_LINK_DOWN);
	else
		return dpaa_eth_dev_stop(dev);
	return 0;
}

static int dpaa_link_up(struct rte_eth_dev *dev)
{
	struct fman_if *fif = dev->process_private;
	struct __fman_if *__fif;

	PMD_INIT_FUNC_TRACE();

	__fif = container_of(fif, struct __fman_if, __if);

	if (dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC &&
	    fif->mac_type != fman_offline_internal &&
	    fif->mac_type != fman_onic)
		dpaa_update_link_status(__fif->node_name, RTE_ETH_LINK_UP);
	else
		dpaa_eth_dev_start(dev);
	return 0;
}

static int
dpaa_flow_ctrl_set(struct rte_eth_dev *dev,
		   struct rte_eth_fc_conf *fc_conf)
{
	struct dpaa_if *dpaa_intf = dev->data->dev_private;
	struct rte_eth_fc_conf *net_fc;
	struct fman_if *fm_if = dev->process_private;
	int ret;

	PMD_INIT_FUNC_TRACE();

	if (!(dpaa_intf->fc_conf)) {
		dpaa_intf->fc_conf = rte_zmalloc(NULL,
			sizeof(struct rte_eth_fc_conf), MAX_CACHELINE);
		if (!dpaa_intf->fc_conf) {
			DPAA_PMD_ERR("unable to save flow control info");
			return -ENOMEM;
		}
	}
	net_fc = dpaa_intf->fc_conf;

	if (fc_conf->high_water < fc_conf->low_water) {
		DPAA_PMD_ERR("Incorrect Flow Control Configuration");
		return -EINVAL;
	}

	if (fc_conf->mode == RTE_ETH_FC_NONE)
		return 0;

	if (fc_conf->mode != RTE_ETH_FC_TX_PAUSE &&
		fc_conf->mode != RTE_ETH_FC_FULL)
		goto save_fc;

	ret = fman_if_set_fc_threshold(fm_if,
					 fc_conf->high_water,
					 fc_conf->low_water,
					 dpaa_intf->bp_info->bpid);
	if (ret) {
		DPAA_PMD_ERR("Set %s's fc on bpid(%d) err(%d)",
				dev->data->name, dpaa_intf->bp_info->bpid,
				ret);
	}
	if (fc_conf->pause_time) {
		ret = fman_if_set_fc_quanta(fm_if, fc_conf->pause_time);
		if (ret) {
			DPAA_PMD_ERR("Set %s's fc pause time err(%d)",
				dev->data->name, ret);
		}
	}

save_fc:
	/* Save the information in dpaa device */
	net_fc->pause_time = fc_conf->pause_time;
	net_fc->high_water = fc_conf->high_water;
	net_fc->low_water = fc_conf->low_water;
	net_fc->send_xon = fc_conf->send_xon;
	net_fc->mac_ctrl_frame_fwd = fc_conf->mac_ctrl_frame_fwd;
	net_fc->mode = fc_conf->mode;
	net_fc->autoneg = fc_conf->autoneg;

	return 0;
}

static int
dpaa_flow_ctrl_get(struct rte_eth_dev *dev,
		   struct rte_eth_fc_conf *fc_conf)
{
	struct dpaa_if *dpaa_intf = dev->data->dev_private;
	struct rte_eth_fc_conf *net_fc = dpaa_intf->fc_conf;
	int ret;

	PMD_INIT_FUNC_TRACE();

	if (net_fc) {
		fc_conf->pause_time = net_fc->pause_time;
		fc_conf->high_water = net_fc->high_water;
		fc_conf->low_water = net_fc->low_water;
		fc_conf->send_xon = net_fc->send_xon;
		fc_conf->mac_ctrl_frame_fwd = net_fc->mac_ctrl_frame_fwd;
		fc_conf->mode = net_fc->mode;
		fc_conf->autoneg = net_fc->autoneg;
		return 0;
	}
	ret = fman_if_get_fc_threshold(dev->process_private);
	if (ret) {
		fc_conf->mode = RTE_ETH_FC_TX_PAUSE;
		fc_conf->pause_time =
			fman_if_get_fc_quanta(dev->process_private);
	} else {
		fc_conf->mode = RTE_ETH_FC_NONE;
	}

	return 0;
}

static int
dpaa_dev_add_mac_addr(struct rte_eth_dev *dev,
			     struct rte_ether_addr *addr,
			     uint32_t index,
			     __rte_unused uint32_t pool)
{
	int ret;
	struct fman_if *fif = dev->process_private;

	PMD_INIT_FUNC_TRACE();

	if (fif->mac_type == fman_offline_internal) {
		DPAA_PMD_DEBUG("Add MAC Address not supported on O/H port");
		return 0;
	}

	if (fif->mac_type == fman_onic) {
		DPAA_PMD_INFO("Add MAC Address not supported on ONIC port");
		return 0;
	}

	ret = fman_if_add_mac_addr(dev->process_private,
				   addr->addr_bytes, index);

	if (ret)
		DPAA_PMD_ERR("Adding the MAC ADDR failed: err = %d", ret);
	return 0;
}

static void
dpaa_dev_remove_mac_addr(struct rte_eth_dev *dev,
			  uint32_t index)
{
	struct fman_if *fif = dev->process_private;

	PMD_INIT_FUNC_TRACE();

	if (fif->mac_type == fman_offline_internal) {
		DPAA_PMD_DEBUG("Remove MAC Address not supported on O/H port");
		return;
	}

	if (fif->mac_type == fman_onic) {
		DPAA_PMD_INFO("Remove MAC Address not supported on ONIC port");
		return;
	}

	fman_if_clear_mac_addr(dev->process_private, index);
}

static int
dpaa_dev_set_mac_addr(struct rte_eth_dev *dev,
		       struct rte_ether_addr *addr)
{
	int ret;
	struct fman_if *fif = dev->process_private;

	PMD_INIT_FUNC_TRACE();

	if (fif->mac_type == fman_offline_internal) {
		DPAA_PMD_DEBUG("Set MAC Address not supported on O/H port");
		return 0;
	}

	if (fif->mac_type == fman_onic) {
		DPAA_PMD_INFO("Set MAC Address not supported on ONIC port");
		return 0;
	}

	ret = fman_if_add_mac_addr(dev->process_private, addr->addr_bytes, 0);
	if (ret)
		DPAA_PMD_ERR("Setting the MAC ADDR failed %d", ret);

	return ret;
}

static int
dpaa_dev_rss_hash_update(struct rte_eth_dev *dev,
			 struct rte_eth_rss_conf *rss_conf)
{
	struct rte_eth_dev_data *data = dev->data;
	struct rte_eth_conf *eth_conf = &data->dev_conf;
	int ret;

	PMD_INIT_FUNC_TRACE();

	if (!(default_q || fmc_q)) {
		ret = dpaa_fm_config(dev, rss_conf->rss_hf);
		if (ret) {
			DPAA_PMD_ERR("FM port configuration: Failed(%d)", ret);
			return ret;
		}
		eth_conf->rx_adv_conf.rss_conf.rss_hf = rss_conf->rss_hf;
	} else {
		DPAA_PMD_ERR("Function not supported");
		return -ENOTSUP;
	}
	return 0;
}

static int
dpaa_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
			   struct rte_eth_rss_conf *rss_conf)
{
	struct rte_eth_dev_data *data = dev->data;
	struct rte_eth_conf *eth_conf = &data->dev_conf;

	/* dpaa does not support rss_key, so length should be 0*/
	rss_conf->rss_key_len = 0;
	rss_conf->rss_hf = eth_conf->rx_adv_conf.rss_conf.rss_hf;
	return 0;
}

static int dpaa_dev_queue_intr_enable(struct rte_eth_dev *dev,
				      uint16_t queue_id)
{
	struct dpaa_if *dpaa_intf = dev->data->dev_private;
	struct qman_fq *rxq = &dpaa_intf->rx_queues[queue_id];

	if (!rxq->is_static)
		return -EINVAL;

	return qman_fq_portal_irqsource_add(rxq->qp, QM_PIRQ_DQRI);
}

static int dpaa_dev_queue_intr_disable(struct rte_eth_dev *dev,
				       uint16_t queue_id)
{
	struct dpaa_if *dpaa_intf = dev->data->dev_private;
	struct qman_fq *rxq = &dpaa_intf->rx_queues[queue_id];
	uint32_t temp;
	ssize_t temp1;

	if (!rxq->is_static)
		return -EINVAL;

	qman_fq_portal_irqsource_remove(rxq->qp, ~0);

	temp1 = read(rxq->q_fd, &temp, sizeof(temp));
	if (temp1 != sizeof(temp))
		DPAA_PMD_DEBUG("read did not return anything");

	qman_fq_portal_thread_irq(rxq->qp);

	return 0;
}

static void
dpaa_rxq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,
	struct rte_eth_rxq_info *qinfo)
{
	struct dpaa_if *dpaa_intf = dev->data->dev_private;
	struct qman_fq *rxq;
	int ret;

	rxq = dev->data->rx_queues[queue_id];

	qinfo->mp = dpaa_intf->bp_info->mp;
	qinfo->scattered_rx = dev->data->scattered_rx;
	qinfo->nb_desc = rxq->nb_desc;

	/* Report the HW Rx buffer length to user */
	ret = fman_if_get_maxfrm(dev->process_private);
	if (ret > 0)
		qinfo->rx_buf_size = ret;

	qinfo->conf.rx_free_thresh = 1;
	qinfo->conf.rx_drop_en = 1;
	qinfo->conf.rx_deferred_start = 0;
	qinfo->conf.offloads = rxq->offloads;
}

static void
dpaa_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,
	struct rte_eth_txq_info *qinfo)
{
	struct qman_fq *txq;

	txq = dev->data->tx_queues[queue_id];

	qinfo->nb_desc = txq->nb_desc;
	qinfo->conf.tx_thresh.pthresh = 0;
	qinfo->conf.tx_thresh.hthresh = 0;
	qinfo->conf.tx_thresh.wthresh = 0;

	qinfo->conf.tx_free_thresh = 0;
	qinfo->conf.tx_rs_thresh = 0;
	qinfo->conf.offloads = txq->offloads;
	qinfo->conf.tx_deferred_start = 0;
}

static struct eth_dev_ops dpaa_devops = {
	.dev_configure		  = dpaa_eth_dev_configure,
	.dev_start		  = dpaa_eth_dev_start,
	.dev_stop		  = dpaa_eth_dev_stop,
	.dev_close		  = dpaa_eth_dev_close,
	.dev_infos_get		  = dpaa_eth_dev_info,
	.dev_supported_ptypes_get = dpaa_supported_ptypes_get,

	.rx_queue_setup		  = dpaa_eth_rx_queue_setup,
	.tx_queue_setup		  = dpaa_eth_tx_queue_setup,
	.rx_burst_mode_get	  = dpaa_dev_rx_burst_mode_get,
	.tx_burst_mode_get	  = dpaa_dev_tx_burst_mode_get,
	.rxq_info_get		  = dpaa_rxq_info_get,
	.txq_info_get		  = dpaa_txq_info_get,

	.flow_ctrl_get		  = dpaa_flow_ctrl_get,
	.flow_ctrl_set		  = dpaa_flow_ctrl_set,

	.link_update		  = dpaa_eth_link_update,
	.stats_get		  = dpaa_eth_stats_get,
	.xstats_get		  = dpaa_dev_xstats_get,
	.xstats_get_by_id	  = dpaa_xstats_get_by_id,
	.xstats_get_names_by_id	  = dpaa_xstats_get_names_by_id,
	.xstats_get_names	  = dpaa_xstats_get_names,
	.xstats_reset		  = dpaa_eth_stats_reset,
	.stats_reset		  = dpaa_eth_stats_reset,
	.promiscuous_enable	  = dpaa_eth_promiscuous_enable,
	.promiscuous_disable	  = dpaa_eth_promiscuous_disable,
	.allmulticast_enable	  = dpaa_eth_multicast_enable,
	.allmulticast_disable	  = dpaa_eth_multicast_disable,
	.mtu_set		  = dpaa_mtu_set,
	.dev_set_link_down	  = dpaa_link_down,
	.dev_set_link_up	  = dpaa_link_up,
	.mac_addr_add		  = dpaa_dev_add_mac_addr,
	.mac_addr_remove	  = dpaa_dev_remove_mac_addr,
	.mac_addr_set		  = dpaa_dev_set_mac_addr,

	.fw_version_get		  = dpaa_fw_version_get,

	.rx_queue_intr_enable	  = dpaa_dev_queue_intr_enable,
	.rx_queue_intr_disable	  = dpaa_dev_queue_intr_disable,
	.rss_hash_update	  = dpaa_dev_rss_hash_update,
	.rss_hash_conf_get        = dpaa_dev_rss_hash_conf_get,
	.timesync_enable	  = dpaa_timesync_enable,
	.timesync_disable	  = dpaa_timesync_disable,
	.timesync_read_time	  = dpaa_timesync_read_time,
	.timesync_write_time	  = dpaa_timesync_write_time,
	.timesync_adjust_time	  = dpaa_timesync_adjust_time,
	.timesync_read_rx_timestamp = dpaa_timesync_read_rx_timestamp,
	.timesync_read_tx_timestamp = dpaa_timesync_read_tx_timestamp,
};

static bool
is_device_supported(struct rte_eth_dev *dev, struct rte_dpaa_driver *drv)
{
	if (strcmp(dev->device->driver->name,
		   drv->driver.name))
		return false;

	return true;
}

static bool
is_dpaa_supported(struct rte_eth_dev *dev)
{
	return is_device_supported(dev, &rte_dpaa_pmd);
}

RTE_EXPORT_SYMBOL(rte_pmd_dpaa_set_tx_loopback)
int
rte_pmd_dpaa_set_tx_loopback(uint16_t port, uint8_t on)
{
	struct rte_eth_dev *dev;

	RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);

	dev = &rte_eth_devices[port];

	if (!is_dpaa_supported(dev))
		return -ENOTSUP;

	if (on)
		fman_if_loopback_enable(dev->process_private);
	else
		fman_if_loopback_disable(dev->process_private);

	return 0;
}

static int dpaa_fc_set_default(struct dpaa_if *dpaa_intf,
			       struct fman_if *fman_intf)
{
	struct rte_eth_fc_conf *fc_conf;
	int ret;

	PMD_INIT_FUNC_TRACE();

	if (!(dpaa_intf->fc_conf)) {
		dpaa_intf->fc_conf = rte_zmalloc(NULL,
			sizeof(struct rte_eth_fc_conf), MAX_CACHELINE);
		if (!dpaa_intf->fc_conf) {
			DPAA_PMD_ERR("unable to save flow control info");
			return -ENOMEM;
		}
	}
	fc_conf = dpaa_intf->fc_conf;
	ret = fman_if_get_fc_threshold(fman_intf);
	if (ret) {
		fc_conf->mode = RTE_ETH_FC_TX_PAUSE;
		fc_conf->pause_time = fman_if_get_fc_quanta(fman_intf);
	} else {
		fc_conf->mode = RTE_ETH_FC_NONE;
	}

	return 0;
}

/* Initialise an Rx FQ */
static int dpaa_rx_queue_init(struct qman_fq *fq, struct qman_cgr *cgr_rx,
			      uint32_t fqid)
{
	struct qm_mcc_initfq opts = {0};
	int ret;
	u32 flags = QMAN_FQ_FLAG_NO_ENQUEUE;
	struct qm_mcc_initcgr cgr_opts = {
		.we_mask = QM_CGR_WE_CS_THRES |
				QM_CGR_WE_CSTD_EN |
				QM_CGR_WE_MODE,
		.cgr = {
			.cstd_en = QM_CGR_EN,
			.mode = QMAN_CGR_MODE_FRAME
		}
	};

	if (fmc_q || default_q) {
		ret = qman_reserve_fqid(fqid);
		if (ret) {
			DPAA_PMD_ERR("reserve rx fqid 0x%x failed, ret: %d",
				     fqid, ret);
			return -EINVAL;
		}
	}

	DPAA_PMD_DEBUG("creating rx fq %p, fqid 0x%x", fq, fqid);
	ret = qman_create_fq(fqid, flags, fq);
	if (ret) {
		DPAA_PMD_ERR("create rx fqid 0x%x failed with ret: %d",
			fqid, ret);
		return ret;
	}
	fq->is_static = false;

	dpaa_poll_queue_default_config(&opts);

	if (cgr_rx) {
		/* Enable tail drop with cgr on this queue */
		qm_cgr_cs_thres_set64(&cgr_opts.cgr.cs_thres, td_threshold, 0);
		cgr_rx->cb = NULL;
		ret = qman_create_cgr(cgr_rx, QMAN_CGR_FLAG_USE_INIT,
				      &cgr_opts);
		if (ret) {
			DPAA_PMD_WARN(
				"rx taildrop init fail on rx fqid 0x%x(ret=%d)",
				fq->fqid, ret);
			goto without_cgr;
		}
		opts.we_mask |= QM_INITFQ_WE_CGID;
		opts.fqd.cgid = cgr_rx->cgrid;
		opts.fqd.fq_ctrl |= QM_FQCTRL_CGE;
	}
without_cgr:
	ret = qman_init_fq(fq, 0, &opts);
	if (ret)
		DPAA_PMD_ERR("init rx fqid 0x%x failed with ret:%d", fqid, ret);
	return ret;
}

uint8_t fm_default_vsp_id(struct fman_if *fif)
{
	/* Avoid being same as base profile which could be used
	 * for kernel interface of shared mac.
	 */
	if (fif->base_profile_id)
		return 0;
	else
		return DPAA_DEFAULT_RXQ_VSP_ID;
}

/* Initialise a Tx FQ */
static int dpaa_tx_queue_init(struct qman_fq *fq,
			      struct fman_if *fman_intf,
			      struct qman_cgr *cgr_tx)
{
	struct qm_mcc_initfq opts = {0};
	struct qm_mcc_initcgr cgr_opts = {
		.we_mask = QM_CGR_WE_CS_THRES |
				QM_CGR_WE_CSTD_EN |
				QM_CGR_WE_MODE,
		.cgr = {
			.cstd_en = QM_CGR_EN,
			.mode = QMAN_CGR_MODE_FRAME
		}
	};
	int ret;
	struct dpaa_if *dpaa_intf = fq->dpaa_intf;

	ret = qman_create_fq(0, QMAN_FQ_FLAG_DYNAMIC_FQID |
			     QMAN_FQ_FLAG_TO_DCPORTAL, fq);
	if (ret) {
		DPAA_PMD_ERR("create tx fq failed with ret: %d", ret);
		return ret;
	}
	opts.we_mask = QM_INITFQ_WE_DESTWQ | QM_INITFQ_WE_FQCTRL |
		       QM_INITFQ_WE_CONTEXTB | QM_INITFQ_WE_CONTEXTA;
	opts.fqd.dest.channel = fman_intf->tx_channel_id;
	opts.fqd.dest.wq = DPAA_IF_TX_PRIORITY;
	opts.fqd.fq_ctrl = QM_FQCTRL_PREFERINCACHE;
	opts.fqd.context_b = 0;
	if (dpaa_intf->ts_enable) {
		opts.fqd.context_a.lo = 0;
		opts.fqd.context_a.hi =
			fman_intf->fman->dealloc_bufs_mask_hi;
	} else {
		/* no tx-confirmation */
		opts.fqd.context_a.lo =
			fman_intf->fman->dealloc_bufs_mask_lo;
		opts.fqd.context_a.hi =
			DPAA_FQD_CTX_A_OVERRIDE_FQ |
			fman_intf->fman->dealloc_bufs_mask_hi;
	}

	if (fman_intf->fman->ip_rev >= FMAN_V3)
		/* Set B0V bit in contextA to set ASPID to 0 */
		opts.fqd.context_a.hi |= DPAA_FQD_CTX_A_B0_FIELD_VALID;

	if (fman_intf->mac_type == fman_offline_internal ||
	    fman_intf->mac_type == fman_onic) {
		opts.fqd.context_a.lo |= DPAA_FQD_CTX_A2_VSPE_BIT;
		opts.fqd.context_b = fm_default_vsp_id(fman_intf) <<
				     DPAA_FQD_CTX_B_SHIFT_BITS;
	}

	DPAA_PMD_DEBUG("init tx fq %p, fqid 0x%x", fq, fq->fqid);

	if (cgr_tx) {
		/* Enable tail drop with cgr on this queue */
		qm_cgr_cs_thres_set64(&cgr_opts.cgr.cs_thres,
				      td_tx_threshold, 0);
		cgr_tx->cb = NULL;
		ret = qman_create_cgr(cgr_tx, QMAN_CGR_FLAG_USE_INIT,
				      &cgr_opts);
		if (ret) {
			DPAA_PMD_WARN(
				"rx taildrop init fail on rx fqid 0x%x(ret=%d)",
				fq->fqid, ret);
			goto without_cgr;
		}
		opts.we_mask |= QM_INITFQ_WE_CGID;
		opts.fqd.cgid = cgr_tx->cgrid;
		opts.fqd.fq_ctrl |= QM_FQCTRL_CGE;
		DPAA_PMD_DEBUG("Tx FQ tail drop enabled, threshold = %d",
				td_tx_threshold);
	}
without_cgr:
	ret = qman_init_fq(fq, QMAN_INITFQ_FLAG_SCHED, &opts);
	if (ret)
		DPAA_PMD_ERR("init tx fqid 0x%x failed %d", fq->fqid, ret);
	return ret;
}

int
dpaa_tx_conf_queue_init(struct qman_fq *fq)
{
	struct qm_mcc_initfq opts = {0};
	int ret;

	PMD_INIT_FUNC_TRACE();

	ret = qman_create_fq(0, QMAN_FQ_FLAG_DYNAMIC_FQID, fq);
	if (ret) {
		DPAA_PMD_ERR("create Tx_conf failed with ret: %d", ret);
		return ret;
	}

	opts.we_mask = QM_INITFQ_WE_DESTWQ | QM_INITFQ_WE_FQCTRL;
	opts.fqd.dest.wq = DPAA_IF_DEBUG_PRIORITY;
	ret = qman_init_fq(fq, 0, &opts);
	if (ret)
		DPAA_PMD_ERR("init Tx_conf fqid %d failed with ret: %d",
			fq->fqid, ret);
	return ret;
}

#if defined(RTE_LIBRTE_DPAA_DEBUG_DRIVER)
/* Initialise a DEBUG FQ ([rt]x_error, rx_default) */
static int dpaa_def_queue_init(struct qman_fq *fq, uint32_t fqid)
{
	struct qm_mcc_initfq opts = {0};
	int ret;

	PMD_INIT_FUNC_TRACE();

	ret = qman_reserve_fqid(fqid);
	if (ret) {
		DPAA_PMD_ERR("Reserve fqid %d failed with ret: %d",
			fqid, ret);
		return -EINVAL;
	}
	/* "map" this Rx FQ to one of the interfaces Tx FQID */
	DPAA_PMD_DEBUG("Creating fq %p, fqid %d", fq, fqid);
	ret = qman_create_fq(fqid, QMAN_FQ_FLAG_NO_ENQUEUE, fq);
	if (ret) {
		DPAA_PMD_ERR("create fqid %d failed with ret: %d",
			fqid, ret);
		return ret;
	}
	opts.we_mask = QM_INITFQ_WE_DESTWQ | QM_INITFQ_WE_FQCTRL;
	opts.fqd.dest.wq = DPAA_IF_DEBUG_PRIORITY;
	ret = qman_init_fq(fq, 0, &opts);
	if (ret)
		DPAA_PMD_ERR("init fqid %d failed with ret: %d",
			    fqid, ret);
	return ret;
}
#endif

/* Initialise a network interface */
static int
dpaa_dev_init_secondary(struct rte_eth_dev *eth_dev)
{
	struct rte_dpaa_device *dpaa_device;
	struct fm_eth_port_cfg *cfg;
	struct dpaa_if *dpaa_intf;
	struct fman_if *fman_intf;
	int dev_id;

	PMD_INIT_FUNC_TRACE();

	dpaa_device = RTE_CLASS_TO_BUS_DEVICE(eth_dev, *dpaa_device);
	dev_id = dpaa_device->id.dev_id;
	cfg = dpaa_get_eth_port_cfg(dev_id);
	fman_intf = cfg->fman_if;
	eth_dev->process_private = fman_intf;

	/* Plugging of UCODE burst API not supported in Secondary */
	dpaa_intf = eth_dev->data->dev_private;
	eth_dev->rx_pkt_burst = dpaa_eth_queue_rx;
	if (dpaa_intf->cgr_tx)
		eth_dev->tx_pkt_burst = dpaa_eth_queue_tx_slow;
	else
		eth_dev->tx_pkt_burst = dpaa_eth_queue_tx;
#ifdef CONFIG_FSL_QMAN_FQ_LOOKUP
	qman_set_fq_lookup_table(
		dpaa_intf->rx_queues->qman_fq_lookup_table);
#endif

	return 0;
}

#ifdef RTE_LIBRTE_DPAA_DEBUG_DRIVER
static int
dpaa_error_queue_init(struct dpaa_if *dpaa_intf,
	struct fman_if *fman_intf)
{
	int i, ret;
	struct qman_fq *err_queues = dpaa_intf->debug_queues;
	uint32_t err_fqid = 0;

	if (fman_intf->is_shared_mac) {
		DPAA_PMD_DEBUG("Shared MAC's err queues are handled in kernel");
		return 0;
	}

	for (i = 0; i < DPAA_DEBUG_FQ_MAX_NUM; i++) {
		if (i == DPAA_DEBUG_FQ_RX_ERROR)
			err_fqid = fman_intf->fqid_rx_err;
		else if (i == DPAA_DEBUG_FQ_TX_ERROR)
			err_fqid = fman_intf->fqid_tx_err;
		else
			continue;
		ret = dpaa_def_queue_init(&err_queues[i], err_fqid);
		if (ret) {
			DPAA_PMD_ERR("DPAA %s ERROR queue init failed!",
				i == DPAA_DEBUG_FQ_RX_ERROR ?
				"RX" : "TX");
			return ret;
		}
		err_queues[i].dpaa_intf = dpaa_intf;
	}

	return 0;
}
#endif

static int
check_devargs_handler(__rte_unused const char *key, const char *value,
		      __rte_unused void *opaque)
{
	if (strcmp(value, "1"))
		return -1;

	return 0;
}

static int
dpaa_get_devargs(struct rte_devargs *devargs, const char *key)
{
	struct rte_kvargs *kvlist;

	if (!devargs)
		return 0;

	kvlist = rte_kvargs_parse(devargs->args, NULL);
	if (!kvlist)
		return 0;

	if (!rte_kvargs_count(kvlist, key)) {
		rte_kvargs_free(kvlist);
		return 0;
	}

	if (rte_kvargs_process(kvlist, key,
			       check_devargs_handler, NULL) < 0) {
		rte_kvargs_free(kvlist);
		return 0;
	}
	rte_kvargs_free(kvlist);

	return 1;
}

/* Initialise a network interface */
static int
dpaa_dev_init(struct rte_eth_dev *eth_dev)
{
	int num_rx_fqs, fqid;
	int loop, ret = 0;
	int dev_id;
	struct rte_dpaa_device *dpaa_device;
	struct dpaa_if *dpaa_intf;
	struct fm_eth_port_cfg *cfg;
	struct fman_if *fman_intf;
	struct fman_if_bpool *bp, *tmp_bp;
	uint32_t cgrid[DPAA_MAX_NUM_PCD_QUEUES];
	uint32_t cgrid_tx[MAX_DPAA_CORES];
	uint32_t dev_rx_fqids[DPAA_MAX_NUM_PCD_QUEUES];
	int8_t dev_vspids[DPAA_MAX_NUM_PCD_QUEUES];
	int8_t vsp_id = -1;
	struct rte_device *dev = eth_dev->device;
#ifdef RTE_LIBRTE_DPAA_DEBUG_DRIVER
	char *penv;
#endif

	PMD_INIT_FUNC_TRACE();

	dpaa_device = RTE_CLASS_TO_BUS_DEVICE(eth_dev, *dpaa_device);
	dev_id = dpaa_device->id.dev_id;
	dpaa_intf = eth_dev->data->dev_private;
	cfg = dpaa_get_eth_port_cfg(dev_id);
	fman_intf = cfg->fman_if;

	dpaa_intf->name = dpaa_device->name;

	/* save fman_if & cfg in the interface structure */
	eth_dev->process_private = fman_intf;
	dpaa_intf->ifid = dev_id;
	dpaa_intf->cfg = cfg;

	if (dpaa_get_devargs(dev->devargs, DRIVER_RECV_ERR_PKTS))
		dpaa_enable_recv_err_pkts = 1;

	memset((char *)dev_rx_fqids, 0,
		sizeof(uint32_t) * DPAA_MAX_NUM_PCD_QUEUES);

	memset(dev_vspids, -1, DPAA_MAX_NUM_PCD_QUEUES);

	/* Initialize Rx FQ's */
	if (default_q) {
		num_rx_fqs = DPAA_DEFAULT_NUM_PCD_QUEUES;
	} else if (fmc_q) {
		num_rx_fqs = dpaa_port_fmc_init(fman_intf, dev_rx_fqids,
						dev_vspids,
						DPAA_MAX_NUM_PCD_QUEUES);
		if (num_rx_fqs < 0) {
			DPAA_PMD_ERR("%s FMC initializes failed!",
				dpaa_intf->name);
			goto free_rx;
		}
		if (!num_rx_fqs) {
			if (fman_intf->mac_type == fman_offline_internal ||
			    fman_intf->mac_type == fman_onic) {
				ret = -ENODEV;
				goto free_rx;
			}
			DPAA_PMD_WARN("%s is not configured by FMC.",
				dpaa_intf->name);
		}
	} else {
		/* FMCLESS mode, load balance to multiple cores.*/
		num_rx_fqs = rte_lcore_count();
	}

	/* Each device can not have more than DPAA_MAX_NUM_PCD_QUEUES RX
	 * queues.
	 */
	if (num_rx_fqs > DPAA_MAX_NUM_PCD_QUEUES) {
		DPAA_PMD_ERR("Invalid number of RX queues(%d)", num_rx_fqs);
		return -EINVAL;
	}

	if (num_rx_fqs > 0) {
		dpaa_intf->rx_queues = rte_zmalloc(NULL,
			sizeof(struct qman_fq) * num_rx_fqs, MAX_CACHELINE);
		if (!dpaa_intf->rx_queues) {
			DPAA_PMD_ERR("Failed to alloc mem for RX queues");
			return -ENOMEM;
		}
	} else {
		dpaa_intf->rx_queues = NULL;
	}

	memset(cgrid, 0, sizeof(cgrid));
	memset(cgrid_tx, 0, sizeof(cgrid_tx));

	/* if DPAA_TX_TAILDROP_THRESHOLD is set, use that value; if 0, it means
	 * Tx tail drop is disabled.
	 */
	if (getenv("DPAA_TX_TAILDROP_THRESHOLD")) {
		td_tx_threshold = atoi(getenv("DPAA_TX_TAILDROP_THRESHOLD"));
		DPAA_PMD_DEBUG("Tail drop threshold env configured: %u",
			       td_tx_threshold);
		/* if a very large value is being configured */
		if (td_tx_threshold > UINT16_MAX)
			td_tx_threshold = CGR_RX_PERFQ_THRESH;
	}

#ifdef RTE_LIBRTE_DPAA_DEBUG_DRIVER
	penv = getenv("DPAA_DISPLAY_FRAME_AND_PARSER_RESULT");
	if (penv)
		dpaa_force_display_frame_set(atoi(penv));
#endif

	/* If congestion control is enabled globally*/
	if (num_rx_fqs > 0 && td_threshold) {
		dpaa_intf->cgr_rx = rte_zmalloc(NULL,
			sizeof(struct qman_cgr) * num_rx_fqs, MAX_CACHELINE);
		if (!dpaa_intf->cgr_rx) {
			DPAA_PMD_ERR("Failed to alloc mem for cgr_rx");
			ret = -ENOMEM;
			goto free_rx;
		}

		ret = qman_alloc_cgrid_range(&cgrid[0], num_rx_fqs, 1, 0);
		if (ret != num_rx_fqs) {
			DPAA_PMD_WARN("insufficient CGRIDs available");
			ret = -EINVAL;
			goto free_rx;
		}
	} else {
		dpaa_intf->cgr_rx = NULL;
	}

	if (!fmc_q && !default_q) {
		ret = qman_alloc_fqid_range(dev_rx_fqids, num_rx_fqs,
					    num_rx_fqs, 0);
		if (ret < 0) {
			DPAA_PMD_ERR("Failed to alloc rx fqid's");
			goto free_rx;
		}
	}

	for (loop = 0; loop < num_rx_fqs; loop++) {
		if (default_q)
			fqid = cfg->rx_def;
		else
			fqid = dev_rx_fqids[loop];

		vsp_id = dev_vspids[loop];

		if (dpaa_intf->cgr_rx)
			dpaa_intf->cgr_rx[loop].cgrid = cgrid[loop];

		ret = dpaa_rx_queue_init(&dpaa_intf->rx_queues[loop],
			dpaa_intf->cgr_rx ? &dpaa_intf->cgr_rx[loop] : NULL,
			fqid);
		if (ret)
			goto free_rx;
		dpaa_intf->rx_queues[loop].vsp_id = vsp_id;
		dpaa_intf->rx_queues[loop].dpaa_intf = dpaa_intf;
	}
	dpaa_intf->nb_rx_queues = num_rx_fqs;

	/* Initialise Tx FQs.free_rx Have as many Tx FQ's as number of cores */
	dpaa_intf->tx_queues = rte_zmalloc(NULL, sizeof(struct qman_fq) *
		MAX_DPAA_CORES, MAX_CACHELINE);
	if (!dpaa_intf->tx_queues) {
		DPAA_PMD_ERR("Failed to alloc mem for TX queues");
		ret = -ENOMEM;
		goto free_rx;
	}

	dpaa_intf->tx_conf_queues = rte_zmalloc(NULL, sizeof(struct qman_fq) *
		MAX_DPAA_CORES, MAX_CACHELINE);
	if (!dpaa_intf->tx_conf_queues) {
		DPAA_PMD_ERR("Failed to alloc mem for TX conf queues");
		ret = -ENOMEM;
		goto free_rx;
	}

	/* If congestion control is enabled globally*/
	if (td_tx_threshold) {
		dpaa_intf->cgr_tx = rte_zmalloc(NULL,
			sizeof(struct qman_cgr) * MAX_DPAA_CORES,
			MAX_CACHELINE);
		if (!dpaa_intf->cgr_tx) {
			DPAA_PMD_ERR("Failed to alloc mem for cgr_tx");
			ret = -ENOMEM;
			goto free_rx;
		}

		ret = qman_alloc_cgrid_range(&cgrid_tx[0], MAX_DPAA_CORES,
					     1, 0);
		if (ret != MAX_DPAA_CORES) {
			DPAA_PMD_WARN("insufficient CGRIDs available");
			ret = -EINVAL;
			goto free_rx;
		}
	} else {
		dpaa_intf->cgr_tx = NULL;
	}


	for (loop = 0; loop < MAX_DPAA_CORES; loop++) {
		if (dpaa_intf->cgr_tx)
			dpaa_intf->cgr_tx[loop].cgrid = cgrid_tx[loop];

		dpaa_intf->tx_queues[loop].dpaa_intf = dpaa_intf;
		ret = dpaa_tx_queue_init(&dpaa_intf->tx_queues[loop],
			fman_intf,
			dpaa_intf->cgr_tx ? &dpaa_intf->cgr_tx[loop] : NULL);
		if (ret)
			goto free_tx;

		if (dpaa_intf->ts_enable) {
			ret = dpaa_tx_conf_queue_init(&dpaa_intf->tx_conf_queues[loop]);
			if (ret)
				goto free_tx;

			dpaa_intf->tx_conf_queues[loop].dpaa_intf = dpaa_intf;
			dpaa_intf->tx_queues[loop].tx_conf_queue = &dpaa_intf->tx_conf_queues[loop];
		}
	}
	dpaa_intf->nb_tx_queues = MAX_DPAA_CORES;
#if defined(RTE_LIBRTE_DPAA_DEBUG_DRIVER)
	ret = dpaa_error_queue_init(dpaa_intf, fman_intf);
	if (ret)
		goto free_tx;
#endif
	DPAA_PMD_DEBUG("All frame queues created");

	/* Get the initial configuration for flow control */
	if (fman_intf->mac_type != fman_offline_internal &&
	    fman_intf->mac_type != fman_onic)
		dpaa_fc_set_default(dpaa_intf, fman_intf);

	/* reset bpool list, initialize bpool dynamically */
	list_for_each_entry_safe(bp, tmp_bp, &cfg->fman_if->bpool_list, node) {
		list_del(&bp->node);
		rte_free(bp);
	}

	/* Populate ethdev structure */
	eth_dev->dev_ops = &dpaa_devops;
	eth_dev->rx_queue_count = dpaa_dev_rx_queue_count;
	eth_dev->rx_pkt_burst = dpaa_eth_queue_rx;
	eth_dev->tx_pkt_burst = dpaa_eth_tx_drop_all;

	/* Allocate memory for storing MAC addresses */
	eth_dev->data->mac_addrs = rte_zmalloc("mac_addr",
		RTE_ETHER_ADDR_LEN * DPAA_MAX_MAC_FILTER, 0);
	if (eth_dev->data->mac_addrs == NULL) {
		DPAA_PMD_ERR("Failed to allocate %d bytes needed to "
						"store MAC addresses",
				RTE_ETHER_ADDR_LEN * DPAA_MAX_MAC_FILTER);
		ret = -ENOMEM;
		goto free_tx;
	}

	/* copy the primary mac address */
	rte_ether_addr_copy(&fman_intf->mac_addr, &eth_dev->data->mac_addrs[0]);

	DPAA_PMD_INFO("net: dpaa: %s: " RTE_ETHER_ADDR_PRT_FMT,
		      dpaa_device->name, RTE_ETHER_ADDR_BYTES(&fman_intf->mac_addr));

	if (!fman_intf->is_shared_mac &&
	    fman_intf->mac_type != fman_offline_internal &&
	    fman_intf->mac_type != fman_onic) {
		/* Configure error packet handling */
#ifndef RTE_LIBRTE_DPAA_DEBUG_DRIVER
			if (dpaa_enable_recv_err_pkts)
#endif
				fman_if_receive_rx_errors(fman_intf,
						FM_FD_RX_STATUS_ERR_MASK);

		/* Disable RX mode */
		fman_if_disable_rx(fman_intf);
		/* Disable promiscuous mode */
		fman_if_promiscuous_disable(fman_intf);
		/* Disable multicast */
		fman_if_reset_mcast_filter_table(fman_intf);
		/* Reset interface statistics */
		fman_if_stats_reset(fman_intf);
		/* Disable SG by default */
		fman_if_set_sg(fman_intf, 0);
		fman_if_set_maxfrm(fman_intf,
				   RTE_ETHER_MAX_LEN + VLAN_TAG_SIZE);
	}

	return 0;

free_tx:
	rte_free(dpaa_intf->tx_queues);
	dpaa_intf->tx_queues = NULL;
	dpaa_intf->nb_tx_queues = 0;

free_rx:
	rte_free(dpaa_intf->cgr_rx);
	rte_free(dpaa_intf->cgr_tx);
	rte_free(dpaa_intf->rx_queues);
	dpaa_intf->rx_queues = NULL;
	dpaa_intf->nb_rx_queues = 0;
	return ret;
}

static int
rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv,
	       struct rte_dpaa_device *dpaa_dev)
{
	int diag;
	int ret;
	struct rte_eth_dev *eth_dev;

	PMD_INIT_FUNC_TRACE();

	if ((DPAA_MBUF_HW_ANNOTATION + DPAA_FD_PTA_SIZE) >
		RTE_PKTMBUF_HEADROOM) {
		DPAA_PMD_ERR(
		"RTE_PKTMBUF_HEADROOM(%d) shall be > DPAA Annotation req(%d)",
		RTE_PKTMBUF_HEADROOM,
		DPAA_MBUF_HW_ANNOTATION + DPAA_FD_PTA_SIZE);

		return -1;
	}

	/* In case of secondary process, the device is already configured
	 * and no further action is required, except portal initialization
	 * and verifying secondary attachment to port name.
	 */
	if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
		eth_dev = rte_eth_dev_attach_secondary(dpaa_dev->name);
		if (!eth_dev)
			return -ENOMEM;
		eth_dev->device = &dpaa_dev->device;
		eth_dev->dev_ops = &dpaa_devops;

		ret = dpaa_dev_init_secondary(eth_dev);
		if (ret) {
			DPAA_PMD_ERR("secondary dev init failed(%d)", ret);
			return ret;
		}

		rte_eth_dev_probing_finish(eth_dev);
		return 0;
	}

	if (!is_global_init && (rte_eal_process_type() == RTE_PROC_PRIMARY)) {
		if (access("/tmp/fmc.bin", F_OK) == -1) {
			DPAA_PMD_INFO("* FMC not configured.Enabling default mode");
			default_q = 1;
		}

		if (!(default_q || fmc_q)) {
			ret = dpaa_fm_init();
			if (ret) {
				DPAA_PMD_ERR("FM init failed(%d)", ret);
				return ret;
			}
		}

		is_global_init = 1;
	}

	if (unlikely(!DPAA_PER_LCORE_PORTAL)) {
		ret = rte_dpaa_portal_init((void *)1);
		if (ret) {
			DPAA_PMD_ERR("Unable to initialize portal");
			return ret;
		}
	}

	eth_dev = rte_eth_dev_allocate(dpaa_dev->name);
	if (!eth_dev)
		return -ENOMEM;

	eth_dev->data->dev_private =
			rte_zmalloc("ethdev private structure",
					sizeof(struct dpaa_if),
					RTE_CACHE_LINE_SIZE);
	if (!eth_dev->data->dev_private) {
		DPAA_PMD_ERR("Cannot allocate memzone for port data");
		rte_eth_dev_release_port(eth_dev);
		return -ENOMEM;
	}

	eth_dev->device = &dpaa_dev->device;

	qman_ern_register_cb(dpaa_free_mbuf);

	if (dpaa_drv->drv_flags & RTE_DPAA_DRV_INTR_LSC)
		eth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC;

	/* Invoke PMD device initialization function */
	diag = dpaa_dev_init(eth_dev);
	if (diag == 0) {
		if (!dpaa_tx_sg_pool) {
			dpaa_tx_sg_pool =
				rte_pktmbuf_pool_create("dpaa_mbuf_tx_sg_pool",
				DPAA_POOL_SIZE,
				DPAA_POOL_CACHE_SIZE, 0,
				DPAA_MAX_SGS * sizeof(struct qm_sg_entry),
				rte_socket_id());
			if (dpaa_tx_sg_pool == NULL) {
				DPAA_PMD_ERR("SG pool creation failed");
				return -ENOMEM;
			}
		}
		rte_eth_dev_probing_finish(eth_dev);
		dpaa_valid_dev++;
		return 0;
	}

	rte_eth_dev_release_port(eth_dev);
	return diag;
}

/* Adding destructor for double check in case non-gracefully
 * exit.
 */
RTE_FINI_PRIO(dpaa_finish, 103)
{
	struct dpaa_if *dpaa_intf;
	int loop;
	struct qman_fq *fq;
	uint16_t portid;
	struct rte_eth_dev *dev;

	PMD_INIT_FUNC_TRACE();
	/* For secondary, primary will do all the cleanup */
	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
		return;

	if (!is_global_init)
		return;

	if (!(default_q || fmc_q)) {
			if (dpaa_fm_term())
				DPAA_PMD_WARN("DPAA FM term failed");

		DPAA_PMD_INFO("DPAA fman cleaned up");
	}

	RTE_ETH_FOREACH_DEV(portid) {
		dev = &rte_eth_devices[portid];
		if (strcmp(dev->device->driver->name,
			rte_dpaa_pmd.driver.name))
			continue;
		dpaa_intf = dev->data->dev_private;
		/* Freeing queue specific portals */
		for (loop = 0; loop < dpaa_intf->nb_rx_queues; loop++) {
			if (!dpaa_intf->rx_queues)
				break;

			fq = &dpaa_intf->rx_queues[loop];
			if (fq->qp_initialized) {
				rte_dpaa_portal_fq_close(fq);
				fq->qp_initialized = 0;
			}
		}
	}
	is_global_init = 0;
}

static int
rte_dpaa_remove(struct rte_dpaa_device *dpaa_dev)
{
	struct rte_eth_dev *eth_dev;
	int ret = 0;

	PMD_INIT_FUNC_TRACE();

	eth_dev = rte_eth_dev_allocated(dpaa_dev->device.name);
	ret = dpaa_eth_dev_close(eth_dev);
	if (eth_dev->state !=  RTE_ETH_DEV_UNUSED) {
		dpaa_eth_dev_close(eth_dev);
		ret = rte_eth_dev_release_port(eth_dev);
	}
	dpaa_valid_dev--;
	if (!dpaa_valid_dev)
		rte_mempool_free(dpaa_tx_sg_pool);

	return ret;
}

static struct rte_dpaa_driver rte_dpaa_pmd = {
	.drv_flags = RTE_DPAA_DRV_INTR_LSC,
	.drv_type = FSL_DPAA_ETH,
	.probe = rte_dpaa_probe,
	.remove = rte_dpaa_remove,
};

RTE_PMD_REGISTER_DPAA(net_dpaa, rte_dpaa_pmd);
RTE_PMD_REGISTER_PARAM_STRING(net_dpaa,
		DRIVER_RECV_ERR_PKTS "=<int>");
RTE_LOG_REGISTER_DEFAULT(dpaa_logtype_pmd, NOTICE);