src/sysupdate/sysupdate-feature.c - main - niceSOFT/systemd

src/sysupdate/sysupdate-feature.c
124 строки5 KB
Lennart Poettering
sysupdate: validate feature name syntax before using it
13 июл 2026, 18:36
13 июл 2026, 18:369f3b604
/* SPDX-License-Identifier: LGPL-2.1-or-later */

#include <unistd.h>

#include "alloc-util.h"
#include "condition.h"
#include "conf-parser.h"
#include "hash-funcs.h"
#include "path-util.h"
#include "string-util.h"
#include "sysupdate-config.h"
#include "sysupdate-feature.h"
#include "sysupdate-util.h"

static Feature *feature_free(Feature *f) {
        if (!f)
                return NULL;

        free(f->id);

        free(f->description);
        free(f->documentation);
        free(f->appstream);

        condition_free_list(f->suggest_on);

        return mfree(f);
}

Feature *feature_new(void) {
        Feature *f;

        f = new(Feature, 1);
        if (!f)
                return NULL;

        *f = (Feature) {
                .n_ref = 1,
                .suggest = -1,
        };

        return f;
}

DEFINE_TRIVIAL_REF_UNREF_FUNC(Feature, feature, feature_free);

DEFINE_HASH_OPS_WITH_VALUE_DESTRUCTOR(feature_hash_ops,
                                      char, string_hash_func, string_compare_func,
                                      Feature, feature_unref);

int feature_read_definition(Feature *f, const char *root, const char *path, const char *const *dirs) {
        int r;

        assert(f);
        assert(path);
        assert(dirs);

        _cleanup_free_ char *filename = NULL;
        r = path_extract_filename(path, &filename);
        if (r < 0)
                return log_error_errno(r, "Failed to extract filename from path '%s': %m", path);

        char *e = endswith(filename, ".feature");
        if (!e)
                return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "Feature file has bad suffix: %s", filename);

        _cleanup_free_ char *id = strndup(filename, e - filename);
        if (!id)
                return log_oom();

        if (!feature_name_valid(id))
                return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "Malformed feature filename '%s': %m", filename);

        ConfigTableItem table[] = {
                { "Feature", "Description",                config_parse_string,         0,                             &f->description   },
                { "Feature", "Documentation",              config_parse_url_specifiers, 0,                             &f->documentation },
                { "Feature", "AppStream",                  config_parse_url_specifiers, 0,                             &f->appstream     },
                { "Feature", "Enabled",                    config_parse_bool,           0,                             &f->enabled       },
                { "Feature", "Suggest",                    config_parse_tristate,       0,                             &f->suggest       },
                { "Feature", "SuggestOnArchitecture",      config_parse_condition,      CONDITION_ARCHITECTURE,        &f->suggest_on    },
                { "Feature", "SuggestOnFirmware",          config_parse_condition,      CONDITION_FIRMWARE,            &f->suggest_on    },
                { "Feature", "SuggestOnVirtualization",    config_parse_condition,      CONDITION_VIRTUALIZATION,      &f->suggest_on    },
                { "Feature", "SuggestOnHost",              config_parse_condition,      CONDITION_HOST,                &f->suggest_on    },
                { "Feature", "SuggestOnFraction",          config_parse_condition,      CONDITION_FRACTION,            &f->suggest_on    },
                { "Feature", "SuggestOnKernelCommandLine", config_parse_condition,      CONDITION_KERNEL_COMMAND_LINE, &f->suggest_on    },
                { "Feature", "SuggestOnVersion",           config_parse_condition,      CONDITION_VERSION,             &f->suggest_on    },
                { "Feature", "SuggestOnCredential",        config_parse_condition,      CONDITION_CREDENTIAL,          &f->suggest_on    },
                { "Feature", "SuggestOnSecurity",          config_parse_condition,      CONDITION_SECURITY,            &f->suggest_on    },
                { "Feature", "SuggestOnOSRelease",         config_parse_condition,      CONDITION_OS_RELEASE,          &f->suggest_on    },
                { "Feature", "SuggestOnMachineTag",        config_parse_condition,      CONDITION_MACHINE_TAG,         &f->suggest_on    },
                {}
        };

        r = config_parse_many_full(
                        STRV_MAKE_CONST(path),
                        dirs,
                        strjoina(filename, ".d"),
                        root,
                        /* root_fd= */ -EBADF,
                        "Feature\0",
                        config_item_table_lookup, table,
                        CONFIG_PARSE_WARN,
                        (void *) root,
                        /* ret_stats_by_path= */ NULL,
                        /* ret_drop_in_files= */ NULL);
        if (r < 0)
                return r;

        f->id = TAKE_PTR(id);

        return 0;
}

int feature_is_suggested(Feature *f) {
        assert(f);

        if (f->suggest >= 0)
                return f->suggest;

        if (!f->suggest_on) /* no condition → false */
                return false;

        return condition_test_list(f->suggest_on, environ, suggest_on_type_to_string, /* logger= */ NULL, /* userdata= */ NULL);
}