src/python/updatereference-py.c - master - niceSOFT/createrepo_c

src/python/updatereference-py.c
209 строк6 KB
Daniel Alley
Add NULL checks after PyObject_CallObject in Object_From* functions
14 май 2026, 08:24
14 май 2026, 08:24cd1b62f
/* createrepo_c - Library of routines for manipulation with repodata
 * Copyright (C) 2013  Tomas Mlcoch
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301,
 * USA.
 */

#include <Python.h>
#include <assert.h>
#include <stddef.h>

#include "updatereference-py.h"
#include "exception-py.h"
#include "typeconversion.h"
#include "contentstat-py.h"

typedef struct {
    PyObject_HEAD
    cr_UpdateReference *reference;
} _UpdateReferenceObject;

PyObject *
Object_FromUpdateReference(cr_UpdateReference *ref)
{
    PyObject *py_rec;

    if (!ref) {
        PyErr_SetString(PyExc_ValueError, "Expected a cr_UpdateReference pointer not NULL.");
        return NULL;
    }

    py_rec = PyObject_CallObject((PyObject *) &UpdateReference_Type, NULL);
    if (!py_rec)
        return NULL;
    cr_updatereference_free(((_UpdateReferenceObject *)py_rec)->reference);
    ((_UpdateReferenceObject *)py_rec)->reference = ref;

    return py_rec;
}

cr_UpdateReference *
UpdateReference_FromPyObject(PyObject *o)
{
    if (!UpdateReferenceObject_Check(o)) {
        PyErr_SetString(PyExc_TypeError, "Expected a UpdateReference object.");
        return NULL;
    }
    return ((_UpdateReferenceObject *)o)->reference;
}

static int
check_UpdateReferenceStatus(const _UpdateReferenceObject *self)
{
    assert(self != NULL);
    assert(UpdateReferenceObject_Check(self));
    if (self->reference == NULL) {
        PyErr_SetString(CrErr_Exception, "Improper createrepo_c UpdateReference object.");
        return -1;
    }
    return 0;
}

/* Function on the type */

static PyObject *
updatereference_new(PyTypeObject *type,
                    G_GNUC_UNUSED PyObject *args,
                    G_GNUC_UNUSED PyObject *kwds)
{
    _UpdateReferenceObject *self = (_UpdateReferenceObject *)type->tp_alloc(type, 0);
    if (self) {
        self->reference = NULL;
    }
    return (PyObject *)self;
}

PyDoc_STRVAR(updatereference_init__doc__,
".. method:: __init__()\n\n");

static int
updatereference_init(_UpdateReferenceObject *self,
                     G_GNUC_UNUSED PyObject *args,
                     G_GNUC_UNUSED PyObject *kwds)
{
    /* Free all previous resources when reinitialization */
    if (self->reference)
        cr_updatereference_free(self->reference);

    /* Init */
    self->reference = cr_updatereference_new();
    if (self->reference == NULL) {
        PyErr_SetString(CrErr_Exception, "UpdateReference initialization failed");
        return -1;
    }

    return 0;
}

static void
updatereference_dealloc(_UpdateReferenceObject *self)
{
    if (self->reference)
        cr_updatereference_free(self->reference);
    freefunc free_func = PyType_GetSlot(Py_TYPE(self), Py_tp_free);
    free_func(self);
}

static PyObject *
updatereference_repr(G_GNUC_UNUSED _UpdateReferenceObject *self)
{
    if (self->reference->type)
        return PyUnicode_FromFormat("<createrepo_c.UpdateReference %s object>",
                                   self->reference->type);
    else
        return PyUnicode_FromFormat("<createrepo_c.UpdateReference object>");
}

/* UpdateReference methods */

PyDoc_STRVAR(copy__doc__,
"copy() -> UpdateReference\n\n"
"Return copy of the UpdateReference object");

static PyObject *
copy_updatereference(_UpdateReferenceObject *self, G_GNUC_UNUSED void *nothing)
{
    if (check_UpdateReferenceStatus(self))
        return NULL;
    return Object_FromUpdateReference(cr_updatereference_copy(self->reference));
}

static struct PyMethodDef updatereference_methods[] = {
    {"copy", (PyCFunction)copy_updatereference, METH_NOARGS,
        copy__doc__},
    {NULL, NULL, 0, NULL} /* sentinel */
};

/* getsetters */

#define OFFSET(member) (void *) offsetof(cr_UpdateReference, member)

static PyObject *
get_str(_UpdateReferenceObject *self, void *member_offset)
{
    if (check_UpdateReferenceStatus(self))
        return NULL;
    cr_UpdateReference *ref = self->reference;
    char *str = *((char **) ((size_t) ref + (size_t) member_offset));
    if (str == NULL)
        Py_RETURN_NONE;
    return PyUnicode_FromString(str);
}

static int
set_str(_UpdateReferenceObject *self, PyObject *value, void *member_offset)
{
    if (check_UpdateReferenceStatus(self))
        return -1;
    if (!PyUnicode_Check(value) && !PyBytes_Check(value) && value != Py_None) {
        PyErr_SetString(PyExc_TypeError, "Unicode, bytes, or None expected!");
        return -1;
    }

    cr_UpdateReference *ref = self->reference;
    char *str = PyObject_ToChunkedString(value, ref->chunk);
    *((char **) ((size_t) ref + (size_t) member_offset)) = str;
    return 0;
}

static PyGetSetDef updatereference_getsetters[] = {
    {"href",            (getter)get_str, (setter)set_str,
        "Reference URL",OFFSET(href)},
    {"id",              (getter)get_str, (setter)set_str,
        "ID",           OFFSET(id)},
    {"type",            (getter)get_str, (setter)set_str,
        "Type",         OFFSET(type)},
    {"title",           (getter)get_str, (setter)set_str,
        "Title",        OFFSET(title)},
    {NULL, NULL, NULL, NULL, NULL} /* sentinel */
};

/* Object */

PyTypeObject UpdateReference_Type = {
    PyVarObject_HEAD_INIT(NULL, 0)
    .tp_name = "createrepo_c.UpdateReference",
    .tp_basicsize = sizeof(_UpdateReferenceObject),
    .tp_dealloc = (destructor) updatereference_dealloc,
    .tp_repr = (reprfunc) updatereference_repr,
    .tp_flags = Py_TPFLAGS_DEFAULT|Py_TPFLAGS_BASETYPE,
    .tp_doc = updatereference_init__doc__,
    .tp_iter = PyObject_SelfIter,
    .tp_methods = updatereference_methods,
    .tp_getset = updatereference_getsetters,
    .tp_init = (initproc) updatereference_init,
    .tp_new = updatereference_new,
};