web/tests/settings_data.test.cjs - main - githubmirror/zulip

web/tests/settings_data.test.cjs
798 строк26 KB
Sahil Batra
settings_data: Handle EVERYONE_ON_INTERNET in permission checks.
18 апр 2026, 02:48
18 апр 2026, 02:48b4e14d6
"use strict";

const assert = require("node:assert/strict");

const {make_user_group} = require("./lib/example_group.cjs");
const {make_realm} = require("./lib/example_realm.cjs");
const {mock_esm, with_overrides, zrequire} = require("./lib/namespace.cjs");
const {run_test} = require("./lib/test.cjs");
const {page_params} = require("./lib/zpage_params.cjs");

const settings_data = zrequire("settings_data");
const settings_config = zrequire("settings_config");
const {set_current_user, set_realm} = zrequire("state_data");
const user_groups = zrequire("user_groups");
const {initialize_user_settings} = zrequire("user_settings");

const current_user = {};
set_current_user(current_user);
const realm = make_realm();
set_realm(realm);
const user_settings = {};
initialize_user_settings({user_settings});

/*
    Some methods in settings_data are fairly
    trivial, so the meaningful tests happen
    at the higher layers, such as when we
    test people.js.
*/

const admins = make_user_group({
    description: "Administrators",
    name: "role:administrators",
    id: 1,
    members: new Set([1]),
    is_system_group: true,
    direct_subgroup_ids: new Set(),
    can_add_members_group: 4,
    can_join_group: 4,
    can_manage_group: 4,
    can_mention_group: 1,
    can_remove_members_group: 4,
    deactivated: false,
});
const moderators = make_user_group({
    description: "Moderators",
    name: "role:moderators",
    id: 2,
    members: new Set([2]),
    is_system_group: true,
    direct_subgroup_ids: new Set([1]),
    can_add_members_group: 4,
    can_join_group: 4,
    can_leave_group: 4,
    can_manage_group: 4,
    can_mention_group: 1,
    can_remove_members_group: 4,
    deactivated: false,
});
const members = make_user_group({
    description: "Members",
    name: "role:members",
    id: 3,
    members: new Set([3, 4]),
    is_system_group: true,
    direct_subgroup_ids: new Set([1, 2]),
    can_add_members_group: 4,
    can_join_group: 4,
    can_leave_group: 4,
    can_manage_group: 4,
    can_mention_group: 4,
    can_remove_members_group: 4,
    deactivated: false,
});
const nobody = make_user_group({
    description: "Nobody",
    name: "role:nobody",
    id: 4,
    members: new Set(),
    is_system_group: true,
    direct_subgroup_ids: new Set(),
    can_add_members_group: 4,
    can_join_group: 4,
    can_leave_group: 4,
    can_manage_group: 4,
    can_mention_group: 2,
    can_remove_members_group: 4,
    deactivated: false,
});
const students = make_user_group({
    description: "Students group",
    name: "Students",
    id: 5,
    members: new Set([1, 2]),
    is_system_group: false,
    direct_subgroup_ids: new Set([4, 5]),
    can_add_members_group: 1,
    can_join_group: 1,
    can_leave_group: 1,
    can_manage_group: {
        direct_members: [4],
        direct_subgroups: [],
    },
    can_mention_group: 3,
    can_remove_members_group: 1,
    creator_id: 4,
    deactivated: false,
});
const deactivated_group = make_user_group({
    name: "Deactivated test group",
    id: 3,
    members: new Set([1, 2, 3]),
    is_system_group: false,
    direct_subgroup_ids: new Set([4, 5, 6]),
    can_add_members_group: 4,
    can_remove_members_group: 4,
    can_join_group: 1,
    can_leave_group: 1,
    can_manage_group: 1,
    can_mention_group: 1,
    deactivated: true,
});

const group_permission_settings = mock_esm("../src/group_permission_settings", {});

run_test("user_can_change_email", ({override}) => {
    const can_change_email = settings_data.user_can_change_email;

    override(current_user, "is_admin", true);
    assert.equal(can_change_email(), true);

    override(current_user, "is_admin", false);
    override(realm, "realm_email_changes_disabled", true);
    assert.equal(can_change_email(), false);

    override(realm, "realm_email_changes_disabled", false);
    assert.equal(can_change_email(), true);
});

run_test("user_can_change_name", ({override}) => {
    const can_change_name = settings_data.user_can_change_name;

    override(current_user, "is_admin", true);
    assert.equal(can_change_name(), true);

    override(current_user, "is_admin", false);
    override(realm, "realm_name_changes_disabled", true);
    override(realm, "server_name_changes_disabled", false);
    assert.equal(can_change_name(), false);

    override(realm, "realm_name_changes_disabled", false);
    override(realm, "server_name_changes_disabled", false);
    assert.equal(can_change_name(), true);

    override(realm, "realm_name_changes_disabled", false);
    override(realm, "server_name_changes_disabled", true);
    assert.equal(can_change_name(), false);
});

run_test("user_can_change_avatar", ({override}) => {
    const can_change_avatar = settings_data.user_can_change_avatar;

    override(current_user, "is_admin", true);
    assert.equal(can_change_avatar(), true);

    override(current_user, "is_admin", false);
    override(realm, "realm_avatar_changes_disabled", true);
    override(realm, "server_avatar_changes_disabled", false);
    assert.equal(can_change_avatar(), false);

    override(realm, "realm_avatar_changes_disabled", false);
    override(realm, "server_avatar_changes_disabled", false);
    assert.equal(can_change_avatar(), true);

    override(realm, "realm_avatar_changes_disabled", false);
    override(realm, "server_avatar_changes_disabled", true);
    assert.equal(can_change_avatar(), false);
});

run_test("user_can_change_logo", ({override}) => {
    const can_change_logo = settings_data.user_can_change_logo;

    override(current_user, "is_admin", true);
    override(realm, "zulip_plan_is_not_limited", true);
    assert.equal(can_change_logo(), true);

    override(current_user, "is_admin", false);
    override(realm, "zulip_plan_is_not_limited", false);
    assert.equal(can_change_logo(), false);

    override(current_user, "is_admin", true);
    override(realm, "zulip_plan_is_not_limited", false);
    assert.equal(can_change_logo(), false);

    override(current_user, "is_admin", false);
    override(realm, "zulip_plan_is_not_limited", true);
    assert.equal(can_change_logo(), false);
});

test_realm_group_settings(
    "realm_can_add_custom_emoji_group",
    settings_data.user_can_add_custom_emoji,
);

test_realm_group_settings(
    "realm_can_add_subscribers_group",
    settings_data.can_subscribe_others_to_all_accessible_streams,
);

test_realm_group_settings(
    "realm_can_delete_any_message_group",
    settings_data.user_can_delete_any_message,
);

test_realm_group_settings(
    "realm_can_delete_own_message_group",
    settings_data.user_can_delete_own_message,
);

test_realm_group_settings(
    "realm_can_invite_users_group",
    settings_data.user_can_invite_users_by_email,
);

test_realm_group_settings("realm_can_manage_billing_group", settings_data.user_has_billing_access);

test_realm_group_settings(
    "realm_can_move_messages_between_channels_group",
    settings_data.user_can_move_messages_between_streams,
);

test_realm_group_settings(
    "realm_can_move_messages_between_topics_group",
    settings_data.user_can_move_messages_to_another_topic,
);

test_realm_group_settings("realm_can_resolve_topics_group", settings_data.user_can_resolve_topic);

run_test("using_dark_theme", ({override}) => {
    override(user_settings, "color_scheme", settings_config.color_scheme_values.dark.code);
    assert.equal(settings_data.using_dark_theme(), true);

    override(user_settings, "color_scheme", settings_config.color_scheme_values.automatic.code);

    window.matchMedia = (query) => {
        assert.equal(query, "(prefers-color-scheme: dark)");
        return {matches: true};
    };
    assert.equal(settings_data.using_dark_theme(), true);

    window.matchMedia = (query) => {
        assert.equal(query, "(prefers-color-scheme: dark)");
        return {matches: false};
    };
    assert.equal(settings_data.using_dark_theme(), false);

    override(user_settings, "color_scheme", settings_config.color_scheme_values.light.code);
    assert.equal(settings_data.using_dark_theme(), false);
});

run_test("user_email_not_configured", ({override}) => {
    const user_email_not_configured = settings_data.user_email_not_configured;

    override(current_user, "is_owner", false);
    assert.equal(user_email_not_configured(), false);

    override(current_user, "is_owner", true);
    override(current_user, "delivery_email", "");
    assert.equal(user_email_not_configured(), true);

    override(current_user, "delivery_email", "name@example.com");
    assert.equal(user_email_not_configured(), false);
});

function test_realm_group_settings(setting_name, validation_func) {
    with_overrides(({override}) => {
        const admin_user_id = 1;
        const moderator_user_id = 2;
        const member_user_id = 3;

        const admins = make_user_group({
            name: "Admins",
            id: 1,
            members: new Set([admin_user_id]),
            is_system_group: true,
            direct_subgroup_ids: new Set(),
        });
        const moderators = make_user_group({
            name: "Moderators",
            id: 2,
            members: new Set([moderator_user_id]),
            is_system_group: true,
            direct_subgroup_ids: new Set([1]),
        });

        group_permission_settings.get_group_permission_setting_config = () => ({
            allow_everyone_group: false,
        });

        user_groups.initialize({realm_user_groups: [admins, moderators]});
        page_params.is_spectator = true;
        assert.equal(validation_func(), false);

        page_params.is_spectator = false;
        override(current_user, "is_guest", false);
        override(realm, setting_name, 1);
        override(current_user, "user_id", admin_user_id);
        assert.equal(validation_func(), true);

        override(current_user, "user_id", moderator_user_id);
        assert.equal(validation_func(), false);

        override(realm, setting_name, 2);
        override(current_user, "user_id", moderator_user_id);
        assert.equal(validation_func(), true);

        override(current_user, "user_id", member_user_id);
        assert.equal(validation_func(), false);

        override(current_user, "user_id", moderator_user_id);
        override(current_user, "is_guest", true);
        assert.equal(validation_func(), false);

        group_permission_settings.get_group_permission_setting_config = () => ({
            allow_everyone_group: true,
        });
        assert.equal(validation_func(), true);
    });
}

run_test("user_can_create_multiuse_invite", () => {
    test_realm_group_settings(
        "realm_create_multiuse_invite_group",
        settings_data.user_can_create_multiuse_invite,
    );
});

run_test("can_manage_user_group", ({override}) => {
    user_groups.initialize({
        realm_user_groups: [admins, moderators, members, nobody, students],
    });

    page_params.is_spectator = true;
    assert.ok(!settings_data.can_manage_user_group(students.id));

    page_params.is_spectator = false;
    override(realm, "realm_can_manage_all_groups", admins.id);
    override(current_user, "user_id", 3);
    assert.ok(!settings_data.can_manage_user_group(students.id));

    // non-admin group_creator
    override(current_user, "user_id", 4);
    assert.ok(settings_data.can_manage_user_group(students.id));

    // admin user
    override(current_user, "user_id", 1);
    assert.ok(settings_data.can_manage_user_group(students.id));

    // moderator user
    override(current_user, "user_id", 2);
    assert.ok(!settings_data.can_manage_user_group(students.id));

    // User with role member and not part of the group.
    override(realm, "realm_can_manage_all_groups", members.id);
    override(current_user, "user_id", 3);
    assert.ok(settings_data.can_manage_user_group(students.id));

    // User with role member and part of the group.
    override(current_user, "user_id", 2);
    assert.ok(settings_data.can_manage_user_group(students.id));

    override(realm, "realm_can_manage_all_groups", admins.id);
    override(current_user, "user_id", 2);
    assert.ok(!settings_data.can_manage_user_group(students.id));

    const event = {
        group_id: students.id,
        data: {
            can_manage_group: members.id,
        },
    };
    const students_group = user_groups.get_user_group_from_id(students.id);
    user_groups.update(event, students_group);
    assert.ok(settings_data.can_manage_user_group(students.id));

    override(current_user, "user_id", 3);
    assert.ok(settings_data.can_manage_user_group(students.id));
});

function test_user_group_permission_setting(override, setting_name, permission_func) {
    user_groups.initialize({
        realm_user_groups: [admins, moderators, members, nobody, students, deactivated_group],
    });
    override(realm, "realm_can_manage_all_groups", nobody.id);

    page_params.is_spectator = true;
    assert.ok(!permission_func(students.id));

    page_params.is_spectator = false;
    // admin user
    override(current_user, "user_id", 1);
    assert.ok(permission_func(students.id));

    // moderator user
    override(current_user, "user_id", 2);
    assert.ok(!permission_func(students.id));

    const event = {
        group_id: students.id,
        data: {},
    };
    const students_group = user_groups.get_user_group_from_id(students.id);
    event.data[setting_name] = moderators.id;
    user_groups.update(event, students_group);
    assert.ok(permission_func(students.id));

    override(current_user, "user_id", 1);
    assert.ok(permission_func(students.id));

    // Some other user.
    override(current_user, "user_id", 5);
    assert.ok(!permission_func(students.id));

    event.data[setting_name] = {
        direct_members: [5],
        direct_subgroups: [admins.id],
    };
    user_groups.update(event, students_group);
    assert.ok(permission_func(students.id));

    override(current_user, "user_id", 2);
    assert.ok(!permission_func(students.id));

    // User can join the group if they can manage the group which depends
    // on can_manage_group and realm.can_manage_all_groups settings.
    override(current_user, "user_id", 4);
    assert.ok(permission_func(students.id));

    override(realm, "realm_can_manage_all_groups", moderators.id);
    override(current_user, "user_id", 2);
    assert.ok(permission_func(students.id));

    // Can perform any join, leave, add, remove even if the group is deactivated
    assert.ok(permission_func(deactivated_group.id));
}

run_test("can_join_user_group", ({override}) => {
    test_user_group_permission_setting(
        override,
        "can_join_group",
        settings_data.can_join_user_group,
    );

    // User can join the group if they have permission to add others
    // in the group.
    override(realm, "realm_can_manage_all_groups", nobody.id);
    const event = {
        group_id: students.id,
        data: {
            can_manage_group: nobody.id,
            can_join_group: nobody.id,
            can_add_members_group: {
                direct_members: [5],
                direct_subgroups: [admins.id],
            },
        },
    };
    const students_group = user_groups.get_user_group_from_id(students.id);
    user_groups.update(event, students_group);

    override(current_user, "user_id", 2);
    assert.ok(!settings_data.can_join_user_group(students.id));

    override(current_user, "user_id", 5);
    assert.ok(settings_data.can_join_user_group(students.id));

    override(current_user, "user_id", 1);
    assert.ok(settings_data.can_join_user_group(students.id));
});

run_test("can_leave_user_group", ({override}) => {
    test_user_group_permission_setting(
        override,
        "can_leave_group",
        settings_data.can_leave_user_group,
    );

    // User can leave the group if they have permission to remove
    // others from the group.
    override(realm, "realm_can_manage_all_groups", nobody.id);
    const event = {
        group_id: students.id,
        data: {
            can_manage_group: nobody.id,
            can_leave_group: nobody.id,
            can_remove_members_group: {
                direct_members: [5],
                direct_subgroups: [admins.id],
            },
        },
    };
    const students_group = user_groups.get_user_group_from_id(students.id);
    user_groups.update(event, students_group);

    override(current_user, "user_id", 2);
    assert.ok(!settings_data.can_leave_user_group(students.id));

    override(current_user, "user_id", 5);
    assert.ok(settings_data.can_leave_user_group(students.id));

    override(current_user, "user_id", 1);
    assert.ok(settings_data.can_leave_user_group(students.id));
});

run_test("can_add_members_user_group", ({override}) => {
    test_user_group_permission_setting(
        override,
        "can_add_members_group",
        settings_data.can_add_members_to_user_group,
    );
});

run_test("can_remove_members_user_group", ({override}) => {
    test_user_group_permission_setting(
        override,
        "can_remove_members_group",
        settings_data.can_remove_members_from_user_group,
    );
});

run_test("type_id_to_string", () => {
    assert.equal(settings_data.bot_type_id_to_string(1), "translated: Generic bot");
    assert.equal(settings_data.bot_type_id_to_string(2), "translated: Incoming webhook");
    assert.equal(settings_data.bot_type_id_to_string(5), undefined);
});

run_test("user_can_access_all_other_users", ({override}) => {
    const guest_user_id = 1;
    const member_user_id = 2;

    const members = make_user_group({
        name: "role:members",
        id: 1,
        members: new Set([member_user_id]),
        is_system_group: true,
        direct_subgroup_ids: new Set(),
    });
    const everyone = make_user_group({
        name: "role:everyone",
        id: 2,
        members: new Set([guest_user_id]),
        is_system_group: true,
        direct_subgroup_ids: new Set([1]),
    });

    user_groups.initialize({realm_user_groups: [members, everyone]});
    override(realm, "realm_can_access_all_users_group", members.id);

    // Test spectators case.
    page_params.is_spectator = true;
    assert.ok(settings_data.user_can_access_all_other_users());

    page_params.is_spectator = false;
    override(current_user, "user_id", member_user_id);
    override(current_user, "is_guest", false);
    assert.ok(settings_data.user_can_access_all_other_users());
    override(current_user, "is_guest", true);
    // For coverage only: Here the is_guest optimization is skipped.
    assert.ok(settings_data.user_can_access_all_other_users());

    override(current_user, "user_id", guest_user_id);
    assert.ok(!settings_data.user_can_access_all_other_users());

    override(realm, "realm_can_access_all_users_group", everyone.id);
    assert.ok(settings_data.user_can_access_all_other_users());
});

run_test("user_can_create_public_streams", () => {
    test_realm_group_settings(
        "realm_can_create_public_channel_group",
        settings_data.user_can_create_public_streams,
    );
});

run_test("user_can_create_user_groups", () => {
    test_realm_group_settings("realm_can_create_groups", settings_data.user_can_create_user_groups);
});

run_test("user_can_manage_all_groups", () => {
    test_realm_group_settings(
        "realm_can_manage_all_groups",
        settings_data.user_can_manage_all_groups,
    );
});

run_test("user_can_create_private_streams", () => {
    test_realm_group_settings(
        "realm_can_create_private_channel_group",
        settings_data.user_can_create_private_streams,
    );
});

run_test("user_can_create_web_public_streams", ({override}) => {
    override(realm, "server_web_public_streams_enabled", true);
    override(realm, "realm_enable_spectator_access", true);

    test_realm_group_settings(
        "realm_can_create_web_public_channel_group",
        settings_data.user_can_create_web_public_streams,
    );
    const owner_user_id = 4;
    const owners = make_user_group({
        name: "Admins",
        id: 3,
        members: new Set([owner_user_id]),
        is_system_group: true,
        direct_subgroup_ids: new Set(),
    });
    override(current_user, "user_id", owner_user_id);
    user_groups.initialize({realm_user_groups: [owners]});

    override(realm, "server_web_public_streams_enabled", true);
    override(realm, "realm_enable_spectator_access", true);
    override(realm, "realm_can_create_web_public_channel_group", owners.id);
    assert.equal(settings_data.user_can_create_web_public_streams(), true);

    override(realm, "realm_enable_spectator_access", false);
    override(realm, "server_web_public_streams_enabled", true);
    assert.equal(settings_data.user_can_create_web_public_streams(), false);

    override(realm, "realm_enable_spectator_access", true);
    override(realm, "server_web_public_streams_enabled", false);
    assert.equal(settings_data.user_can_create_web_public_streams(), false);

    override(realm, "realm_enable_spectator_access", false);
    override(realm, "server_web_public_streams_enabled", false);
    assert.equal(settings_data.user_can_create_web_public_streams(), false);
});

run_test("guests_can_access_all_other_users", () => {
    const guest_user_id = 1;
    const member_user_id = 2;

    const members = make_user_group({
        name: "role:members",
        id: 1,
        members: new Set([member_user_id]),
        is_system_group: true,
        direct_subgroup_ids: new Set(),
    });
    const everyone = make_user_group({
        name: "role:everyone",
        id: 2,
        members: new Set([guest_user_id]),
        is_system_group: true,
        direct_subgroup_ids: new Set([1]),
    });

    user_groups.initialize({realm_user_groups: [members]});
    realm.realm_can_access_all_users_group = members.id;
    assert.ok(!settings_data.guests_can_access_all_other_users());

    user_groups.initialize({realm_user_groups: [members, everyone]});
    realm.realm_can_access_all_users_group = everyone.id;
    assert.ok(settings_data.guests_can_access_all_other_users());
});

run_test("user_can_summarize_topics", ({override}) => {
    override(realm, "server_can_summarize_topics", true);
    test_realm_group_settings(
        "realm_can_summarize_topics_group",
        settings_data.user_can_summarize_topics,
    );

    override(realm, "server_can_summarize_topics", false);
    assert.ok(!settings_data.user_can_summarize_topics());
});

run_test("should_mask_unread_count", ({override}) => {
    override(user_settings, "web_stream_unreads_count_display_policy", 3);
    let sub_muted = false;
    let unmuted_unread_count = 0;
    assert.equal(settings_data.should_mask_unread_count(sub_muted, unmuted_unread_count), true);

    override(user_settings, "web_stream_unreads_count_display_policy", 2);
    assert.equal(settings_data.should_mask_unread_count(sub_muted, unmuted_unread_count), false);

    sub_muted = true;
    assert.equal(settings_data.should_mask_unread_count(sub_muted, unmuted_unread_count), true);

    unmuted_unread_count = 2;
    assert.equal(settings_data.should_mask_unread_count(sub_muted, unmuted_unread_count), false);

    override(user_settings, "web_stream_unreads_count_display_policy", 1);
    assert.equal(settings_data.should_mask_unread_count(sub_muted, unmuted_unread_count), false);
});

run_test("can_user_manage_folder", ({override}) => {
    override(current_user, "is_admin", false);
    assert.equal(settings_data.can_user_manage_folder(), false);

    override(current_user, "is_admin", true);
    assert.equal(settings_data.can_user_manage_folder(), true);
});

run_test("two_tier_billing_enabled", ({override}) => {
    const members = make_user_group({
        name: "role:members",
        id: 1,
        members: new Set([1]),
        is_system_group: true,
        direct_subgroup_ids: new Set(),
    });
    const everyone = make_user_group({
        name: "role:everyone",
        id: 2,
        members: new Set([2]),
        is_system_group: true,
        direct_subgroup_ids: new Set([1]),
    });

    user_groups.initialize({realm_user_groups: [members, everyone]});

    override(realm, "realm_workplace_users_group", members.id);
    assert.equal(settings_data.two_tier_billing_enabled(), true);

    override(realm, "realm_workplace_users_group", everyone.id);
    assert.equal(settings_data.two_tier_billing_enabled(), false);

    override(realm, "realm_workplace_users_group", {
        direct_members: [1],
        direct_subgroups: [members.id, everyone.id],
    });
    assert.equal(settings_data.two_tier_billing_enabled(), true);
});

run_test("user_has_permission_for_group_setting_internet_group", ({override}) => {
    // We do not have any setting with allow_internet_group as true currently,
    // but this test is needed for coverage.
    const member_user_id = 3;

    const internet_group = make_user_group({
        description: "Everyone on the internet",
        name: "role:internet",
        id: 10,
        members: new Set(),
        is_system_group: true,
        direct_subgroup_ids: new Set(),
    });

    user_groups.initialize({realm_user_groups: [admins, members, internet_group]});

    // When allow_internet_group is true and setting is the internet group,
    // all users have permission — including spectators.
    group_permission_settings.get_group_permission_setting_config = () => ({
        allow_internet_group: true,
        allow_everyone_group: true,
    });

    page_params.is_spectator = true;
    assert.equal(
        settings_data.user_has_permission_for_group_setting(
            internet_group.id,
            "can_create_public_channel_group",
            "realm",
        ),
        true,
    );

    assert.equal(
        settings_data.user_has_permission_for_group_setting(
            members.id,
            "can_create_public_channel_group",
            "realm",
        ),
        false,
    );

    page_params.is_spectator = false;
    override(current_user, "user_id", member_user_id);
    assert.equal(
        settings_data.user_has_permission_for_group_setting(
            internet_group.id,
            "can_create_public_channel_group",
            "realm",
        ),
        true,
    );

    assert.equal(
        settings_data.user_has_permission_for_group_setting(
            members.id,
            "can_create_public_channel_group",
            "realm",
        ),
        true,
    );
});