web/tests/dispatch_subs.test.cjs - main - githubmirror/zulip

web/tests/dispatch_subs.test.cjs
356 строк11 KB
Aadithya-J
events: Fix stream/delete default streams update order.
05 апр 2026, 21:00
05 апр 2026, 21:004aaa65c
"use strict";

const assert = require("node:assert/strict");

const events = require("./lib/events.cjs");
const {make_realm} = require("./lib/example_realm.cjs");
const {make_stream} = require("./lib/example_stream.cjs");
const {make_user} = require("./lib/example_user.cjs");
const {mock_esm, zrequire} = require("./lib/namespace.cjs");
const {make_stub} = require("./lib/stub.cjs");
const {run_test, noop} = require("./lib/test.cjs");
const blueslip = require("./lib/zblueslip.cjs");

const event_fixtures = events.fixtures;
const test_user = events.test_user;

const compose_recipient = mock_esm("../src/compose_recipient");
mock_esm("../src/inbox_ui", {
    complete_rerender: noop,
});
const message_events = mock_esm("../src/message_events");
const overlays = mock_esm("../src/overlays");
mock_esm("../src/recent_view_ui", {
    complete_rerender: noop,
});
const settings_org = mock_esm("../src/settings_org");
const settings_streams = mock_esm("../src/settings_streams");
const stream_events = mock_esm("../src/stream_events");
const stream_list = mock_esm("../src/stream_list");
const stream_settings_ui = mock_esm("../src/stream_settings_ui");
const unread_ops = mock_esm("../src/unread_ops");
const user_group_edit = mock_esm("../src/user_group_edit");

const compose_state = zrequire("compose_state");
const peer_data = zrequire("peer_data");
const people = zrequire("people");
const server_events_dispatch = zrequire("server_events_dispatch");
const {set_realm} = zrequire("state_data");
const stream_data = zrequire("stream_data");
const sub_store = zrequire("sub_store");

const realm = make_realm();
set_realm(realm);

people.add_active_user(test_user);

const me = make_user({
    email: "me@zulip.com",
    full_name: "Me Myself",
    user_id: 101,
});
people.add_active_user(me);
people.initialize_current_user(me.user_id);

const dispatch = server_events_dispatch.dispatch_normal_event;

function test(label, f) {
    run_test(label, (helpers) => {
        stream_data.clear_subscriptions();
        f(helpers);
    });
}

test("add", ({override}) => {
    const event = event_fixtures.subscription__add;

    const sub = event.subscriptions[0];
    const stream_id = sub.stream_id;

    stream_data.add_sub_for_tests(
        make_stream({
            stream_id,
            name: sub.name,
        }),
    );

    const subscription_stub = make_stub();
    override(stream_events, "mark_subscribed", subscription_stub.f);
    dispatch(event);
    assert.equal(subscription_stub.num_calls, 1);
    const args = subscription_stub.get_args("sub", "subscribers");
    assert.deepEqual(args.sub.stream_id, stream_id);
    assert.deepEqual(args.subscribers, event.subscriptions[0].subscribers);
});

test("peer add/remove", ({override}) => {
    let event = event_fixtures.subscription__peer_add;

    const devel_stream_id = event.stream_ids[0];
    stream_data.add_sub_for_tests(
        make_stream({
            name: "devel",
            stream_id: devel_stream_id,
        }),
    );

    const stream_stub = make_stub();
    override(stream_events, "process_subscriber_update", stream_stub.f);

    dispatch(event);
    assert.equal(stream_stub.num_calls, 1);

    assert.ok(peer_data.is_user_loaded_and_subscribed(devel_stream_id, event.user_ids[0]));

    event = event_fixtures.subscription__peer_remove;
    dispatch(event);
    assert.equal(stream_stub.num_calls, 2);

    assert.ok(!peer_data.is_user_loaded_and_subscribed(devel_stream_id, event.user_ids[0]));
});

test("remove", ({override}) => {
    const event = event_fixtures.subscription__remove;
    const event_sub = event.subscriptions[0];
    const stream_id = event_sub.stream_id;

    const sub = make_stream({
        stream_id,
        name: event_sub.name,
    });

    stream_data.add_sub_for_tests(sub);

    const stub = make_stub();
    override(stream_events, "mark_unsubscribed", stub.f);
    dispatch(event);
    assert.equal(stub.num_calls, 1);
    const args = stub.get_args("sub");
    assert.deepEqual(args.sub, sub);
});

test("update", ({override}) => {
    const event = event_fixtures.subscription__update;

    const stub = make_stub();
    override(stream_events, "update_property", stub.f);
    dispatch(event);
    assert.equal(stub.num_calls, 1);
    const args = stub.get_args("stream_id", "property", "value");
    assert.deepEqual(args.stream_id, event.stream_id);
    assert.deepEqual(args.property, event.property);
    assert.deepEqual(args.value, event.value);
});

test("add error handling", () => {
    // test blueslip errors/warns
    const event = event_fixtures.subscription__add;

    blueslip.expect("error", "Subscribing to unknown stream");
    dispatch(event);
    blueslip.reset();
});

test("peer event error handling (bad stream_ids/user_ids)", ({override}) => {
    override(stream_events, "process_subscriber_update", noop);

    const add_event = {
        type: "subscription",
        op: "peer_add",
        stream_ids: [8888, 9999],
        user_ids: [3333, 4444],
    };

    blueslip.expect("warn", "We have untracked stream_ids: 8888,9999");
    blueslip.expect("warn", "We have untracked user_ids");
    dispatch(add_event);
    blueslip.reset();

    const remove_event = {
        type: "subscription",
        op: "peer_remove",
        stream_ids: [8888, 9999],
        user_ids: [3333, 4444],
    };

    blueslip.expect("warn", "We have untracked stream_ids: 8888,9999");
    blueslip.expect("warn", "We have untracked user_ids");
    dispatch(remove_event);
});

test("stream update", ({override}) => {
    const event = event_fixtures.stream__update;

    const stub = make_stub();
    override(stream_events, "update_property", stub.f);
    override(settings_streams, "update_default_streams_table", noop);
    override(stream_list, "update_subscribe_to_more_streams_link", noop);
    dispatch(event);
    assert.equal(stub.num_calls, 1);
    const args = stub.get_args("stream_id", "property", "value");
    assert.equal(args.stream_id, event.stream_id);
    assert.equal(args.property, event.property);
    assert.equal(args.value, event.value);

    // Dispatch a stream update with property "name" to exercise
    // the complete_rerender calls for inbox and recent views.
    const name_event = {...event, property: "name", value: "new_name"};
    dispatch(name_event);
    assert.equal(stub.num_calls, 2);
});

test("stream create", ({override}) => {
    assert.equal(sub_store.get(101), undefined);
    assert.equal(sub_store.get(102), undefined);

    const event = event_fixtures.stream__create;

    override(stream_settings_ui, "add_sub_to_table", noop);
    override(stream_list, "update_subscribe_to_more_streams_link", noop);
    override(overlays, "streams_open", () => true);
    dispatch(event);

    assert.deepEqual(sub_store.get(101).name, "devel");
    assert.deepEqual(sub_store.get(102).name, "test");
});

test("stream delete (normal)", ({override, override_rewire}) => {
    const event = event_fixtures.stream__delete;

    const devel_sub = make_stream({
        stream_id: event.stream_ids[0],
        name: "devel",
        is_archived: false,
        subscribed: false,
    });

    const test_sub = make_stream({
        stream_id: event.stream_ids[1],
        name: "test",
        is_archived: false,
    });

    stream_data.add_sub_for_tests(test_sub);
    stream_data.add_sub_for_tests(devel_sub);

    override_rewire(stream_data, "set_max_channel_width_css_variable", noop);

    stream_data.subscribe_myself(devel_sub);
    stream_data.set_realm_default_streams(event.stream_ids);

    override(settings_streams, "update_default_streams_table", () => {
        for (const stream_id of event.stream_ids) {
            assert.equal(stream_data.is_default_stream_id(stream_id), false);
        }
    });

    const removed_stream_ids = [];

    override(stream_settings_ui, "remove_stream", (stream_id) => {
        removed_stream_ids.push(stream_id);
    });

    override(stream_list, "update_subscribe_to_more_streams_link", noop);

    override(unread_ops, "process_read_messages_event", noop);
    override(message_events, "remove_messages", noop);
    override(user_group_edit, "update_group_permissions_panel_on_losing_stream_access", noop);
    dispatch(event);

    assert.deepEqual(removed_stream_ids, [event.stream_ids[0], event.stream_ids[1]]);
});

test("stream delete (special streams)", ({override, override_rewire}) => {
    const event = event_fixtures.stream__delete;

    const devel_sub = make_stream({
        stream_id: event.stream_ids[0],
        name: "devel",
        is_archived: false,
    });

    const test_sub = make_stream({
        stream_id: event.stream_ids[1],
        name: "test",
        is_archived: false,
    });

    stream_data.add_sub_for_tests(devel_sub);
    stream_data.add_sub_for_tests(test_sub);

    override_rewire(stream_data, "set_max_channel_width_css_variable", noop);
    stream_data.subscribe_myself(devel_sub);

    const removed_stream_ids = [];

    override(stream_settings_ui, "remove_stream", (stream_id) => {
        removed_stream_ids.push(stream_id);
    });

    // sanity check data
    assert.equal(event.stream_ids.length, 2);
    override(realm, "realm_moderation_request_channel_id", event.stream_ids[0]);
    override(realm, "realm_new_stream_announcements_stream_id", event.stream_ids[0]);
    override(realm, "realm_signup_announcements_stream_id", event.stream_ids[1]);
    override(realm, "realm_zulip_update_announcements_stream_id", event.stream_ids[0]);

    override(settings_org, "sync_realm_settings", noop);
    override(settings_streams, "update_default_streams_table", noop);
    override(stream_list, "update_subscribe_to_more_streams_link", noop);

    override(unread_ops, "process_read_messages_event", noop);
    override(message_events, "remove_messages", noop);
    override(user_group_edit, "update_group_permissions_panel_on_losing_stream_access", noop);

    dispatch(event);

    assert.deepEqual(removed_stream_ids, [event.stream_ids[0], event.stream_ids[1]]);

    assert.equal(realm.realm_moderation_request_channel_id, event.stream_ids[0]);
    assert.equal(realm.realm_new_stream_announcements_stream_id, event.stream_ids[0]);
    assert.equal(realm.realm_signup_announcements_stream_id, event.stream_ids[1]);
    assert.equal(realm.realm_zulip_update_announcements_stream_id, event.stream_ids[0]);
});

test("stream delete (stream is selected in compose)", ({override}) => {
    override(compose_recipient, "on_compose_select_recipient_update", noop);

    const event = event_fixtures.stream__delete;

    const devel_sub = make_stream({
        stream_id: event.stream_ids[0],
        name: "devel",
        is_archived: false,
    });

    const test_sub = make_stream({
        stream_id: event.stream_ids[1],
        name: "test",
        is_archived: false,
    });

    stream_data.add_sub_for_tests(devel_sub);
    stream_data.add_sub_for_tests(test_sub);

    compose_state.set_stream_id(event.stream_ids[0]);

    const removed_stream_ids = [];

    override(stream_settings_ui, "remove_stream", (stream_id) => {
        removed_stream_ids.push(stream_id);
    });

    override(settings_streams, "update_default_streams_table", noop);

    override(stream_list, "update_subscribe_to_more_streams_link", noop);

    override(unread_ops, "process_read_messages_event", noop);
    override(message_events, "remove_messages", noop);
    override(user_group_edit, "update_group_permissions_panel_on_losing_stream_access", noop);

    dispatch(event);

    assert.deepEqual(removed_stream_ids, [event.stream_ids[0], event.stream_ids[1]]);

    assert.equal(compose_state.stream_name(), "");
});