lib/versioner/external_test.go - main - githubmirror/syncthing

lib/versioner/external_test.go
137 строк3 KB
Jakob Borg
fix(versioner): handle invalid empty command (#10836)
26 июл 2026, 21:51
26 июл 2026, 21:51733f635
// Copyright (C) 2016 The Syncthing Authors.
//
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this file,
// You can obtain one at https://mozilla.org/MPL/2.0/.

package versioner

import (
	"os"
	"path/filepath"
	"testing"

	"github.com/syncthing/syncthing/lib/build"
	"github.com/syncthing/syncthing/lib/fs"
)

func TestExternalNoCommand(t *testing.T) {
	file := "testdata/folder path/long filename.txt"
	prepForRemoval(t, file)
	defer os.RemoveAll("testdata")

	// The file should exist before the versioner run.

	if _, err := os.Lstat(file); err != nil {
		t.Fatal("File should exist")
	}

	// The versioner should fail due to missing command.

	e := external{
		filesystem: fs.NewFilesystem(fs.FilesystemTypeBasic, "."),
		command:    "nonexistent command",
	}
	if err := e.Archive(file); err == nil {
		t.Error("Command should have failed")
	}

	// The file should not have been removed.

	if _, err := os.Lstat(file); err != nil {
		t.Fatal("File should still exist")
	}
}

func TestExternal(t *testing.T) {
	cmd := "./_external_test/external.sh %FOLDER_PATH% %FILE_PATH%"
	if build.IsWindows {
		cmd = `.\\_external_test\\external.bat %FOLDER_PATH% %FILE_PATH%`
	}

	file := filepath.Join("testdata", "folder path", "dir (parens)", "/long filename (parens).txt")
	prepForRemoval(t, file)
	defer os.RemoveAll("testdata")

	// The file should exist before the versioner run.

	if _, err := os.Lstat(file); err != nil {
		t.Fatal("File should exist")
	}

	// The versioner should run successfully.

	e := external{
		filesystem: fs.NewFilesystem(fs.FilesystemTypeBasic, "."),
		command:    cmd,
	}
	if err := e.Archive(file); err != nil {
		t.Fatal(err)
	}

	// The file should no longer exist.

	if _, err := os.Lstat(file); !os.IsNotExist(err) {
		t.Error("File should no longer exist")
	}
}

func TestExternalCommandSplit(t *testing.T) {
	e := external{
		filesystem: fs.NewFilesystem(fs.FilesystemTypeFake, "TestExternalCommandSplit"),
	}

	cases := []struct {
		cmd  string
		safe bool
	}{
		{`echo %FOLDER_PATH% %FILE_PATH%`, true},
		{`echo "%FOLDER_PATH% %FILE_PATH%"`, false},
		{`echo %FOLDER_PATH%/%FILE_PATH%`, true},
		{`echo "%FOLDER_PATH%/%FILE_PATH%"`, true},
		{`echo '%FOLDER_PATH%/%FILE_PATH%'`, true},
		{`echo "'%FOLDER_PATH%/%FILE_PATH%'"`, false},
		{`sh -c "echo '%FOLDER_PATH%/%FILE_PATH%'"`, false},
		{`sh -c "echo %FOLDER_PATH%/%FILE_PATH%"`, false},
	}

	for _, tc := range cases {
		e.command = tc.cmd
		res, err := e.prepareCommand("evil file name")
		if tc.safe && err != nil {
			t.Fatal(err)
		}
		if !tc.safe && err == nil {
			t.Logf("%q", res.Path)
			t.Logf("%q", res.Args)
			t.Errorf("should be unsafe: %q", tc.cmd)
		}
	}
}

func TestExternalWhitespaceCommand(t *testing.T) {
	// A whitespace-only command splits into zero words; prepareCommand must
	// return an error rather than panicking on words[0].
	e := external{
		filesystem: fs.NewFilesystem(fs.FilesystemTypeFake, "TestExternalWhitespaceCommand"),
	}
	for _, cmd := range []string{" ", "\t", "\n", "  \t \n"} {
		e.command = cmd
		if _, err := e.prepareCommand("file"); err == nil {
			t.Errorf("expected error for command %q, got nil", cmd)
		}
	}
}

func prepForRemoval(t *testing.T, file string) {
	if err := os.RemoveAll("testdata"); err != nil {
		t.Fatal(err)
	}

	if err := os.MkdirAll(filepath.Dir(file), 0o755); err != nil {
		t.Fatal(err)
	}
	if err := os.WriteFile(file, []byte("hello\n"), 0o644); err != nil {
		t.Fatal(err)
	}
}