components/script/dom/xpath/xpathresult.rs - main - githubmirror/servo

components/script/dom/xpath/xpathresult.rs
271 строка10 KB
Gae24
script: Don't store rooted values inside `XPathResultValue` (#46690)
21 июл 2026, 19:18
21 июл 2026, 19:189bc80d2
/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at https://mozilla.org/MPL/2.0/. */

use std::cell::Cell;

use dom_struct::dom_struct;
use js::context::{JSContext, NoGC};
use script_bindings::cell::DomRefCell;
use script_bindings::codegen::GenericBindings::WindowBinding::WindowMethods;
use script_bindings::reflector::{Reflector, reflect_dom_object};

use crate::dom::bindings::codegen::Bindings::XPathResultBinding::{
    XPathResultConstants, XPathResultMethods,
};
use crate::dom::bindings::error::{Error, Fallible};
use crate::dom::bindings::inheritance::Castable;
use crate::dom::bindings::root::{Dom, DomRoot};
use crate::dom::bindings::str::DOMString;
use crate::dom::node::Node;
use crate::dom::window::Window;
use crate::xpath::Value;

#[repr(u16)]
#[derive(Clone, Copy, Debug, Eq, JSTraceable, MallocSizeOf, Ord, PartialEq, PartialOrd)]
pub(crate) enum XPathResultType {
    Any = XPathResultConstants::ANY_TYPE,
    Number = XPathResultConstants::NUMBER_TYPE,
    String = XPathResultConstants::STRING_TYPE,
    Boolean = XPathResultConstants::BOOLEAN_TYPE,
    UnorderedNodeIterator = XPathResultConstants::UNORDERED_NODE_ITERATOR_TYPE,
    OrderedNodeIterator = XPathResultConstants::ORDERED_NODE_ITERATOR_TYPE,
    UnorderedNodeSnapshot = XPathResultConstants::UNORDERED_NODE_SNAPSHOT_TYPE,
    OrderedNodeSnapshot = XPathResultConstants::ORDERED_NODE_SNAPSHOT_TYPE,
    AnyUnorderedNode = XPathResultConstants::ANY_UNORDERED_NODE_TYPE,
    FirstOrderedNode = XPathResultConstants::FIRST_ORDERED_NODE_TYPE,
}

impl TryFrom<u16> for XPathResultType {
    type Error = ();

    fn try_from(value: u16) -> Result<Self, Self::Error> {
        match value {
            XPathResultConstants::ANY_TYPE => Ok(Self::Any),
            XPathResultConstants::NUMBER_TYPE => Ok(Self::Number),
            XPathResultConstants::STRING_TYPE => Ok(Self::String),
            XPathResultConstants::BOOLEAN_TYPE => Ok(Self::Boolean),
            XPathResultConstants::UNORDERED_NODE_ITERATOR_TYPE => Ok(Self::UnorderedNodeIterator),
            XPathResultConstants::ORDERED_NODE_ITERATOR_TYPE => Ok(Self::OrderedNodeIterator),
            XPathResultConstants::UNORDERED_NODE_SNAPSHOT_TYPE => Ok(Self::UnorderedNodeSnapshot),
            XPathResultConstants::ORDERED_NODE_SNAPSHOT_TYPE => Ok(Self::OrderedNodeSnapshot),
            XPathResultConstants::ANY_UNORDERED_NODE_TYPE => Ok(Self::AnyUnorderedNode),
            XPathResultConstants::FIRST_ORDERED_NODE_TYPE => Ok(Self::FirstOrderedNode),
            _ => Err(()),
        }
    }
}

#[derive(Debug, JSTraceable, MallocSizeOf)]
#[cfg_attr(crown, crown::unrooted_must_root_lint::must_root)]
enum XPathResultValue {
    Boolean(bool),
    /// A IEEE-754 double-precision floating point number
    Number(f64),
    String(DOMString),
    /// A collection of unique nodes
    Nodeset(Vec<Dom<Node>>),
}

impl From<Value> for XPathResultValue {
    fn from(value: Value) -> Self {
        match value {
            Value::Boolean(b) => XPathResultValue::Boolean(b),
            Value::Number(n) => XPathResultValue::Number(n),
            Value::String(s) => XPathResultValue::String(s.into()),
            Value::NodeSet(nodes) => XPathResultValue::Nodeset(
                nodes
                    .into_iter()
                    .map(|xpath_node| xpath_node.0.as_traced())
                    .collect(),
            ),
        }
    }
}

#[dom_struct]
pub(crate) struct XPathResult {
    reflector_: Reflector,
    window: Dom<Window>,
    /// The revision of the owner document when this result was created. When iterating over the
    /// values in the result, this is used to invalidate the iterator when the document is modified.
    version: Cell<u64>,
    result_type: Cell<XPathResultType>,
    value: DomRefCell<XPathResultValue>,
    iterator_pos: Cell<usize>,
}

impl XPathResult {
    fn new_inherited(window: &Window, result_type: XPathResultType, value: Value) -> XPathResult {
        XPathResult {
            reflector_: Reflector::new(),
            window: Dom::from_ref(window),
            version: Cell::new(
                window
                    .Document()
                    .upcast::<Node>()
                    .inclusive_descendants_version(),
            ),
            result_type: Cell::new(result_type),
            iterator_pos: Cell::new(0),
            value: DomRefCell::new(value.into()),
        }
    }

    fn document_changed_since_creation(&self) -> bool {
        let current_document_version = self
            .window
            .Document()
            .upcast::<Node>()
            .inclusive_descendants_version();
        current_document_version != self.version.get()
    }

    /// NB: Blindly trusts `result_type` and constructs an object regardless of the contents
    /// of `value`. The exception is `XPathResultType::Any`, for which we look at the value
    /// to determine the type.
    pub(crate) fn new(
        cx: &mut JSContext,
        window: &Window,
        result_type: XPathResultType,
        value: Value,
    ) -> DomRoot<XPathResult> {
        reflect_dom_object(
            cx,
            Box::new(XPathResult::new_inherited(window, result_type, value)),
            window,
        )
    }

    pub(crate) fn reinitialize_with(
        &self,
        no_gc: &NoGC,
        result_type: XPathResultType,
        value: Value,
    ) {
        self.result_type.set(result_type);
        *self.value.safe_borrow_mut(no_gc) = value.into();
        self.version.set(
            self.window
                .Document()
                .upcast::<Node>()
                .inclusive_descendants_version(),
        );
        self.iterator_pos.set(0);
    }
}

impl XPathResultMethods<crate::DomTypeHolder> for XPathResult {
    /// <https://dom.spec.whatwg.org/#dom-xpathresult-resulttype>
    fn ResultType(&self) -> u16 {
        self.result_type.get() as u16
    }

    /// <https://dom.spec.whatwg.org/#dom-xpathresult-numbervalue>
    fn GetNumberValue(&self) -> Fallible<f64> {
        match (&*self.value.borrow(), self.result_type.get()) {
            (XPathResultValue::Number(n), XPathResultType::Number) => Ok(*n),
            _ => Err(Error::Type(
                c"Can't get number value for non-number XPathResult".to_owned(),
            )),
        }
    }

    /// <https://dom.spec.whatwg.org/#dom-xpathresult-stringvalue>
    fn GetStringValue(&self) -> Fallible<DOMString> {
        match (&*self.value.borrow(), self.result_type.get()) {
            (XPathResultValue::String(s), XPathResultType::String) => Ok(s.clone()),
            _ => Err(Error::Type(
                c"Can't get string value for non-string XPathResult".to_owned(),
            )),
        }
    }

    /// <https://dom.spec.whatwg.org/#dom-xpathresult-booleanvalue>
    fn GetBooleanValue(&self) -> Fallible<bool> {
        match (&*self.value.borrow(), self.result_type.get()) {
            (XPathResultValue::Boolean(b), XPathResultType::Boolean) => Ok(*b),
            _ => Err(Error::Type(
                c"Can't get boolean value for non-boolean XPathResult".to_owned(),
            )),
        }
    }

    /// <https://dom.spec.whatwg.org/#dom-xpathresult-iteratenext>
    fn IterateNext(&self) -> Fallible<Option<DomRoot<Node>>> {
        if !matches!(
            self.result_type.get(),
            XPathResultType::OrderedNodeIterator | XPathResultType::UnorderedNodeIterator
        ) {
            return Err(Error::Type(c"Result is not an iterator".into()));
        }

        if self.document_changed_since_creation() {
            return Err(Error::InvalidState(None));
        }

        let XPathResultValue::Nodeset(nodes) = &*self.value.borrow() else {
            return Err(Error::Type(
                c"Can't iterate on XPathResult that is not a node-set".to_owned(),
            ));
        };

        let position = self.iterator_pos.get();
        if position >= nodes.len() {
            Ok(None)
        } else {
            let node = nodes[position].as_rooted();
            self.iterator_pos.set(position + 1);
            Ok(Some(node))
        }
    }

    /// <https://dom.spec.whatwg.org/#dom-xpathresult-invaliditeratorstate>
    fn InvalidIteratorState(&self) -> bool {
        let is_iterable = matches!(
            self.result_type.get(),
            XPathResultType::OrderedNodeIterator | XPathResultType::UnorderedNodeIterator
        );

        is_iterable && self.document_changed_since_creation()
    }

    /// <https://dom.spec.whatwg.org/#dom-xpathresult-snapshotlength>
    fn GetSnapshotLength(&self) -> Fallible<u32> {
        match (&*self.value.borrow(), self.result_type.get()) {
            (
                XPathResultValue::Nodeset(nodes),
                XPathResultType::OrderedNodeSnapshot | XPathResultType::UnorderedNodeSnapshot,
            ) => Ok(nodes.len() as u32),
            _ => Err(Error::Type(
                c"Can't get snapshot length of XPathResult that is not a snapshot".to_owned(),
            )),
        }
    }

    /// <https://dom.spec.whatwg.org/#dom-xpathresult-snapshotitem>
    fn SnapshotItem(&self, index: u32) -> Fallible<Option<DomRoot<Node>>> {
        match (&*self.value.borrow(), self.result_type.get()) {
            (
                XPathResultValue::Nodeset(nodes),
                XPathResultType::OrderedNodeSnapshot | XPathResultType::UnorderedNodeSnapshot,
            ) => Ok(nodes.get(index as usize).map(|node| node.as_rooted())),
            _ => Err(Error::Type(
                c"Can't get snapshot item of XPathResult that is not a snapshot".to_owned(),
            )),
        }
    }

    /// <https://dom.spec.whatwg.org/#dom-xpathresult-singlenodevalue>
    fn GetSingleNodeValue(&self) -> Fallible<Option<DomRoot<Node>>> {
        match (&*self.value.borrow(), self.result_type.get()) {
            (
                XPathResultValue::Nodeset(nodes),
                XPathResultType::AnyUnorderedNode | XPathResultType::FirstOrderedNode,
            ) => Ok(nodes.first().map(|node| node.as_rooted())),
            _ => Err(Error::Type(
                c"Getting single value requires result type 'any unordered node' or 'first ordered node'".to_owned(),
            )),
        }
    }
}