components/devtools/actors/source.rs - main - githubmirror/servo

components/devtools/actors/source.rs
304 строки11 KB
eri
devtools: Avoid panics when borrowing in `ActorRegistry` (#45248)
04 июн 2026, 13:57
04 июн 2026, 13:5784fa008
/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at https://mozilla.org/MPL/2.0/. */

use std::collections::{BTreeMap, BTreeSet};
use std::str::FromStr;
use std::sync::Arc;

use atomic_refcell::AtomicRefCell;
use devtools_traits::DevtoolScriptControlMsg;
use malloc_size_of_derive::MallocSizeOf;
use serde::{Deserialize, Serialize};
use serde_json::{Map, Value};
use servo_base::generic_channel::{GenericSender, channel};
use servo_base::id::PipelineId;
use servo_url::ServoUrl;

use crate::StreamId;
use crate::actor::{Actor, ActorError, ActorRegistry, DowncastableActorArc, new_actor_name};
use crate::actors::breakpoint::BreakpointRequestLocation;
use crate::protocol::ClientRequest;

/// A `sourceForm` as used in responses to thread `sources` requests.
///
/// For now, we also use this for sources in watcher `resource-available-array` messages,
/// but in Firefox those have extra fields.
///
/// <https://firefox-source-docs.mozilla.org/devtools/backend/protocol.html#loading-script-sources>
#[derive(Clone, Debug, Eq, Ord, PartialEq, PartialOrd, Serialize)]
#[serde(rename_all = "camelCase")]
pub(crate) struct SourceForm {
    actor: String,
    /// URL of the script, or URL of the page for inline scripts.
    url: String,
    is_black_boxed: bool,
    /// `introductionType` in SpiderMonkey `CompileOptionsWrapper`.
    introduction_type: String,
}

#[derive(Serialize)]
pub(crate) struct SourcesReply {
    pub from: String,
    pub sources: Vec<SourceForm>,
}

#[derive(MallocSizeOf)]
pub(crate) struct SourceManager {
    source_actor_names: AtomicRefCell<BTreeSet<String>>,
}

impl SourceManager {
    pub fn new() -> Self {
        Self {
            source_actor_names: AtomicRefCell::new(BTreeSet::default()),
        }
    }

    pub fn add_source(&self, actor_name: &str) {
        self.source_actor_names
            .borrow_mut()
            .insert(actor_name.to_owned());
    }

    pub fn source_forms(&self, registry: &ActorRegistry) -> Vec<SourceForm> {
        self.source_actor_names
            .borrow()
            .iter()
            .map(|source_name| registry.find::<SourceActor>(source_name).source_form())
            .collect()
    }

    pub fn find_source(
        &self,
        registry: &ActorRegistry,
        source_url: &str,
    ) -> Option<DowncastableActorArc<SourceActor>> {
        for source_name in self.source_actor_names.borrow().iter() {
            let source_actor = registry.find::<SourceActor>(source_name);
            if source_actor.url == ServoUrl::from_str(source_url).ok()? {
                return Some(source_actor);
            }
        }
        None
    }
}

#[derive(Clone, Debug, MallocSizeOf)]
pub(crate) struct SourceActor {
    /// Actor name.
    name: String,

    /// URL of the script, or URL of the page for inline scripts.
    url: ServoUrl,

    /// The ‘black-boxed’ flag, which tells the debugger to avoid pausing inside this script.
    /// <https://firefox-source-docs.mozilla.org/devtools/backend/protocol.html#black-boxing-sources>
    is_black_boxed: bool,

    pub content: AtomicRefCell<Option<String>>,
    content_type: Option<String>,

    pub spidermonkey_id: u32,
    /// `introductionType` in SpiderMonkey `CompileOptionsWrapper`.
    introduction_type: String,

    pub script_sender: GenericSender<DevtoolScriptControlMsg>,
}

#[derive(Serialize)]
struct SourceContentReply {
    from: String,
    #[serde(rename = "contentType")]
    content_type: Option<String>,
    source: String,
}

#[derive(Serialize)]
struct GetBreakableLinesReply {
    from: String,
    // Line numbers are one-based.
    // <https://firefox-source-docs.mozilla.org/devtools/backend/protocol.html#source-locations>
    lines: BTreeSet<u32>,
}

#[derive(Serialize)]
struct GetBreakpointPositionsCompressedReply {
    from: String,
    // Column numbers are in UTF-16 code units, not Unicode scalar values or grapheme clusters.
    // Line number are one-based. Column numbers are zero-based.
    // FIXME: the docs say column numbers are one-based, but this appears to be incorrect.
    // <https://firefox-source-docs.mozilla.org/devtools/backend/protocol.html#source-locations>
    positions: BTreeMap<u32, BTreeSet<u32>>,
}

#[derive(Deserialize)]
struct GetBreakpointPositionsQuery {
    start: BreakpointRequestLocation,
    end: BreakpointRequestLocation,
}

#[derive(Deserialize)]
struct GetBreakpointPositionsRequest {
    query: GetBreakpointPositionsQuery,
}

impl SourceActor {
    #[expect(clippy::too_many_arguments)]
    pub fn register(
        registry: &ActorRegistry,
        pipeline_id: PipelineId,
        url: ServoUrl,
        content: Option<String>,
        content_type: Option<String>,
        spidermonkey_id: u32,
        introduction_type: String,
        script_sender: GenericSender<DevtoolScriptControlMsg>,
    ) -> Arc<Self> {
        let name = new_actor_name::<Self>();
        let actor = Self {
            name: name.clone(),
            url,
            content: AtomicRefCell::new(content),
            content_type,
            is_black_boxed: false,
            spidermonkey_id,
            introduction_type,
            script_sender,
        };
        registry.register_source_actor(pipeline_id, &name);
        registry.register::<Self>(actor)
    }

    pub fn source_form(&self) -> SourceForm {
        SourceForm {
            actor: self.name.clone(),
            url: self.url.to_string(),
            is_black_boxed: self.is_black_boxed,
            introduction_type: self.introduction_type.clone(),
        }
    }
}

impl Actor for SourceActor {
    fn name(&self) -> &str {
        &self.name
    }

    fn handle_message(
        &self,
        request: ClientRequest,
        _registry: &ActorRegistry,
        msg_type: &str,
        msg: &Map<String, Value>,
        _id: StreamId,
    ) -> Result<(), ActorError> {
        match msg_type {
            // Client has requested contents of the source.
            "source" => {
                let reply = SourceContentReply {
                    from: self.name().into(),
                    content_type: self.content_type.clone(),
                    // TODO: if needed, fetch the page again, in the same way as in the original request.
                    // Fetch it from cache, even if the original request was non-idempotent (e.g. POST).
                    // If we can’t fetch it from cache, we should probably give up, because with a real
                    // fetch, the server could return a different response.
                    // TODO: do we want to wait instead of giving up immediately, in cases where the content could
                    // become available later (e.g. after a fetch)?
                    source: self
                        .content
                        .borrow()
                        .as_deref()
                        .unwrap_or("<!-- not available; please reload! -->")
                        .to_owned(),
                };
                request.reply_final(&reply)?
            },
            // Client wants to know which lines can have breakpoints.
            // Sent when opening a source in the Sources panel, and controls whether the line numbers can be clicked.
            "getBreakableLines" => {
                let Some((tx, rx)) = channel() else {
                    return Err(ActorError::Internal);
                };
                self.script_sender
                    .send(DevtoolScriptControlMsg::GetPossibleBreakpoints(
                        self.spidermonkey_id,
                        tx,
                    ))
                    .map_err(|_| ActorError::Internal)?;
                let result = rx.recv().map_err(|_| ActorError::Internal)?;
                let lines = result
                    .into_iter()
                    .map(|location| location.line_number)
                    .collect::<BTreeSet<_>>();
                let reply = GetBreakableLinesReply {
                    from: self.name().into(),
                    lines,
                };
                request.reply_final(&reply)?
            },
            // Client wants to know which columns in the line can have breakpoints.
            // Sent when the user tries to set a breakpoint by clicking a line number in a source.
            "getBreakpointPositionsCompressed" => {
                let query =
                    serde_json::from_value::<GetBreakpointPositionsRequest>(msg.clone().into())
                        .ok()
                        .map(|msg| (msg.query.start, msg.query.end));

                let (tx, rx) = channel().ok_or(ActorError::Internal)?;
                self.script_sender
                    .send(DevtoolScriptControlMsg::GetPossibleBreakpoints(
                        self.spidermonkey_id,
                        tx,
                    ))
                    .map_err(|_| ActorError::Internal)?;
                let result = rx.recv().map_err(|_| ActorError::Internal)?;

                let mut positions: BTreeMap<u32, BTreeSet<u32>> = BTreeMap::default();
                for location in result {
                    // Line number are one-based. Column numbers are zero-based.
                    // FIXME: the docs say column numbers are one-based, but this appears to be incorrect.
                    // <https://firefox-source-docs.mozilla.org/devtools/backend/protocol.html#source-locations>
                    if query.as_ref().is_some_and(|(start, end)| {
                        location.line_number < start.line || location.line_number > end.line
                    }) {
                        continue;
                    }
                    positions
                        .entry(location.line_number)
                        .or_default()
                        .insert(location.column_number - 1);
                }
                let reply = GetBreakpointPositionsCompressedReply {
                    from: self.name().into(),
                    positions,
                };
                request.reply_final(&reply)?
            },
            _ => return Err(ActorError::UnrecognizedPacketType),
        };
        Ok(())
    }
}

impl SourceActor {
    pub fn find_offset(&self, line: u32, column: u32) -> Option<(u32, u32)> {
        let (tx, rx) = channel()?;
        self.script_sender
            .send(DevtoolScriptControlMsg::GetPossibleBreakpoints(
                self.spidermonkey_id,
                tx,
            ))
            .ok()?;
        let result = rx.recv().ok()?;
        for location in result {
            // Line number are one-based. Column numbers are zero-based.
            // FIXME: the docs say column numbers are one-based, but this appears to be incorrect.
            // <https://firefox-source-docs.mozilla.org/devtools/backend/protocol.html#source-locations>
            if location.line_number == line && location.column_number - 1 == column {
                return Some((location.script_id, location.offset));
            }
        }
        None
    }
}