src/Features/CSharp/Portable/ConvertIfToSwitch/CSharpConvertIfToSwitchCodeRefactoringProvider.cs - main - githubmirror/roslyn

src/Features/CSharp/Portable/ConvertIfToSwitch/CSharpConvertIfToSwitchCodeRefactoringProvider.cs

53 строки3 KB

Cyrus Najmabadi

Fix broken 'convert if to switch' case with recursive analysis

07 дек 2024, 04:22

07 дек 2024, 04:227417ea1

// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using System.Composition;
using System.Diagnostics.CodeAnalysis;
using System.Linq;
using Microsoft.CodeAnalysis.CodeRefactorings;
using Microsoft.CodeAnalysis.ConvertIfToSwitch;
using Microsoft.CodeAnalysis.CSharp.Extensions;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.LanguageService;

namespace Microsoft.CodeAnalysis.CSharp.ConvertIfToSwitch;

[ExportCodeRefactoringProvider(LanguageNames.CSharp, Name = PredefinedCodeRefactoringProviderNames.ConvertIfToSwitch), Shared]
[method: ImportingConstructor]
[method: SuppressMessage("RoslynDiagnosticsReliability", "RS0033:Importing constructor should be [Obsolete]", Justification = "Used in test code: https://github.com/dotnet/roslyn/issues/42814")]
internal sealed partial class CSharpConvertIfToSwitchCodeRefactoringProvider()
    : AbstractConvertIfToSwitchCodeRefactoringProvider<IfStatementSyntax, ExpressionSyntax, BinaryExpressionSyntax, PatternSyntax>
{
    public override string GetTitle(bool forSwitchExpression)
        => forSwitchExpression
            ? CSharpFeaturesResources.Convert_to_switch_expression
            : CSharpFeaturesResources.Convert_to_switch_statement;

    public override Analyzer CreateAnalyzer(ISyntaxFacts syntaxFacts, ParseOptions options)
    {
        var version = options.LanguageVersion();
        var features =
            (version >= LanguageVersion.CSharp7 ? Feature.SourcePattern | Feature.IsTypePattern | Feature.CaseGuard : 0) |
            (version >= LanguageVersion.CSharp8 ? Feature.SwitchExpression : 0) |
            (version >= LanguageVersion.CSharp9 ? Feature.RelationalPattern | Feature.OrPattern | Feature.AndPattern | Feature.TypePattern : 0);
        return new CSharpAnalyzer(syntaxFacts, features);
    }

    protected override SyntaxTriviaList GetLeadingTriviaToTransfer(SyntaxNode syntaxToRemove)
    {
        if (syntaxToRemove is (IfStatementSyntax or BlockSyntax) and { Parent: ElseClauseSyntax elseClause } &&
            elseClause.ElseKeyword.LeadingTrivia.Any(t => t.IsSingleOrMultiLineComment()))
        {
            // users sometimes write:
            //
            //  // Comment
            //  else if (x == b)
            //
            // Attempt to move 'comment' over to the switch section.
            return elseClause.ElseKeyword.LeadingTrivia;
        }

        return default;
    }
}