cmd/archive/archive_test.go - master - githubmirror/rclone

cmd/archive/archive_test.go
244 строки7 KB
Nick Craig-Wood
archive extract: fix path traversal letting archives escape the destination CVE-2026-59732
08 июл 2026, 18:05
08 июл 2026, 18:05d11efe0
package archive_test

import (
	"archive/zip"
	"bytes"
	"context"
	"strings"
	"testing"

	"github.com/mholt/archives"
	_ "github.com/rclone/rclone/backend/local"
	_ "github.com/rclone/rclone/backend/memory"
	"github.com/rclone/rclone/fs"
	"github.com/rclone/rclone/fs/operations"
	"github.com/rclone/rclone/fstest"
	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"

	"github.com/rclone/rclone/cmd/archive/create"
	"github.com/rclone/rclone/cmd/archive/extract"
	"github.com/rclone/rclone/cmd/archive/list"
)

var (
	t1 = fstest.Time("2017-02-03T04:05:06.499999999Z")
)

// TestMain drives the tests
func TestMain(m *testing.M) {
	fstest.TestMain(m)
}

func TestCheckValidDestination(t *testing.T) {
	var err error

	ctx := context.Background()
	r := fstest.NewRun(t)

	// create file
	r.WriteObject(ctx, "file1.txt", "111", t1)

	// test checkValidDestination when file exists
	err = create.CheckValidDestination(ctx, r.Fremote, "file1.txt")
	require.NoError(t, err)

	// test checkValidDestination when file does not exist
	err = create.CheckValidDestination(ctx, r.Fremote, "file2.txt")
	require.NoError(t, err)

	// test checkValidDestination when dest is a directory
	if r.Fremote.Features().CanHaveEmptyDirectories {
		err = create.CheckValidDestination(ctx, r.Fremote, "")
		require.ErrorIs(t, err, fs.ErrorIsDir)
	}

	// test checkValidDestination when dest does not exists
	err = create.CheckValidDestination(ctx, r.Fremote, "dir/file.txt")
	require.NoError(t, err)
}

// test archiving to the remote
func testArchiveRemote(t *testing.T, fromLocal bool, subDir string, extension string) {
	var err error
	ctx := context.Background()
	r := fstest.NewRun(t)
	var src, dst fs.Fs
	var f1, f2, f3 fstest.Item

	// create files to archive on src
	if fromLocal {
		// create files to archive on local
		src = r.Flocal
		dst = r.Fremote
		f1 = r.WriteFile("file1.txt", "content 1", t1)
		f2 = r.WriteFile("dir1/sub1.txt", "sub content 1", t1)
		f3 = r.WriteFile("dir2/sub2a.txt", "sub content 2a", t1)
	} else {
		// create files to archive on remote
		src = r.Fremote
		dst = r.Flocal
		f1 = r.WriteObject(ctx, "file1.txt", "content 1", t1)
		f2 = r.WriteObject(ctx, "dir1/sub1.txt", "sub content 1", t1)
		f3 = r.WriteObject(ctx, "dir2/sub2a.txt", "sub content 2a", t1)
	}
	fstest.CheckItems(t, src, f1, f2, f3)

	// create archive on dst
	archiveName := "test." + extension
	err = create.ArchiveCreate(ctx, dst, archiveName, src, "", "")
	require.NoError(t, err)

	// list archive on dst
	expected := map[string]int64{
		"file1.txt":      9,
		"dir1/":          0,
		"dir1/sub1.txt":  13,
		"dir2/":          0,
		"dir2/sub2a.txt": 14,
	}
	listFile := func(ctx context.Context, f archives.FileInfo) error {
		name := f.NameInArchive
		gotSize := f.Size()
		if f.IsDir() && !strings.HasSuffix(name, "/") {
			name += "/"
			gotSize = 0
		}
		wantSize, found := expected[name]
		assert.True(t, found, name)
		assert.Equal(t, wantSize, gotSize)
		delete(expected, name)
		return nil
	}
	err = list.ArchiveList(ctx, dst, archiveName, listFile)
	require.NoError(t, err)
	assert.Equal(t, 0, len(expected), expected)

	// clear the src
	require.NoError(t, operations.Purge(ctx, src, ""))
	require.NoError(t, src.Mkdir(ctx, ""))
	fstest.CheckItems(t, src)

	// extract dst archive back to src
	err = extract.ArchiveExtract(ctx, src, subDir, dst, archiveName)
	require.NoError(t, err)

	// check files on src are restored from the archive on dst
	items := []fstest.Item{f1, f2, f3}
	if subDir != "" {
		for i := range items {
			item := &items[i]
			item.Path = subDir + "/" + item.Path
		}
	}
	fstest.CheckListingWithPrecision(t, src, items, nil, fs.ModTimeNotSupported)
}

func testArchive(t *testing.T) {
	var extensions = []string{
		"zip",
		"tar",
		"tar.gz",
		"tar.bz2",
		"tar.lz",
		"tar.lz4",
		"tar.xz",
		"tar.zst",
		"tar.br",
		"tar.sz",
		"tar.mz",
	}
	for _, extension := range extensions {
		t.Run(extension, func(t *testing.T) {
			for _, subDir := range []string{"", "subdir"} {
				name := subDir
				if name == "" {
					name = "root"
				}
				t.Run(name, func(t *testing.T) {
					t.Run("local", func(t *testing.T) {
						testArchiveRemote(t, true, name, extension)
					})
					t.Run("remote", func(t *testing.T) {
						testArchiveRemote(t, false, name, extension)
					})
				})
			}
		})
	}
}

func TestIntegration(t *testing.T) {
	testArchive(t)
}

// craftZip builds an in-memory zip archive with the given entries, returning
// it as a string. The entry names are written verbatim so they can include
// crafted path traversal sequences that the archive create command would
// never produce from real files.
func craftZip(t *testing.T, entries []struct{ name, content string }) string {
	var buf bytes.Buffer
	zw := zip.NewWriter(&buf)
	for _, e := range entries {
		w, err := zw.CreateHeader(&zip.FileHeader{Name: e.name, Method: zip.Store})
		require.NoError(t, err)
		_, err = w.Write([]byte(e.content))
		require.NoError(t, err)
	}
	require.NoError(t, zw.Close())
	return buf.String()
}

// TestExtractPathTraversal checks that a crafted archive whose entries try to
// escape the destination directory with ".." components is rejected and does
// not write anything outside the destination (GHSA-4vr5-p2gc-h23p).
func TestExtractPathTraversal(t *testing.T) {
	ctx := context.Background()

	for _, tc := range []struct {
		name  string
		entry string
	}{
		{name: "forward slash", entry: "../escaped.txt"},
		{name: "backslash", entry: `..\escaped.txt`},
	} {
		t.Run(tc.name, func(t *testing.T) {
			r := fstest.NewRun(t)

			zipData := craftZip(t, []struct{ name, content string }{
				{"safe.txt", "safe content"},
				{tc.entry, "escaped content"},
			})
			r.WriteObject(ctx, "malicious.zip", zipData, t1)

			// Extract into a subdirectory so a successful escape would land
			// in "safe/escaped.txt", a sibling of the "safe/prefix" target.
			err := extract.ArchiveExtract(ctx, r.Flocal, "safe/prefix", r.Fremote, "malicious.zip")
			require.Error(t, err)
			assert.Contains(t, err.Error(), "..")

			// Nothing should have escaped the destination directory.
			for _, escaped := range []string{"safe/escaped.txt", "escaped.txt"} {
				_, err := r.Flocal.NewObject(ctx, escaped)
				assert.ErrorIs(t, err, fs.ErrorObjectNotFound, escaped)
			}
		})
	}
}

func TestMemory(t *testing.T) {
	if *fstest.RemoteName != "" {
		t.Skip("skipping as -remote is set")
	}

	// Reset -remote to point to :memory:
	oldFstestRemoteName := fstest.RemoteName
	remoteName := ":memory:"
	fstest.RemoteName = &remoteName
	defer func() {
		fstest.RemoteName = oldFstestRemoteName
	}()
	fstest.ResetRun()

	testArchive(t)
}