pkg/alerts/allowed_upgrade.go - main - githubmirror/origin

pkg/alerts/allowed_upgrade.go

55 строк2 KB

Devan Goodwin

Revert "TRT-1625: Revert #28741 "OCPBUGS-32923: Fix allowed firing alerts not triggering""

26 апр 2024, 19:40

26 апр 2024, 19:40db91c45

package alerts

import (
	configv1 "github.com/openshift/api/config/v1"
)

// AllowedAlertsDuringUpgrade lists all alerts that are allowed to be pending or firing during
// upgrade.
// WARNING: there is a parallel list for allowed alerts during conformance in allowed_conformance.go,
// ensure that alerts we want to allow in both are added to both.
func AllowedAlertsDuringUpgrade(featureSet configv1.FeatureSet) (allowedFiringWithBugs, allowedFiring, allowedPendingWithBugs, allowedPending MetricConditions) {

	firingAlertsWithBugs := MetricConditions{}

	allowedFiringAlerts := MetricConditions{
		{
			AlertName:      "TargetDown",
			AlertNamespace: "openshift-e2e-loki",
			Text:           "Loki is nice to have, but we can allow it to be down",
		},
		{
			AlertName:      "KubePodNotReady",
			AlertNamespace: "openshift-e2e-loki",
			Text:           "Loki is nice to have, but we can allow it to be down",
		},
		{
			AlertName:      "KubeDeploymentReplicasMismatch",
			AlertNamespace: "openshift-e2e-loki",
			Text:           "Loki is nice to have, but we can allow it to be down",
		},
	}
	pendingAlertsWithBugs := MetricConditions{}
	allowedPendingAlerts := MetricConditions{
		{
			AlertName: "etcdMemberCommunicationSlow",
			Text:      "Excluded because it triggers during upgrade (detects ~5m of high latency immediately preceeding the end of the test), and we don't want to change the alert because it is correct",
		},
	}

	switch featureSet {
	case configv1.TechPreviewNoUpgrade:
		allowedFiringAlerts = append(
			allowedFiringAlerts,
			MetricCondition{
				AlertName: "TechPreviewNoUpgrade",
				Text:      "Allow testing of TechPreviewNoUpgrade clusters, this will only fire when a FeatureGate has been enabled",
			},
			MetricCondition{
				AlertName: "ClusterNotUpgradeable",
				Text:      "Allow testing of ClusterNotUpgradeable clusters, this will only fire when a FeatureGate has been enabled",
			})
	}

	return firingAlertsWithBugs, allowedFiringAlerts, pendingAlertsWithBugs, allowedPendingAlerts
}