githubmirror/oppia

scripts/docstrings_checker.py
320 строк11 KB
Vojtěch Jelínek
Refactor future imports and MyPy typing (#14132)
01 ноя 2021, 05:16
01 ноя 2021, 05:166778d66
# coding: utf-8
#
# Copyright 2018 The Oppia Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#      http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS-IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

"""Utility methods for docstring checking."""

from __future__ import annotations

import ast
import os
import re
import sys

from core import python_utils
from scripts import common

_PARENT_DIR = os.path.abspath(os.path.join(os.getcwd(), os.pardir))
_PYLINT_PATH = os.path.join(
    _PARENT_DIR, 'oppia_tools', 'pylint-%s' % common.PYLINT_VERSION)
sys.path.insert(0, _PYLINT_PATH)

import astroid # isort:skip  pylint: disable=wrong-import-order, wrong-import-position
from pylint.checkers import utils # isort:skip  pylint: disable=wrong-import-order, wrong-import-position
from pylint.extensions import _check_docs_utils # isort:skip  pylint: disable=wrong-import-order, wrong-import-position


def space_indentation(s):
    """The number of leading spaces in a string

    Args:
        s: str. The input string.

    Returns:
        int. The number of leading spaces.
    """
    return len(s) - len(s.lstrip(' '))


def get_setters_property_name(node):
    """Get the name of the property that the given node is a setter for.

    Args:
        node: str. The node to get the property name for.

    Returns:
        str|None. The name of the property that the node is a setter for,
        or None if one could not be found.
    """
    decorator_nodes = node.decorators.nodes if node.decorators else []
    for decorator_node in decorator_nodes:
        if (isinstance(decorator_node, astroid.Attribute) and
                decorator_node.attrname == 'setter' and
                isinstance(decorator_node.expr, astroid.Name)):
            return decorator_node.expr.name
    return None


def get_setters_property(node):
    """Get the property node for the given setter node.

    Args:
        node: astroid.FunctionDef. The node to get the property for.

    Returns:
        astroid.FunctionDef|None. The node relating to the property of
        the given setter node, or None if one could not be found.
    """
    setters_property = None

    property_name = get_setters_property_name(node)
    class_node = utils.node_frame_class(node)
    if property_name and class_node:
        class_attrs = class_node.getattr(node.name)
        for attr in class_attrs:
            if utils.decorated_with_property(attr):
                setters_property = attr
                break

    return setters_property


def returns_something(return_node):
    """Check if a return node returns a value other than None.

    Args:
        return_node: astroid.Return. The return node to check.

    Returns:
        bool. True if the return node returns a value other than None, False
        otherwise.
    """
    returns = return_node.value

    if returns is None:
        return False

    return not (isinstance(returns, astroid.Const) and returns.value is None)


def possible_exc_types(node):
    """Gets all of the possible raised exception types for the given raise node.
    Caught exception types are ignored.

    Args:
        node: astroid.node_classes.NodeNG. The raise
            to find exception types for.

    Returns:
        set(str). A list of exception types.
    """
    excs = []
    if isinstance(node.exc, astroid.Name):
        inferred = utils.safe_infer(node.exc)
        if inferred:
            excs = [inferred.name]
    elif (isinstance(node.exc, astroid.Call) and
          isinstance(node.exc.func, astroid.Name)):
        target = utils.safe_infer(node.exc.func)
        if isinstance(target, astroid.ClassDef):
            excs = [target.name]
        elif isinstance(target, astroid.FunctionDef):
            for ret in target.nodes_of_class(astroid.Return):
                if ret.frame() != target:
                    continue

                val = utils.safe_infer(ret.value)
                if (val and isinstance(val, (
                        astroid.Instance, astroid.ClassDef)) and
                        utils.inherit_from_std_ex(val)):
                    excs.append(val.name)
    elif node.exc is None:
        handler = node.parent
        while handler and not isinstance(handler, astroid.ExceptHandler):
            handler = handler.parent

        if handler and handler.type:
            inferred_excs = astroid.unpack_infer(handler.type)
            excs = (
                exc.name for exc in inferred_excs
                if exc is not astroid.Uninferable)

    try:
        return set(
            exc for exc in excs if not utils.node_ignores_exception(
                node, exc))
    except astroid.InferenceError:
        return set()


def docstringify(docstring):
    """Converts a docstring in its str form to its Docstring object
    as defined in the pylint library.

    Args:
        docstring: str. Docstring for a particular class or function.

    Returns:
        Docstring. Pylint Docstring class instance representing
        a node's docstring.
    """
    for docstring_type in [GoogleDocstring]:
        instance = docstring_type(docstring)
        if instance.is_valid():
            return instance

    return _check_docs_utils.Docstring(docstring)


class GoogleDocstring(_check_docs_utils.GoogleDocstring):
    """Class for checking whether docstrings follow the Google Python Style
    Guide.
    """

    re_multiple_type = _check_docs_utils.GoogleDocstring.re_multiple_type
    re_param_line = re.compile(
        r"""
        \s*  \*{{0,2}}(\w+)             # identifier potentially with asterisks
        \s*  ( [:]
            \s*
            ({type}|\S*)
            (?:,\s+optional)?
            [.] )? \s*                  # optional type declaration
        \s*  (.*)                       # beginning of optional description
    """.format(
        type=re_multiple_type,
    ), flags=re.X | re.S | re.M)

    re_returns_line = re.compile(
        r"""
        \s* (({type}|\S*).)?              # identifier
        \s* (.*)                          # beginning of description
    """.format(
        type=re_multiple_type,
    ), flags=re.X | re.S | re.M)

    re_yields_line = re_returns_line

    re_raise_line = re.compile(
        r"""
        \s* ({type}|\S*)?[.:]                    # identifier
        \s* (.*)                         # beginning of description
    """.format(
        type=re_multiple_type,
    ), flags=re.X | re.S | re.M)


class ASTDocStringChecker:
    """Checks that docstrings meet the code style."""

    def __init__(self):
        pass

    @classmethod
    def get_args_list_from_function_definition(cls, function_node):
        """Extracts the arguments from a function definition.
        Ignores class specific arguments (self and cls).

        Args:
            function_node: ast.FunctionDef. Represents a function.

        Returns:
            list(str). The args for a function as listed in the function
            definition.
        """
        # Ignore self and cls args.
        args_to_ignore = ['self', 'cls']
        return python_utils.get_args_of_function_node(
            function_node, args_to_ignore)

    @classmethod
    def build_regex_from_args(cls, function_args):
        """Builds a regex string from a function's arguments to match against
        the docstring. Ensures the docstring contains an 'Args' header, and
        each of the arguments are listed, followed by a colon, separated by new
        lines, and are listed in the correct order.

        Args:
            function_args: list(str). The arguments for a function.

        Returns:
            str. A regex that checks for an "Arg" header and then each arg term
            with a colon in order with any characters in between.
            The resulting regex looks like this (the backslashes are escaped):
                (Args:)[\\S\\s]*(arg_name0:)[\\S\\s]*(arg_name1:)
            If passed an empty list, returns None.
        """
        if len(function_args) > 0:
            formatted_args = ['({}:)'.format(arg) for arg in function_args]
            return r'(Args:)[\S\s]*' + r'[\S\s]*'.join(formatted_args)

    @classmethod
    def compare_arg_order(cls, func_def_args, docstring):
        """Compares the arguments listed in the function definition and
        docstring, and raises errors if there are missing or mis-ordered
        arguments in the docstring.

        Args:
            func_def_args: list(str). The args as listed in the function
                definition.
            docstring: str. The contents of the docstring under the Args
                header.

        Returns:
            list(str). Each str contains an error message. If no linting
            errors were found, the list will be empty.
        """
        results = []

        # If there is no docstring or it doesn't have an Args section, exit
        # without errors.
        if docstring is None or 'Args' not in docstring:
            return results

        # First check that each arg is in the docstring.
        for arg_name in func_def_args:
            arg_name_colon = arg_name + ':'
            if arg_name_colon not in docstring:
                if arg_name not in docstring:
                    results.append('Arg missing from docstring: {}'.format(
                        arg_name))
                else:
                    results.append('Arg not followed by colon: {}'.format(
                        arg_name))
        # Only check ordering if there's more than one argument in the
        # function definition, and no other errors have been found.
        if len(func_def_args) > 0 and len(results) == 0:
            regex_pattern = cls.build_regex_from_args(func_def_args)
            regex_result = re.search(regex_pattern, docstring)
            if regex_result is None:
                results.append('Arg ordering error in docstring.')
        return results

    @classmethod
    def check_docstrings_arg_order(cls, function_node):
        """Extracts the arguments from a function definition.

        Args:
            function_node: ast node object. Represents a function.

        Returns:
            list(str). List of docstring errors associated with
            the function. If the function has no errors, the list is empty.
        """
        func_def_args = cls.get_args_list_from_function_definition(
            function_node)
        docstring = ast.get_docstring(function_node)
        func_result = cls.compare_arg_order(func_def_args, docstring)
        return func_result