libdaemon/client/daemon-io.c - main - githubmirror/lvm2

libdaemon/client/daemon-io.c
98 строк3 KB
Zdenek Kabelac
cppcheck: simplify read error handling in daemon-io
11 май 2026, 11:18
11 май 2026, 11:18f445634
/*
 * Copyright (C) 2011-2013 Red Hat, Inc.
 *
 * This file is part of LVM2.
 *
 * This copyrighted material is made available to anyone wishing to use,
 * modify, copy, or redistribute it subject to the terms and conditions
 * of the GNU Lesser General Public License v.2.1.
 *
 * You should have received a copy of the GNU Lesser General Public License
 * along with this program; if not, write to the Free Software Foundation,
 * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 */

#include "daemon-io.h"

#include <errno.h>
#include <poll.h>
#include <string.h>
#include <unistd.h>

/* Maximum incoming message size (16 MiB) to prevent unbounded allocation */
#define DAEMON_MAX_MSG_SIZE (16 * 1024 * 1024)

/*
 * Read a single message from a (socket) filedescriptor. Messages are delimited
 * by blank lines. This call will block until all of a message is received. The
 * memory will be allocated from heap. Upon error, all memory is freed and the
 * buffer pointer is set to NULL.
 *
 * See also write_buffer about blocking (read_buffer has identical behaviour).
 */
int buffer_read(int fd, struct buffer *buffer) {
	struct pollfd pfd = { .fd = fd, .events = POLLIN };
	int result;

	if (!buffer_realloc(buffer, 32)) /* ensure we have some space */
		return 0;

	while (1) {
		result = read(fd, buffer->mem + buffer->used, buffer->allocated - buffer->used);
		if (result > 0) {
			buffer->used += result;
			if (buffer->used >= 4 && !strncmp((buffer->mem) + buffer->used - 4, "\n##\n", 4)) {
				buffer->used -= 4;
				buffer->mem[buffer->used] = 0;
				break; /* success, we have the full message now */
			}
			if (buffer->used > DAEMON_MAX_MSG_SIZE) {
				errno = EOVERFLOW;
				return 0;
			}
			if ((buffer->allocated - buffer->used < 32) &&
			    !buffer_realloc(buffer, 1024))
				return 0;
		} else if (result == 0) {
			errno = ECONNRESET;
			return 0; /* we should never encounter EOF here */
		} else {
			/* result < 0 */
			if (errno == EAGAIN || errno == EINTR || errno == EIO)
				/* ignore the result, this is just a glorified sleep */
				(void) poll(&pfd, 1, -1);
			else
				return 0;
		}
	}

	return 1;
}

/*
 * Write a buffer to a filedescriptor. Keep trying. Blocks (even on
 * SOCK_NONBLOCK) until all of the write went through.
 */
int buffer_write(int fd, const struct buffer *buffer) {
	static const struct buffer _terminate = { .mem = (char *) "\n##\n", .used = 4 };
	struct pollfd pfd = { .fd = fd, .events = POLLOUT };
	const struct buffer *use;
	int done, written, result;

	for (done = 0; done < 2; ++done) {
		use = (done == 0) ? buffer : &_terminate;
		for (written = 0; written < use->used;) {
			result = write(fd, use->mem + written, use->used - written);
			if (result > 0)
				written += result;
			else if (result < 0 && (errno == EAGAIN ||
						errno == EINTR || errno == EIO)) {
				/* ignore the result, this is just a glorified sleep */
				(void) poll(&pfd, 1, -1);
			} else if (result < 0)
				return 0; /* too bad */
		}
	}

	return 1;
}