app/api/controller/pullreq/label_assign.go - main - githubmirror/gitness

app/api/controller/pullreq/label_assign.go
142 строки4 KB
Darko Draskovic
fix: [CODE-5363]: Fix unable to assign a label with value (#5223)
21 май 2026, 14:19
21 май 2026, 14:1903c44e5
// Copyright 2023 Harness, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//     http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package pullreq

import (
	"context"
	"fmt"

	"github.com/harness/gitness/app/auth"
	events "github.com/harness/gitness/app/events/pullreq"
	"github.com/harness/gitness/app/services/label"
	"github.com/harness/gitness/errors"
	"github.com/harness/gitness/store"
	"github.com/harness/gitness/types"
	"github.com/harness/gitness/types/enum"

	"github.com/rs/zerolog/log"
)

// AssignLabel assigns a label to a pull request .
func (c *Controller) AssignLabel(
	ctx context.Context,
	session *auth.Session,
	repoRef string,
	pullreqNum int64,
	in *types.PullReqLabelAssignInput,
) (*types.PullReqLabel, error) {
	repo, err := c.getRepoCheckAccess(ctx, session, repoRef, enum.PermissionRepoReview)
	if err != nil {
		return nil, fmt.Errorf("failed to acquire access to target repo: %w", err)
	}

	if err := in.Validate(); err != nil {
		return nil, fmt.Errorf("failed to validate input: %w", err)
	}

	pullreq, err := c.pullreqStore.FindByNumber(ctx, repo.ID, pullreqNum)
	if err != nil {
		return nil, fmt.Errorf("failed to find pullreq: %w", err)
	}

	var out *label.AssignToPullReqOut
	err = c.tx.WithTx(ctx, func(ctx context.Context) error {
		out, err = c.labelSvc.AssignToPullReq(
			ctx, session.Principal.ID, pullreq.ID, repo.ID, repo.ParentID, in)
		if err != nil {
			return fmt.Errorf("failed to create pullreq label: %w", err)
		}

		if err = c.labelSuggestionStore.Delete(ctx, pullreq.ID, in.LabelID); err != nil &&
			!errors.Is(err, store.ErrResourceNotFound) {
			return fmt.Errorf("failed to delete label suggestions: %w", err)
		}

		return nil
	})
	if err != nil {
		return nil, err
	}

	if out.ActivityType == enum.LabelActivityNoop {
		return out.PullReqLabel, nil
	}

	err = func() error {
		if pullreq, err = c.pullreqStore.UpdateActivitySeq(ctx, pullreq); err != nil {
			return fmt.Errorf("failed to update pull request activity sequence: %w", err)
		}

		payload := activityPayload(out)
		if _, err := c.activityStore.CreateWithPayload(
			ctx, pullreq, session.Principal.ID, payload, nil); err != nil {
			return err
		}

		return nil
	}()
	if err != nil {
		log.Ctx(ctx).Err(err).Msg("failed to write pull request activity after label assign")
	}

	// if the label has no value, the newValueID will be nil
	var newValueID *int64
	if out.NewLabelValue != nil {
		newValueID = &out.NewLabelValue.ID
	}

	c.eventReporter.LabelAssigned(ctx, &events.LabelAssignedPayload{
		Base: events.Base{
			PullReqID:    pullreq.ID,
			SourceRepoID: pullreq.SourceRepoID,
			TargetRepoID: pullreq.TargetRepoID,
			PrincipalID:  session.Principal.ID,
			Number:       pullreq.Number,
		},
		LabelID: out.Label.ID,
		ValueID: newValueID,
	})

	return out.PullReqLabel, nil
}

func activityPayload(out *label.AssignToPullReqOut) *types.PullRequestActivityLabel {
	var oldValue *string
	var oldValueColor *enum.LabelColor
	if out.OldLabelValue != nil {
		oldValue = &out.OldLabelValue.Value
		oldValueColor = &out.OldLabelValue.Color
	}

	var value *string
	var valueColor *enum.LabelColor
	if out.NewLabelValue != nil {
		value = &out.NewLabelValue.Value
		valueColor = &out.NewLabelValue.Color
	}

	return &types.PullRequestActivityLabel{
		PullRequestActivityLabelBase: types.PullRequestActivityLabelBase{
			Label:         out.Label.Key,
			LabelColor:    out.Label.Color,
			LabelScope:    out.Label.Scope,
			Value:         value,
			ValueColor:    valueColor,
			OldValue:      oldValue,
			OldValueColor: oldValueColor,
		},
		Type: out.ActivityType,
	}
}