githubmirror/eslint-plugin

lib/rules/objectAssign.ts

47 строк1 KB

Johannes Theiner

Update rule messages to be more verbose, readd fixer for settings headings

03 ноя 2025, 22:08

03 ноя 2025, 22:08eeb70a8

import { TSESTree, ESLintUtils } from "@typescript-eslint/utils";

const ruleCreator = ESLintUtils.RuleCreator(
	(name) =>
		`https://github.com/obsidianmd/eslint-plugin/blob/master/docs/rules/${name}.md`,
);

export default ruleCreator({
	name: "object-assign",
	meta: {
		type: "problem" as const,
		docs: {
			description: "Discourage using `Object.assign` with two arguments",
			//TODO: Add url
		},
		schema: [],
		messages: {
			twoArgumentsDefault: "Using `Object.assign` with an non-empty target object can lead to unexpected behaviour as it will overwrite the  target object.",
		},
	},
	defaultOptions: [],
	create(context) {
		return {
			CallExpression(node: TSESTree.CallExpression) {
				if (
					node.callee &&
					node.callee.type === "MemberExpression" &&
					node.callee.object &&
					node.callee.object.type === "Identifier" &&
					node.callee.object.name === "Object" &&
					node.callee.property &&
					node.callee.property.type === "Identifier" &&
					node.callee.property.name === "assign" &&
					node.arguments.length === 2 &&
					node.arguments[0].type === "Identifier" &&
					node.arguments[0].name.toLowerCase().includes("default") &&
					node.arguments[1].type !== "ObjectExpression"
				) {
					context.report({
						node,
						messageId: "twoArgumentsDefault",
					});
				}
			},
		};
	},
});