githubmirror/code-server

patches/insecure-notification.diff
61 строка2 KB
Olivier Benz
Update Code to 1.94.2 (#7026)
18 окт 2024, 07:32
18 окт 2024, 07:32fc6064d
Add a notification when accessing code-server in an insecure context

This is done because otherwise when things like the clipboard do not work users
may think code-server is broken.  Ideally there would be a notification at the
point where these things are used instead of this though.

To test access over something like an HTTP domain or an IP address (not
localhost). For example:

1. run code-server
2. use ngrok to expose code-server
3. access via HTTP
4. look for notification in bottom right

Index: code-server/lib/vscode/src/vs/workbench/browser/client.ts
===================================================================
--- code-server.orig/lib/vscode/src/vs/workbench/browser/client.ts
+++ code-server/lib/vscode/src/vs/workbench/browser/client.ts
@@ -1,7 +1,10 @@
 import { Disposable } from "../../base/common/lifecycle.js";
+import { localize } from '../../nls.js';
+import { INotificationService, Severity } from '../../platform/notification/common/notification.js';
 
 export class CodeServerClient extends Disposable {
 	constructor (
+		@INotificationService private notificationService: INotificationService,
 	) {
 		super();
 	}
@@ -42,5 +45,31 @@ export class CodeServerClient extends Di
 				}
 			});
 		}
+
+		if (!window.isSecureContext) {
+			this.notificationService.notify({
+				severity: Severity.Warning,
+				message: localize(
+					'insecureContext',
+					"{0} is being accessed in an insecure context. Web views, the clipboard, and other functionality may not work as expected.",
+					'code-server',
+				),
+				actions: {
+					primary: [
+						{
+							id: 'understand',
+							label: localize('confirmInsecure', "I understand"),
+							tooltip: '',
+							class: undefined,
+							enabled: true,
+							checked: true,
+							run: () => {
+								return Promise.resolve();
+							},
+						},
+					],
+				},
+			});
+		}
 	}
 }