go/chat/convdevstorage_test.go - master - githubmirror/client

go/chat/convdevstorage_test.go
129 строк4 KB
Mike Maxim
real attachment upload for EmojiSource (#23117)
18 мар 2020, 06:18
18 мар 2020, 06:18881694a
package chat

import (
	"testing"

	"github.com/keybase/client/go/protocol/chat1"
	"github.com/stretchr/testify/require"
)

func TestDevConversationBackedStorageTeamAdminOnly(t *testing.T) {
	useRemoteMock = false
	defer func() { useRemoteMock = true }()
	ctc := makeChatTestContext(t, t.Name(), 2)
	defer ctc.cleanup()

	users := ctc.users()

	alice := users[0]
	tc := ctc.world.Tcs[alice.Username]
	ri := ctc.as(t, alice).ri
	ctx := ctc.as(t, alice).startCtx
	uid := alice.User.GetUID().ToBytes()
	storage := NewConvDevConversationBackedStorage(tc.Context(),
		chat1.TopicType_DEV, true /* adminOnly */, func() chat1.RemoteInterface { return ri })
	var msg string

	bob := users[1]
	readeruid := bob.User.GetUID().ToBytes()
	readertc := ctc.world.Tcs[bob.Username]
	readerri := ctc.as(t, bob).ri
	readerctx := ctc.as(t, bob).startCtx
	readerstorage := NewConvDevConversationBackedStorage(readertc.Context(),
		chat1.TopicType_DEV, true /* adminOnly */, func() chat1.RemoteInterface { return readerri })
	var readermsg string

	conv := mustCreateChannelForTest(t, ctc, alice, chat1.TopicType_CHAT, nil,
		chat1.ConversationMembersType_TEAM, bob)
	key0 := "mykey"

	found, _, err := storage.Get(ctx, uid, conv.Id, key0, &msg, false)
	require.NoError(t, err)
	require.False(t, found)
	found, _, err = readerstorage.Get(readerctx, readeruid, conv.Id, key0, &readermsg, false)
	require.NoError(t, err)
	require.False(t, found)

	err = storage.Put(ctx, uid, conv.Id, key0, "hello")
	require.NoError(t, err)

	err = readerstorage.Put(readerctx, readeruid, conv.Id, key0, "hello")
	require.Error(t, err)
	require.IsType(t, &DevStoragePermissionDeniedError{}, err, "got right error")

	found, _, err = storage.Get(ctx, uid, conv.Id, key0, &msg, false)
	require.NoError(t, err)
	require.True(t, found)
	require.Equal(t, msg, "hello")
	found, _, err = readerstorage.Get(readerctx, readeruid, conv.Id, key0, &readermsg, false)
	require.NoError(t, err)
	require.True(t, found)
	require.Equal(t, msg, "hello")
}

func TestDevConversationBackedStorageTeamAdminOnlyReaderMisbehavior(t *testing.T) {
	useRemoteMock = false
	defer func() { useRemoteMock = true }()
	ctc := makeChatTestContext(t, t.Name(), 2)
	defer ctc.cleanup()

	users := ctc.users()

	alice := users[0]
	tc := ctc.world.Tcs[alice.Username]
	ri := ctc.as(t, alice).ri
	ctx := ctc.as(t, alice).startCtx
	uid := alice.User.GetUID().ToBytes()
	storage := NewConvDevConversationBackedStorage(tc.Context(),
		chat1.TopicType_DEV, true /* adminOnly */, func() chat1.RemoteInterface { return ri })
	var msg string

	bob := users[1]
	readertc := ctc.world.Tcs[bob.Username]
	readerri := ctc.as(t, bob).ri
	readerctx := ctc.as(t, bob).startCtx
	readeruid := bob.User.GetUID().ToBytes()
	readerstorage := NewConvDevConversationBackedStorage(readertc.Context(),
		chat1.TopicType_DEV, true /* adminOnly */, func() chat1.RemoteInterface { return readerri })
	var readermsg string

	conv := mustCreateChannelForTest(t, ctc, alice, chat1.TopicType_CHAT, nil,
		chat1.ConversationMembersType_TEAM, bob)
	key0 := "mykey"

	found, _, err := storage.Get(ctx, uid, conv.Id, key0, &msg, false)
	require.NoError(t, err)
	require.False(t, found)
	found, _, err = readerstorage.Get(readerctx, readeruid, conv.Id, key0, &readermsg, false)
	require.NoError(t, err)
	require.False(t, found)

	err = readerstorage.Put(readerctx, readeruid, conv.Id, key0, "evil")
	require.Error(t, err)
	require.IsType(t, &DevStoragePermissionDeniedError{}, err, "got right error")

	// work around client-side protection and make dev channel/msg anyway
	devconv := mustCreateChannelForTest(t, ctc, bob, chat1.TopicType_DEV, &key0,
		chat1.ConversationMembersType_TEAM, alice)
	larg := chat1.PostLocalArg{
		ConversationID: devconv.Id,
		Msg: chat1.MessagePlaintext{
			ClientHeader: chat1.MessageClientHeader{
				Conv:        devconv.Triple,
				TlfName:     devconv.TlfName,
				MessageType: chat1.MessageType_TEXT,
			},
			MessageBody: chat1.NewMessageBodyWithText(chat1.MessageText{Body: "reallyevil"}),
		},
	}
	_, err = ctc.as(t, bob).chatLocalHandler().PostLocal(ctc.as(t, bob).startCtx, larg)
	require.NoError(t, err)

	_, _, err = storage.Get(ctx, uid, conv.Id, key0, &msg, false)
	require.Error(t, err, "got an error after misbehavior")
	require.IsType(t, &DevStorageAdminOnlyError{}, err, "got a permission error")

	_, _, err = readerstorage.Get(readerctx, readeruid, conv.Id, key0, &readermsg, false)
	require.Error(t, err, "got an error after misbehavior")
	require.IsType(t, &DevStorageAdminOnlyError{}, err, "got a permission error")
}