packages/language-service/src/codefixes/fix_missing_required_inputs.ts - main - githubmirror/angular

packages/language-service/src/codefixes/fix_missing_required_inputs.ts
220 строк6 KB
Andrew Scott
refactor: remove all deep imports in language service
13 апр 2026, 11:16
13 апр 2026, 11:161ca9d28
/**
 * @license
 * Copyright Google LLC All Rights Reserved.
 *
 * Use of this source code is governed by an MIT-style license that can be
 * found in the LICENSE file at https://angular.dev/license
 */

import {
  BindingType,
  TmplAstBoundAttribute,
  TmplAstElement,
  TmplAstNode,
  TmplAstTemplate,
  TmplAstTextAttribute,
} from '@angular/compiler';
import {
  ErrorCode,
  InputMapping,
  ngErrorCode,
  TypeCheckableDirectiveMeta,
} from '@angular/compiler-cli';

import ts from 'typescript';

import {getTargetAtPosition, TargetNodeKind} from '../template_target';

import {CodeActionContext, CodeActionMeta, FixIdForCodeFixesAll} from './utils';

/**
 * This code action will fix the missing required input of an element.
 */
export const fixMissingRequiredInput: CodeActionMeta = {
  errorCodes: [ngErrorCode(ErrorCode.MISSING_REQUIRED_INPUTS)],
  getCodeActions: function ({typeCheckInfo, start, compiler, fileName}: CodeActionContext) {
    if (typeCheckInfo === null) {
      return [];
    }

    const positionDetails = getTargetAtPosition(typeCheckInfo.nodes, start);
    if (positionDetails === null) {
      return [];
    }

    // For two-way bindings, we actually only need to be concerned with the bound attribute because
    // the bindings in the template are written with the attribute name, not the event name.
    const node =
      positionDetails.context.kind === TargetNodeKind.TwoWayBindingContext
        ? positionDetails.context.nodes[0]
        : positionDetails.context.node;

    if (!(node instanceof TmplAstElement || node instanceof TmplAstTemplate)) {
      return [];
    }

    let tagName: string | null = null;
    if (node instanceof TmplAstElement) {
      tagName = node.name;
    } else {
      tagName = node.tagName;
    }
    if (tagName === null) {
      return [];
    }

    let insertPosition = node.startSourceSpan.start.offset + tagName.length + 1;
    const lastAttribute = findLastAttributeInTheElement(node);
    if (lastAttribute !== null) {
      insertPosition = lastAttribute.sourceSpan.end.offset;
    }

    const ttc = compiler.getTemplateTypeChecker();

    const symbol = ttc.getSymbolOfNode(node, typeCheckInfo.declaration);
    if (symbol === null) {
      return [];
    }

    const codeActions: ts.CodeFixAction[] = [];

    for (const dirSymbol of symbol.directives) {
      const directive = ttc.getTsSymbolOfSymbol(dirSymbol)?.valueDeclaration;
      if (!directive || !ts.isClassDeclaration(directive)) {
        continue;
      }

      const meta = ttc.getDirectiveMetadata(directive);
      if (meta === null) {
        continue;
      }

      const seenRequiredInputs = new Set<string>();

      const boundAttrs = getBoundAttributes(meta, node);
      for (const attr of boundAttrs) {
        for (const {fieldName, required} of attr.inputs) {
          if (required) {
            seenRequiredInputs.add(fieldName);
          }
        }
      }

      for (const input of meta.inputs) {
        if (!input.required || seenRequiredInputs.has(input.classPropertyName)) {
          continue;
        }
        const typeCheck = compiler.getCurrentProgram().getTypeChecker();
        const memberSymbol = typeCheck.getPropertyOfType(
          ttc.getTypeOfSymbol(dirSymbol)!,
          input.classPropertyName,
        );
        if (memberSymbol === undefined) {
          continue;
        }

        // As a general solution, always offer a property binding suggestion (e.g., `[inputName]=""`).
        // This is the most versatile way for users to satisfy a required input,
        // allowing them to bind to component properties or provide initial literal values.
        const insertBoundText = `[${input.bindingPropertyName}]=""`;
        codeActions.push({
          fixName: FixIdForCodeFixesAll.FIX_MISSING_REQUIRED_INPUTS,
          // fixId: FixIdForCodeFixesAll.FIX_MISSING_REQUIRED_INPUTS,
          // fixAllDescription: '',
          description: `Create ${insertBoundText} attribute for "${tagName}"`,
          changes: [
            {
              fileName,
              textChanges: [
                {
                  span: ts.createTextSpan(insertPosition, 0),
                  newText: ' ' + insertBoundText,
                },
              ],
            },
          ],
        });
      }
    }

    return codeActions;
  },
  fixIds: [FixIdForCodeFixesAll.FIX_MISSING_REQUIRED_INPUTS],
  getAllCodeActions: function () {
    return {
      changes: [],
    };
  },
};

interface TcbBoundAttribute {
  attribute: TmplAstBoundAttribute | TmplAstTextAttribute;
  inputs: {
    fieldName: string;
    required: boolean;
  }[];
}

function getBoundAttributes(
  directive: TypeCheckableDirectiveMeta,
  node: TmplAstTemplate | TmplAstElement,
): TcbBoundAttribute[] {
  const boundInputs: TcbBoundAttribute[] = [];

  const processAttribute = (attr: TmplAstBoundAttribute | TmplAstTextAttribute) => {
    // Skip non-property bindings.
    if (attr instanceof TmplAstBoundAttribute && attr.type !== BindingType.Property) {
      return;
    }

    // Skip the attribute if the directive does not have an input for it.
    const inputs = directive.inputs.getByBindingPropertyName(attr.name);

    if (inputs !== null) {
      boundInputs.push({
        attribute: attr,
        inputs: inputs.map((input: InputMapping) => ({
          fieldName: input.classPropertyName,
          required: input.required,
        })),
      });
    }
  };

  node.inputs.forEach(processAttribute);
  node.attributes.forEach(processAttribute);
  if (node instanceof TmplAstTemplate) {
    node.templateAttrs.forEach(processAttribute);
  }

  return boundInputs;
}

/**
 * If the last attribute is from the structural directive, it is skipped and returns
 * the previous attribute.
 */
function findLastAttributeInTheElement(
  element: TmplAstElement | TmplAstTemplate,
): TmplAstNode | null {
  let lastAttribute: TmplAstNode | null = null;

  const updateAttribute = (attr: TmplAstNode) => {
    if (lastAttribute === null) {
      lastAttribute = attr;
      return;
    }
    if (attr.sourceSpan.end.offset < lastAttribute.sourceSpan.end.offset) {
      return;
    }
    lastAttribute = attr;
  };

  const attrNodes = [...element.attributes, ...element.inputs, ...element.outputs];

  for (const attr of attrNodes) {
    updateAttribute(attr);
  }

  return lastAttribute;
}