src/modules/powerdisplay/PowerDisplay.Lib.UnitTests/MonitorIdentityTests.cs - main - githubmirror/PowerToys

src/modules/powerdisplay/PowerDisplay.Lib.UnitTests/MonitorIdentityTests.cs
230 строк10 KB
moooyo
[PowerDisplay] Detect built-in panel when driven by the discrete GPU (#48637)
22 июн 2026, 08:37
22 июн 2026, 08:3732ad98a
// Copyright (c) Microsoft Corporation
// The Microsoft Corporation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using Microsoft.VisualStudio.TestTools.UnitTesting;
using PowerDisplay.Common.Models;

namespace PowerDisplay.UnitTests;

[TestClass]
public class MonitorIdentityTests
{
    [TestMethod]
    public void FromDevicePath_StripsTrailingGuid()
    {
        var input = @"\\?\DISPLAY#DELD1A8#5&abc123&0&UID12345#{e6f07b5f-ee97-4a90-b076-33f57bf4eaa7}";
        var expected = @"\\?\DISPLAY#DELD1A8#5&abc123&0&UID12345";

        var result = MonitorIdentity.FromDevicePath(input);

        Assert.AreEqual(expected, result);
    }

    [TestMethod]
    public void FromDevicePath_NoTrailingGuid_ReturnsInputUnchanged()
    {
        var input = @"\\?\DISPLAY#DELD1A8#5&abc123&0&UID12345";

        var result = MonitorIdentity.FromDevicePath(input);

        Assert.AreEqual(input, result);
    }

    [TestMethod]
    public void FromDevicePath_NullOrEmpty_ReturnsEmptyString()
    {
        Assert.AreEqual(string.Empty, MonitorIdentity.FromDevicePath(null!));
        Assert.AreEqual(string.Empty, MonitorIdentity.FromDevicePath(string.Empty));
    }

    [TestMethod]
    public void FromInstanceName_StripsSuffixNormalizesSeparatorAndAddsPrefix()
    {
        var input = @"DISPLAY\BOE0900\4&40f4dee&0&UID8388688_0";
        var expected = @"\\?\DISPLAY#BOE0900#4&40f4dee&0&UID8388688";

        Assert.AreEqual(expected, MonitorIdentity.FromInstanceName(input));
    }

    [TestMethod]
    public void FromInstanceName_MatchesFromDevicePath_ForSamePhysicalMonitor()
    {
        // The core invariant of the WMI<->QueryDisplayConfig join: a WMI InstanceName and
        // the matching DevicePath for the same physical monitor must reduce to the identical
        // Monitor.Id, so WMI brightness instances can be paired with inventory entries with a
        // single lookup — even on dual-internal-panel devices (Yoga Book 9i, Zenbook Duo)
        // where the EdidId alone collides.
        var instanceName = @"DISPLAY\BOE0900\4&40f4dee&0&UID8388688_0";
        var devicePath = @"\\?\DISPLAY#BOE0900#4&40f4dee&0&UID8388688#{e6f07b5f-ee97-4a90-b076-33f57bf4eaa7}";

        var idFromInstance = MonitorIdentity.FromInstanceName(instanceName);

        Assert.AreEqual(MonitorIdentity.FromDevicePath(devicePath), idFromInstance);
        Assert.IsFalse(string.IsNullOrEmpty(idFromInstance), "expected non-empty id");
    }

    [TestMethod]
    public void FromInstanceName_DiscreteGpuExternalReportedPanel_StillMatchesInventory()
    {
        // Issue #48587: on a dual-GPU laptop the built-in panel driven by the discrete GPU is
        // reported by QueryDisplayConfig as DisplayPort-External, yet WmiMonitorBrightness
        // still exposes it. The InstanceName and DevicePath captured in that state must reduce
        // to the same Monitor.Id so WMI can claim the panel and brightness control keeps working.
        var instanceName = @"DISPLAY\BOE0D79\5&1abcdef7&0&UID4352_0";
        var devicePath = @"\\?\DISPLAY#BOE0D79#5&1abcdef7&0&UID4352#{e6f07b5f-ee97-4a90-b076-33f57bf4eaa7}";

        Assert.AreEqual(
            MonitorIdentity.FromDevicePath(devicePath),
            MonitorIdentity.FromInstanceName(instanceName));
    }

    [TestMethod]
    public void FromInstanceName_DualInternalPanel_DistinguishesByUid()
    {
        // Yoga Book 9i style: two identical internal panels (same EdidId BOE0900) with
        // different PnP UIDs must reduce to different Monitor.Ids so the two WMI brightness
        // instances each pair with the correct inventory entry.
        var panelA = @"DISPLAY\BOE0900\4&abcdef&0&UID111_0";
        var panelB = @"DISPLAY\BOE0900\4&abcdef&0&UID222_0";

        Assert.AreNotEqual(
            MonitorIdentity.FromInstanceName(panelA),
            MonitorIdentity.FromInstanceName(panelB));
    }

    [TestMethod]
    public void FromInstanceName_MultiDigitSuffix_StrippedCorrectly()
    {
        // WMI instance suffix can be _0, _1, _10, etc. — LastIndexOf('_') ensures we strip
        // only the trailing suffix, not an underscore inside the UID itself.
        var input = @"DISPLAY\BOE0900\4&40f4dee&0&UID8388688_12";
        var expected = @"\\?\DISPLAY#BOE0900#4&40f4dee&0&UID8388688";

        Assert.AreEqual(expected, MonitorIdentity.FromInstanceName(input));
    }

    [TestMethod]
    public void FromInstanceName_NullEmptyOrMalformed_ReturnsEmpty()
    {
        Assert.AreEqual(string.Empty, MonitorIdentity.FromInstanceName(null));
        Assert.AreEqual(string.Empty, MonitorIdentity.FromInstanceName(string.Empty));
        Assert.AreEqual(string.Empty, MonitorIdentity.FromInstanceName(@"DISPLAY"));
        Assert.AreEqual(string.Empty, MonitorIdentity.FromInstanceName(@"DISPLAY\BOE0900"));
    }

    [TestMethod]
    public void EdidIdFromMonitorId_NewFormat_ReturnsMiddleSegment()
    {
        var input = @"\\?\DISPLAY#DELD1A8#5&abc123&0&UID12345";

        Assert.AreEqual("DELD1A8", MonitorIdentity.EdidIdFromMonitorId(input));
    }

    [TestMethod]
    public void EdidIdFromMonitorId_RawDevicePathWithTrailingGuid_ReturnsMiddleSegment()
    {
        // The Phase 0 classification log calls EdidIdFromMonitorId with a raw
        // QueryDisplayConfig DevicePath (still carrying the trailing "#{guid}" segment).
        // The helper must extract the EdidId correctly for that form too.
        var input = @"\\?\DISPLAY#DELD1A8#5&abc123&0&UID12345#{e6f07b5f-ee97-4a90-b076-33f57bf4eaa7}";

        Assert.AreEqual("DELD1A8", MonitorIdentity.EdidIdFromMonitorId(input));
    }

    [TestMethod]
    public void EdidIdFromMonitorId_SameModelMonitorsProduceSameId()
    {
        // Two Dell U2723QE on different ports share an EdidId but have different UIDs.
        // Logging the EdidId identifies the model for crash correlation without leaking
        // per-unit identifiers.
        var portA = @"\\?\DISPLAY#DELD1A8#5&abc&0&UID111#{guid}";
        var portB = @"\\?\DISPLAY#DELD1A8#5&xyz&0&UID222#{guid}";

        Assert.AreEqual(
            MonitorIdentity.EdidIdFromMonitorId(portA),
            MonitorIdentity.EdidIdFromMonitorId(portB));
    }

    [TestMethod]
    public void EdidIdFromMonitorId_NullEmptyOrMalformed_ReturnsEmpty()
    {
        Assert.AreEqual(string.Empty, MonitorIdentity.EdidIdFromMonitorId(null));
        Assert.AreEqual(string.Empty, MonitorIdentity.EdidIdFromMonitorId(string.Empty));
        Assert.AreEqual(string.Empty, MonitorIdentity.EdidIdFromMonitorId(@"\\?\DISPLAY"));
        Assert.AreEqual(string.Empty, MonitorIdentity.EdidIdFromMonitorId(@"\\?\DISPLAY#"));
        Assert.AreEqual(string.Empty, MonitorIdentity.EdidIdFromMonitorId("DDC_DELD1A8_1"));
    }

    [TestMethod]
    public void IsLegacyId_MatchesDdcAndWmiPrefixWithDigitSuffix()
    {
        Assert.IsTrue(MonitorIdentity.IsLegacyId("DDC_DELD1A8_1"));
        Assert.IsTrue(MonitorIdentity.IsLegacyId("WMI_BOE0900_2"));
        Assert.IsTrue(MonitorIdentity.IsLegacyId("DDC_Unknown_3"));
        Assert.IsTrue(MonitorIdentity.IsLegacyId("WMI_Unknown_10"));
    }

    [TestMethod]
    public void IsLegacyId_RejectsNewFormatAndMalformed()
    {
        Assert.IsFalse(MonitorIdentity.IsLegacyId(null));
        Assert.IsFalse(MonitorIdentity.IsLegacyId(string.Empty));
        Assert.IsFalse(MonitorIdentity.IsLegacyId(@"\\?\DISPLAY#DELD1A8#5&abc&0&UID12345"));
        Assert.IsFalse(MonitorIdentity.IsLegacyId("HDR_DELD1A8_1"));   // unknown source prefix
        Assert.IsFalse(MonitorIdentity.IsLegacyId("DDC_DELD1A8_"));    // empty number suffix
        Assert.IsFalse(MonitorIdentity.IsLegacyId("DDC__1"));           // empty EdidId segment
        Assert.IsFalse(MonitorIdentity.IsLegacyId("DDC_DELD1A8_abc"));  // non-digit suffix
    }

    [TestMethod]
    public void LegacyEdidId_ReturnsMiddleSegment()
    {
        Assert.AreEqual("DELD1A8", MonitorIdentity.LegacyEdidId("DDC_DELD1A8_1"));
        Assert.AreEqual("BOE0900", MonitorIdentity.LegacyEdidId("WMI_BOE0900_2"));
    }

    [TestMethod]
    public void LegacyEdidId_UnknownPlaceholderReturnsEmpty()
    {
        // "Unknown" is the placeholder PowerDisplay wrote when EDID was unavailable —
        // it can never identify a specific monitor, so migration must skip these.
        Assert.AreEqual(string.Empty, MonitorIdentity.LegacyEdidId("DDC_Unknown_1"));
        Assert.AreEqual(string.Empty, MonitorIdentity.LegacyEdidId("WMI_Unknown_2"));
    }

    [TestMethod]
    public void LegacyEdidId_NewFormatReturnsEmpty()
    {
        Assert.AreEqual(string.Empty, MonitorIdentity.LegacyEdidId(@"\\?\DISPLAY#DELD1A8#5&abc&0&UID12345"));
        Assert.AreEqual(string.Empty, MonitorIdentity.LegacyEdidId(null));
        Assert.AreEqual(string.Empty, MonitorIdentity.LegacyEdidId(string.Empty));
    }

    [TestMethod]
    public void LegacyMonitorNumber_ReturnsTrailingDigits()
    {
        Assert.AreEqual(1, MonitorIdentity.LegacyMonitorNumber("DDC_DELD1A8_1"));
        Assert.AreEqual(2, MonitorIdentity.LegacyMonitorNumber("WMI_BOE0900_2"));
        Assert.AreEqual(10, MonitorIdentity.LegacyMonitorNumber("DDC_DELD1A8_10"));
    }

    [TestMethod]
    public void LegacyMonitorNumber_ParsesEvenForUnknownEdid()
    {
        // LegacyEdidId returns empty for the "Unknown" placeholder, but the trailing
        // digits are still well-formed. Callers gate on the (EdidId, MonitorNumber)
        // pair, so reading the number cleanly is fine here.
        Assert.AreEqual(3, MonitorIdentity.LegacyMonitorNumber("DDC_Unknown_3"));
    }

    [TestMethod]
    public void LegacyMonitorNumber_NewFormatOrMalformedReturnsZero()
    {
        Assert.AreEqual(0, MonitorIdentity.LegacyMonitorNumber(null));
        Assert.AreEqual(0, MonitorIdentity.LegacyMonitorNumber(string.Empty));
        Assert.AreEqual(0, MonitorIdentity.LegacyMonitorNumber(@"\\?\DISPLAY#DELD1A8#5&abc&0&UID12345"));
        Assert.AreEqual(0, MonitorIdentity.LegacyMonitorNumber("DDC_DELD1A8_abc"));
        Assert.AreEqual(0, MonitorIdentity.LegacyMonitorNumber("DDC_DELD1A8_"));
    }
}