src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.RemoteDesktop/Commands/OpenRemoteDesktopCommand.cs - main - githubmirror/PowerToys

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.RemoteDesktop/Commands/OpenRemoteDesktopCommand.cs
95 строк3 KB
Michael Jolley
CmdPal: Fix RDP extension rejecting host:port connections (#45740)
23 фев 2026, 06:14
23 фев 2026, 06:14009ee75
// Copyright (c) Microsoft Corporation
// The Microsoft Corporation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using System;
using System.Diagnostics;
using System.Text;
using Microsoft.CmdPal.Ext.RemoteDesktop.Properties;
using Microsoft.CommandPalette.Extensions;
using Microsoft.CommandPalette.Extensions.Toolkit;

namespace Microsoft.CmdPal.Ext.RemoteDesktop.Commands;

internal sealed partial class OpenRemoteDesktopCommand : BaseObservable, IInvokableCommand
{
    private static readonly CompositeFormat ProcessErrorFormat =
        CompositeFormat.Parse(Resources.remotedesktop_log_mstsc_error);

    private static readonly CompositeFormat InvalidHostnameFormat =
        CompositeFormat.Parse(Resources.remotedesktop_log_invalid_hostname);

    public string Name { get; }

    public string Id { get; } = "com.microsoft.cmdpal.builtin.remotedesktop.openrdp";

    public IIconInfo Icon => Icons.RDPIcon;

    private readonly string _rdpHost;

    public OpenRemoteDesktopCommand(string rdpHost)
    {
        _rdpHost = rdpHost;

        Name = string.IsNullOrWhiteSpace(_rdpHost) ?
                    Resources.remotedesktop_command_open :
                    Resources.remotedesktop_command_connect;
    }

    public ICommandResult Invoke(object sender)
    {
        using var process = new Process();
        process.StartInfo.UseShellExecute = false;
        process.StartInfo.WorkingDirectory = Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments);
        process.StartInfo.FileName = "mstsc";

        if (!string.IsNullOrWhiteSpace(_rdpHost))
        {
            // validate that _rdpHost is a proper hostname or IP address
            // Strip port suffix (e.g. "localhost:3389") before validation,
            // since Uri.CheckHostName does not accept host:port strings.
            var hostForValidation = _rdpHost;
            var lastColon = _rdpHost.LastIndexOf(':');
            if (lastColon > 0 && lastColon < _rdpHost.Length - 1)
            {
                var portPart = _rdpHost.Substring(lastColon + 1);
                if (ushort.TryParse(portPart, out _))
                {
                    hostForValidation = _rdpHost.Substring(0, lastColon);
                }
            }

            if (Uri.CheckHostName(hostForValidation) == UriHostNameType.Unknown)
            {
                return CommandResult.ShowToast(new ToastArgs()
                {
                    Message = string.Format(
                        System.Globalization.CultureInfo.CurrentCulture,
                        InvalidHostnameFormat,
                        _rdpHost),
                    Result = CommandResult.KeepOpen(),
                });
            }

            process.StartInfo.Arguments = $"/v:{_rdpHost}";
        }

        try
        {
            process.Start();

            return CommandResult.Dismiss();
        }
        catch (Exception ex)
        {
            return CommandResult.ShowToast(new ToastArgs()
            {
                Message = string.Format(
                    System.Globalization.CultureInfo.CurrentCulture,
                    ProcessErrorFormat,
                    ex.Message),
                Result = CommandResult.KeepOpen(),
            });
        }
    }
}