src/Files.App/Data/Contexts/ContentPage/ContentPageContext.cs - main - githubmirror/Files

src/Files.App/Data/Contexts/ContentPage/ContentPageContext.cs
271 строка9 KB
Yair
Code Quality: Fix COMException in property notifications during UI teardown
19 апр 2026, 17:35
19 апр 2026, 17:35f796178
// Copyright (c) Files Community
// Licensed under the MIT License.

using Microsoft.Extensions.Logging;
using System.Collections.Immutable;
using System.Runtime.InteropServices;

namespace Files.App.Data.Contexts
{
	internal sealed partial class ContentPageContext : ObservableObject, IContentPageContext
	{
		private static readonly IReadOnlyList<ListedItem> emptyItems = Enumerable.Empty<ListedItem>().ToImmutableList();

		private readonly IMultiPanesContext context = Ioc.Default.GetRequiredService<IMultiPanesContext>();

		private ShellViewModel? filesystemViewModel;

		public IShellPage? ShellPage => context?.ActivePaneOrColumn;

		public Type PageLayoutType => ShellPage?.CurrentPageType ?? typeof(DetailsLayoutPage);

		private ContentPageTypes pageType = ContentPageTypes.None;
		public ContentPageTypes PageType => pageType;

		public ListedItem? Folder => ShellPage?.ShellViewModel?.CurrentFolder;

		public bool HasItem => ShellPage?.ToolbarViewModel?.HasItem ?? false;

		public bool HasSelection => SelectedItems.Count is not 0;
		public ListedItem? SelectedItem => SelectedItems.Count is 1 ? SelectedItems[0] : null;

		private IReadOnlyList<ListedItem> selectedItems = emptyItems;
		public IReadOnlyList<ListedItem> SelectedItems => selectedItems;

		public bool CanRefresh => ShellPage is not null && ShellPage.ToolbarViewModel.CanRefresh;

		public bool CanGoBack => ShellPage is not null && ShellPage.ToolbarViewModel.CanGoBack;

		public bool CanGoForward => ShellPage is not null && ShellPage.ToolbarViewModel.CanGoForward;

		public bool CanNavigateToParent => ShellPage is not null && ShellPage.ToolbarViewModel.CanNavigateToParent;

		public bool CanCreateItem => GetCanCreateItem();

		public bool IsMultiPaneAvailable => ShellPage is not null && ShellPage.PaneHolder is not null && ShellPage.PaneHolder.IsMultiPaneAvailable;

		public bool IsMultiPaneActive => ShellPage is not null && ShellPage.PaneHolder is not null && ShellPage.PaneHolder.IsMultiPaneActive;

		public bool IsGitRepository => ShellPage is not null && ShellPage.InstanceViewModel.IsGitRepository;

		public bool CanExecuteGitAction => IsGitRepository && !GitHelpers.IsExecutingGitAction;

		public string? SolutionFilePath => ShellPage?.ShellViewModel?.SolutionFilePath;

		public ContentPageContext()
		{
			context.ActivePaneChanging += Context_Changing;
			context.ActivePaneChanged += Context_Changed;
			GitHelpers.IsExecutingGitActionChanged += GitHelpers_IsExecutingGitActionChanged;

			Update();
		}

		// XAML bindings can be torn down during navigation/tab switches; swallow the resulting COMException
		// rather than propagating it through CsWinRT's native delegate boundaries.
		protected override void OnPropertyChanged(PropertyChangedEventArgs e)
		{
			try
			{
				base.OnPropertyChanged(e);
			}
			catch (COMException ex)
			{
				// Expected during app/pane/tab teardown when XAML bindings are destroyed
				App.Logger.LogInformation($"ContentPageContext.OnPropertyChanged: Suppressed COMException for property '{e.PropertyName}': {ex.HResult}");
			}
		}

		private void GitHelpers_IsExecutingGitActionChanged(object? sender, PropertyChangedEventArgs e)
		{
			OnPropertyChanged(nameof(CanExecuteGitAction));
		}

		private void Context_Changing(object? sender, EventArgs e)
		{
			if (ShellPage is IShellPage page)
			{
				page.PropertyChanged -= Page_PropertyChanged;
				page.ContentChanged -= Page_ContentChanged;
				page.InstanceViewModel.PropertyChanged -= InstanceViewModel_PropertyChanged;
				page.ToolbarViewModel.PropertyChanged -= ToolbarViewModel_PropertyChanged;

				if (page.PaneHolder is not null)
					page.PaneHolder.PropertyChanged -= PaneHolder_PropertyChanged;
			}

			if (filesystemViewModel is not null)
				filesystemViewModel.PropertyChanged -= FilesystemViewModel_PropertyChanged;
			filesystemViewModel = null;

			OnPropertyChanging(nameof(ShellPage));
		}
		private void Context_Changed(object? sender, EventArgs e)
		{
			if (ShellPage is IShellPage page)
			{
				page.PropertyChanged += Page_PropertyChanged;
				page.ContentChanged += Page_ContentChanged;
				page.InstanceViewModel.PropertyChanged += InstanceViewModel_PropertyChanged;
				page.ToolbarViewModel.PropertyChanged += ToolbarViewModel_PropertyChanged;

				if (page.PaneHolder is not null)
					page.PaneHolder.PropertyChanged += PaneHolder_PropertyChanged;
			}

			filesystemViewModel = ShellPage?.ShellViewModel;
			if (filesystemViewModel is not null)
				filesystemViewModel.PropertyChanged += FilesystemViewModel_PropertyChanged;

			Update();
			OnPropertyChanged(nameof(ShellPage));
			OnPropertyChanged(nameof(Folder));
		}

		private void Page_PropertyChanged(object? sender, PropertyChangedEventArgs e)
		{
			switch (e.PropertyName)
			{
				case nameof(ShellPage.CurrentPageType):
					OnPropertyChanged(nameof(PageLayoutType));
					break;
				case nameof(ShellPage.PaneHolder):
					OnPropertyChanged(nameof(IsMultiPaneAvailable));
					OnPropertyChanged(nameof(IsMultiPaneActive));
					break;
			}
		}

		private void Page_ContentChanged(object? sender, TabBarItemParameter e) => Update();

		private void PaneHolder_PropertyChanged(object? sender, PropertyChangedEventArgs e)
		{
			switch (e.PropertyName)
			{
				case nameof(IShellPanesPage.IsMultiPaneAvailable):
				case nameof(IShellPanesPage.IsMultiPaneActive):
					OnPropertyChanged(e.PropertyName);
					break;
			}
		}

		private void InstanceViewModel_PropertyChanged(object? sender, PropertyChangedEventArgs e)
		{
			switch (e.PropertyName)
			{
				case nameof(CurrentInstanceViewModel.IsPageTypeNotHome):
				case nameof(CurrentInstanceViewModel.IsPageTypeRecycleBin):
				case nameof(CurrentInstanceViewModel.IsPageTypeZipFolder):
				case nameof(CurrentInstanceViewModel.IsPageTypeFtp):
				case nameof(CurrentInstanceViewModel.IsPageTypeLibrary):
				case nameof(CurrentInstanceViewModel.IsPageTypeCloudDrive):
				case nameof(CurrentInstanceViewModel.IsPageTypeMtpDevice):
				case nameof(CurrentInstanceViewModel.IsPageTypeSearchResults):
				case nameof(CurrentInstanceViewModel.IsPageTypeReleaseNotes):
				case nameof(CurrentInstanceViewModel.IsPageTypeSettings):
					UpdatePageType();
					break;
				case nameof(CurrentInstanceViewModel.IsGitRepository):
					OnPropertyChanged(nameof(IsGitRepository));
					OnPropertyChanged(nameof(CanExecuteGitAction));
					break;
			}
		}

		private void ToolbarViewModel_PropertyChanged(object? sender, PropertyChangedEventArgs e)
		{
			switch (e.PropertyName)
			{
				case nameof(NavigationToolbarViewModel.CanGoBack):
				case nameof(NavigationToolbarViewModel.CanGoForward):
				case nameof(NavigationToolbarViewModel.CanNavigateToParent):
				case nameof(NavigationToolbarViewModel.HasItem):
				case nameof(NavigationToolbarViewModel.CanRefresh):
					OnPropertyChanged(e.PropertyName);
					break;
				case nameof(NavigationToolbarViewModel.SelectedItems):
					UpdateSelectedItems();
					break;
			}
		}

		private void FilesystemViewModel_PropertyChanged(object? sender, PropertyChangedEventArgs e)
		{
			switch (e.PropertyName)
			{
				case nameof(ShellViewModel.CurrentFolder):
					OnPropertyChanged(nameof(Folder));
					break;
				case nameof(ShellViewModel.SolutionFilePath):
					OnPropertyChanged(nameof(SolutionFilePath));
					break;
			}
		}

		private void Update()
		{
			UpdatePageType();
			UpdateSelectedItems();

			OnPropertyChanged(nameof(HasItem));
			OnPropertyChanged(nameof(CanGoBack));
			OnPropertyChanged(nameof(CanGoForward));
			OnPropertyChanged(nameof(CanNavigateToParent));
			OnPropertyChanged(nameof(CanRefresh));
			OnPropertyChanged(nameof(CanCreateItem));
			OnPropertyChanged(nameof(IsMultiPaneAvailable));
			OnPropertyChanged(nameof(IsMultiPaneActive));
			OnPropertyChanged(nameof(IsGitRepository));
			OnPropertyChanged(nameof(CanExecuteGitAction));
		}

		private void UpdatePageType()
		{
			var type = ShellPage?.InstanceViewModel switch
			{
				null => ContentPageTypes.None,
				{ IsPageTypeNotHome: false } => ContentPageTypes.Home,
				{ IsPageTypeReleaseNotes: true } => ContentPageTypes.ReleaseNotes,
				{ IsPageTypeRecycleBin: true } => ContentPageTypes.RecycleBin,
				{ IsPageTypeZipFolder: true } => ContentPageTypes.ZipFolder,
				{ IsPageTypeFtp: true } => ContentPageTypes.Ftp,
				{ IsPageTypeLibrary: true } => ContentPageTypes.Library,
				{ IsPageTypeCloudDrive: true } => ContentPageTypes.CloudDrive,
				{ IsPageTypeMtpDevice: true } => ContentPageTypes.MtpDevice,
				{ IsPageTypeSearchResults: true } => ContentPageTypes.SearchResults,
				{ IsPageTypeSettings: true } => ContentPageTypes.Settings,
				_ => ContentPageTypes.Folder,
			};
			SetProperty(ref pageType, type, nameof(PageType));
			OnPropertyChanged(nameof(CanCreateItem));
		}

		private void UpdateSelectedItems()
		{
			bool oldHasSelection = HasSelection;
			ListedItem? oldSelectedItem = SelectedItem;

			IReadOnlyList<ListedItem> items = ShellPage?.ToolbarViewModel?.SelectedItems?.AsReadOnly() ?? emptyItems;
			if (SetProperty(ref selectedItems, items, nameof(SelectedItems)))
			{
				if (HasSelection != oldHasSelection)
					OnPropertyChanged(nameof(HasSelection));
				if (SelectedItem != oldSelectedItem)
					OnPropertyChanged(nameof(SelectedItem));
			}
		}

		private bool GetCanCreateItem()
		{
			return ShellPage is not null &&
				pageType is not ContentPageTypes.None
				and not ContentPageTypes.Home
				and not ContentPageTypes.RecycleBin
				and not ContentPageTypes.ZipFolder
				and not ContentPageTypes.SearchResults
				and not ContentPageTypes.MtpDevice
				and not ContentPageTypes.ReleaseNotes
				and not ContentPageTypes.Settings;
		}
	}
}